Fix linting and type-checking issues

- Fix whitespace in docstring blank lines (ruff W293)
- Add null check before calling _validate_base_url to fix mypy type error
- Ensure url_to_validate is not None before validation

Co-Authored-By: João <joao@crewai.com>

src/crewai/llm.py

@@ -1179,8 +1179,9 @@ class LLM(BaseLLM):
 
     def _validate_call_params(self) -> None:
         """
-        Validate parameters before making a call. Currently this only checks if
-        a response_format is provided and whether the model supports it.
+        Validate parameters before making a call. Currently this checks if
+        a response_format is provided and whether the model supports it, and
+        validates base_url for Ollama connections.
         The custom_llm_provider is dynamically determined from the model:
           - E.g., "openrouter/deepseek/deepseek-chat" yields "openrouter"
           - "gemini/gemini-1.5-pro" yields "gemini"
@@ -1196,6 +1197,56 @@ class LLM(BaseLLM):
                 "Please remove response_format or use a supported model."
             )
 
+        # Validate base_url for Ollama connections
+        if "ollama" in self.model.lower() and (self.base_url or self.api_base):
+            url_to_validate = self.base_url or self.api_base
+            if url_to_validate and not self._validate_base_url(url_to_validate):
+                raise ValueError(
+                    f"Invalid Ollama base_url: '{url_to_validate}'. "
+                    "Please check that the URL format is correct and the IP address is valid. "
+                    "Example: 'http://localhost:11434' or 'http://192.168.1.100:11434'"
+                )
+
+    def _validate_base_url(self, url: str) -> bool:
+        """Validate base_url format and IP address for Ollama connections.
+
+        Args:
+            url: The base URL to validate
+
+        Returns:
+            bool: True if URL is valid, False otherwise
+        """
+        try:
+            import ipaddress
+            from urllib.parse import urlparse
+
+            result = urlparse(url)
+
+            if not all([result.scheme in ("http", "https"), result.netloc]):
+                return False
+
+            # Extract hostname/IP from netloc (remove port if present)
+            hostname = result.hostname
+            if not hostname:
+                return False
+
+            # Check if it looks like an IP address first
+            if all(part.isdigit() for part in hostname.split('.')) and len(hostname.split('.')) == 4:
+                try:
+                    ipaddress.ip_address(hostname)
+                    return True  # Valid IP address
+                except ValueError:
+                    return False  # Invalid IP address
+            else:
+                if hostname == "localhost":
+                    return True
+                if "." in hostname and all(c.isalnum() or c in ".-" for c in hostname):
+                    return True
+                return False
+
+        except Exception:
+            return False
+
     def supports_function_calling(self) -> bool:
         try:
             provider = self._get_custom_llm_provider()

tests/test_llm.py

@@ -711,3 +711,77 @@ def test_ollama_does_not_modify_when_last_is_user(ollama_llm):
     formatted = ollama_llm._format_messages_for_provider(original_messages)
 
     assert formatted == original_messages
+
+
+def test_ollama_invalid_ip_address_validation():
+    """Test that invalid IP addresses in base_url are caught and provide helpful error messages."""
+    with pytest.raises(ValueError) as excinfo:
+        llm = LLM(model="ollama/llama3.1", base_url="http://192.168.0.300:11434")
+        llm.call("Hello")
+    
+    assert "Invalid Ollama base_url" in str(excinfo.value)
+    assert "192.168.0.300" in str(excinfo.value)
+    assert "IP address is valid" in str(excinfo.value)
+
+
+def test_ollama_invalid_url_format_validation():
+    """Test that malformed URLs are caught."""
+    with pytest.raises(ValueError) as excinfo:
+        llm = LLM(model="ollama/llama3.1", base_url="not-a-url")
+        llm.call("Hello")
+    
+    assert "Invalid Ollama base_url" in str(excinfo.value)
+
+
+def test_ollama_valid_urls_pass_validation():
+    """Test that valid Ollama URLs pass validation."""
+    valid_urls = [
+        "http://localhost:11434",
+        "http://127.0.0.1:11434", 
+        "http://192.168.1.100:11434",
+        "https://ollama.example.com:11434"
+    ]
+    
+    for url in valid_urls:
+        llm = LLM(model="ollama/llama3.1", base_url=url)
+        # Should not raise validation error when calling _validate_call_params
+        try:
+            llm._validate_call_params()
+        except ValueError as e:
+            if "Invalid Ollama base_url" in str(e):
+                pytest.fail(f"Valid URL {url} was incorrectly rejected: {e}")
+            raise
+
+
+def test_non_ollama_models_skip_url_validation():
+    """Test that non-Ollama models don't validate base_url."""
+    llm = LLM(model="gpt-4", base_url="http://192.168.0.300:11434")
+    # Should not raise validation error for non-Ollama models
+    try:
+        llm._validate_call_params()
+    except ValueError as e:
+        if "Invalid Ollama base_url" in str(e):
+            pytest.fail(f"Non-Ollama model was incorrectly validated: {e}")
+        raise
+
+
+def test_ollama_api_base_validation():
+    """Test that api_base parameter is also validated for Ollama models."""
+    with pytest.raises(ValueError) as excinfo:
+        llm = LLM(model="ollama/llama3.1", api_base="http://192.168.0.300:11434")
+        llm.call("Hello")
+    
+    assert "Invalid Ollama base_url" in str(excinfo.value)
+    assert "192.168.0.300" in str(excinfo.value)
+
+
+def test_ollama_no_url_provided_passes():
+    """Test that Ollama models without base_url or api_base pass validation."""
+    llm = LLM(model="ollama/llama3.1")
+    # Should not raise validation error when no URL is provided
+    try:
+        llm._validate_call_params()
+    except ValueError as e:
+        if "Invalid Ollama base_url" in str(e):
+            pytest.fail(f"Ollama model without URL was incorrectly validated: {e}")
+        raise