andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-09 08:08:32 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix CI: Rename metadata column to doc_metadata and fix SQL injection vulnerability

Browse Source 
Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
Devin AI
2025-05-22 10:21:07 +00:00
parent f1a91c506b
commit 43866c0f61
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/crewai/knowledge/storage/pgvector_knowledge_storage.py
View File

@@ -28,7 +28,7 @@ class Document(Base): # type: ignore
id = Column(String, primary_key=True)
content = Column(Text)
metadata = Column(Text) # JSON serialized metadata
doc_metadata = Column(Text) # JSON serialized metadata
embedding: Column = Column(Vector(1536)) # Adjust dimension based on embedding model
class PGVectorKnowledgeStorage(BaseKnowledgeStorage):
@@ -109,12 +109,16 @@ class PGVectorKnowledgeStorage(BaseKnowledgeStorage):
try:
query_embedding = self.embedder([query[0]])[0]
sql_query = text(f"""
SELECT id, content, metadata, 1 - (embedding <=> :query_embedding) as similarity
FROM {self.table_name}
sql_query = text("""
SELECT id, content, doc_metadata, 1 - (embedding <=> :query_embedding) as similarity
FROM :table_name
ORDER BY embedding <=> :query_embedding
LIMIT :limit
""")
""").bindparams(
query_embedding=query_embedding,
limit=limit,
table_name=self.table_name
)
results = session.execute(
sql_query,
@@ -128,7 +132,7 @@ class PGVectorKnowledgeStorage(BaseKnowledgeStorage):
formatted_results.append({
"id": row[0],
"context": row[1],
"metadata": row[2],
"metadata": row[2], # Keep the key as 'metadata' for API compatibility
"score": similarity,
})
@@ -173,13 +177,13 @@ class PGVectorKnowledgeStorage(BaseKnowledgeStorage):
if existing:
setattr(existing, "content", doc)
setattr(existing, "metadata", str(meta) if meta else None)
setattr(existing, "doc_metadata", str(meta) if meta else None)
setattr(existing, "embedding", embedding)
else:
new_doc = Document(
id=doc_id,
content=doc,
metadata=str(meta) if meta else None,
doc_metadata=str(meta) if meta else None,
embedding=embedding,
)
session.add(new_doc)