mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-07-08 08:25:09 +00:00
ae05160f48
Review follow-up: the `id` (persistence-restore) branch of _resolve_flow_inputs returned the raw payload, so typo keys passed alongside `id` skipped the unknown-key warning/drop and reached kickoff — which can fail strict (extra="forbid") flow state models. The restore path now still warns on and drops unknown keys (keeping `id` and known state fields); it only skips the required-field prompt and pre-kickoff validation, which persistence hydrates. Regression test: test_id_restore_still_drops_unknown_keys. Also drop the duplicate module import in test_input_prompt.py (both `import` and `from ... import` of crewai_cli.input_prompt) flagged by the code-quality bot; monkeypatching now uses the string target form. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RBYGqJHC2TMC6fonFziuuh
83 lines
2.3 KiB
Python
83 lines
2.3 KiB
Python
"""Tests for the shared runtime-input prompting used by flows and crews."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from crewai_cli.input_prompt import (
|
|
closest_name,
|
|
parse_inputs_json,
|
|
prompt_for_inputs,
|
|
)
|
|
|
|
|
|
def test_parse_inputs_json_returns_none_for_none():
|
|
assert parse_inputs_json(None) is None
|
|
|
|
|
|
def test_parse_inputs_json_parses_object():
|
|
assert parse_inputs_json('{"topic": "AI"}') == {"topic": "AI"}
|
|
|
|
|
|
def test_parse_inputs_json_rejects_invalid_json(capsys):
|
|
with pytest.raises(SystemExit) as exc_info:
|
|
parse_inputs_json("not json")
|
|
|
|
assert exc_info.value.code == 1
|
|
assert "Invalid --inputs JSON" in capsys.readouterr().err
|
|
|
|
|
|
def test_parse_inputs_json_rejects_non_object(capsys):
|
|
with pytest.raises(SystemExit) as exc_info:
|
|
parse_inputs_json("[1, 2, 3]")
|
|
|
|
assert exc_info.value.code == 1
|
|
assert "expected an object" in capsys.readouterr().err
|
|
|
|
|
|
def test_closest_name_suggests_near_miss():
|
|
assert closest_name("prospect_emai", ["prospect_email", "topic"]) == "prospect_email"
|
|
|
|
|
|
def test_closest_name_returns_none_when_nothing_close():
|
|
assert closest_name("zzzzz", ["prospect_email", "topic"]) is None
|
|
|
|
|
|
def test_prompt_for_inputs_uses_describe_and_coerce(monkeypatch, capsys):
|
|
seen: list[str] = []
|
|
|
|
def fake_prompt(text: str, **kwargs: object) -> str:
|
|
seen.append(text)
|
|
return "42"
|
|
|
|
monkeypatch.setattr("crewai_cli.input_prompt.click.prompt", fake_prompt)
|
|
|
|
result = prompt_for_inputs(
|
|
["count"],
|
|
title="Flow inputs",
|
|
subtitle="This flow needs the following to run.",
|
|
describe=lambda name: f"How many {name}?",
|
|
coerce=lambda name, raw: int(raw),
|
|
)
|
|
|
|
captured = capsys.readouterr()
|
|
assert result == {"count": 42}
|
|
assert any("count" in text for text in seen)
|
|
# Header, subtitle, and description hint all render on stderr.
|
|
assert "Flow inputs" in captured.err
|
|
assert "How many count?" in captured.err
|
|
|
|
|
|
def test_prompt_for_inputs_keeps_raw_string_without_coerce(monkeypatch):
|
|
monkeypatch.setattr(
|
|
"crewai_cli.input_prompt.click.prompt", lambda text, **kwargs: "AI"
|
|
)
|
|
|
|
result = prompt_for_inputs(
|
|
["topic"],
|
|
title="Crew inputs",
|
|
subtitle="This crew needs the following to run.",
|
|
)
|
|
|
|
assert result == {"topic": "AI"}
|