Compare commits

...

4 Commits

Author SHA1 Message Date
Devin AI
c1dbe9967d fix: properly format imports with ruff
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-05-06 22:54:40 +00:00
Devin AI
525959f848 fix: resolve lint error by fixing import formatting
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-05-06 22:52:25 +00:00
Devin AI
17efd214fb docs: improve documentation and test assertions as per PR review
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-05-06 22:51:29 +00:00
Devin AI
6fb4438e52 fix: set result_as_answer=True in DelegateWorkTool to fix incomplete final answers in hierarchical process mode (#2768)
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-05-06 22:46:21 +00:00
2 changed files with 62 additions and 1 deletions

View File

@@ -14,10 +14,16 @@ class DelegateWorkToolSchema(BaseModel):
class DelegateWorkTool(BaseAgentTool):
"""Tool for delegating work to coworkers"""
"""Tool for delegating work to other agents in the crew.
Attributes:
result_as_answer (bool): When True, returns the delegated agent's result
as the final answer instead of metadata about delegation.
"""
name: str = "Delegate work to coworker"
args_schema: type[BaseModel] = DelegateWorkToolSchema
result_as_answer: bool = True
def _run(
self,

View File

@@ -0,0 +1,55 @@
"""Test to ensure hierarchical process mode returns complete final answers."""
import pytest
from crewai.agent import Agent
from crewai.crew import Crew
from crewai.process import Process
from crewai.task import Task
@pytest.mark.vcr(filter_headers=["authorization"])
def test_hierarchical_process_delegation_result():
"""Tests hierarchical process delegation result handling.
Ensures that:
1. The output is derived from the delegated agent's actual work.
2. The response does not contain delegation-related metadata.
3. The content meets minimum length requirements.
4. Expected topic-related keywords are present in the output.
"""
researcher = Agent(
role="Researcher",
goal="Make the best research and analysis on content about AI and AI agents",
backstory="You're an expert researcher, specialized in technology, software engineering, AI and startups. You work as a freelancer and is now working on doing research and analysis for a new customer.",
allow_delegation=False,
)
writer = Agent(
role="Senior Writer",
goal="Write the best content about AI and AI agents.",
backstory="You're a senior writer, specialized in technology, software engineering, AI and startups. You work as a freelancer and are now working on writing content for a new customer.",
allow_delegation=False,
)
task = Task(
description="Come up with a list of 3 interesting ideas to explore for an article, then write one amazing paragraph highlight for each idea that showcases how good an article about this topic could be. Return the list of ideas with their paragraph and your notes.",
expected_output="3 bullet points with a paragraph for each idea.",
)
crew = Crew(
agents=[researcher, writer],
process=Process.hierarchical,
manager_llm="gpt-4o",
tasks=[task],
)
result = crew.kickoff()
assert "idea" in result.raw.lower() or "article" in result.raw.lower()
assert len(result.raw) > 100 # Ensure we have substantial content
assert result.raw.count('\n') >= 6 # At least 3 ideas with paragraphs
assert "delegate" not in result.raw.lower()
assert "delegating" not in result.raw.lower()
assert "assigned" not in result.raw.lower()