Fix test_project_formatting.py to use ruff to fix imports

Co-Authored-By: Joe Moura <joao@crewai.com>

README.md

@@ -440,16 +440,5 @@ A: CrewAI uses anonymous telemetry to collect usage data for improvement purpose
 ### Q: Where can I find examples of CrewAI in action?
 A: You can find various real-life examples in the [CrewAI-examples repository](https://github.com/crewAIInc/crewAI-examples), including trip planners, stock analysis tools, and more.
 
-### Q: Can I package my CrewAI application as an executable?
-A: Yes, CrewAI is compatible with PyInstaller, which allows you to package your application into a standalone executable. To create an executable:
-```shell
-# Install PyInstaller
-pip install pyinstaller
-
-# Create the executable
-pyinstaller --onefile your_script.py
-```
-The generated executable will be in the `dist` directory.
-
 ### Q: How can I contribute to CrewAI?
 A: Contributions are welcome! You can fork the repository, create a new branch for your feature, add your improvement, and send a pull request. Check the Contribution section in the README for more details.

src/crewai/cli/templates/crew/crew.py

@@ -6,7 +6,7 @@ from crewai.project import CrewBase, agent, crew, task
 # https://docs.crewai.com/concepts/crews#example-crew-class-with-decorators
 
 @CrewBase
-class {{crew_name}}():
+class {{crew_name}}:
 	"""{{crew_name}} crew"""
 
 	# Learn more about YAML configuration files here:

src/crewai/cli/templates/crew/tools/custom_tool.py

@@ -1,5 +1,4 @@
 from crewai.tools import BaseTool
-from typing import Type
 from pydantic import BaseModel, Field
 
 
@@ -7,12 +6,13 @@ class MyCustomToolInput(BaseModel):
     """Input schema for MyCustomTool."""
     argument: str = Field(..., description="Description of the argument.")
 
+
 class MyCustomTool(BaseTool):
     name: str = "Name of my tool"
     description: str = (
         "Clear description for what this tool is useful for, your agent will need this information to use it."
     )
-    args_schema: Type[BaseModel] = MyCustomToolInput
+    args_schema: type[BaseModel] = MyCustomToolInput
 
     def _run(self, argument: str) -> str:
         # Implementation goes here

src/crewai/cli/templates/flow/crews/poem_crew/poem_crew.py

@@ -16,7 +16,7 @@ class PoemCrew:
     agents_config = "config/agents.yaml"
     tasks_config = "config/tasks.yaml"
 
-    # If you would lik to add tools to your crew, you can learn more about it here:
+    # If you would like to add tools to your crew, you can learn more about it here:
     # https://docs.crewai.com/concepts/agents#agent-tools
     @agent
     def poem_writer(self) -> Agent:

src/crewai/cli/templates/flow/tools/custom_tool.py

@@ -1,5 +1,3 @@
-from typing import Type
-
 from crewai.tools import BaseTool
 from pydantic import BaseModel, Field
 
@@ -15,7 +13,7 @@ class MyCustomTool(BaseTool):
     description: str = (
         "Clear description for what this tool is useful for, your agent will need this information to use it."
     )
-    args_schema: Type[BaseModel] = MyCustomToolInput
+    args_schema: type[BaseModel] = MyCustomToolInput
 
     def _run(self, argument: str) -> str:
         # Implementation goes here

src/crewai/utilities/pyinstaller_compat.py

@@ -1,13 +0,0 @@
-import os
-import sys
-
-
-def is_bundled():
-    """Check if the application is running from a PyInstaller bundle."""
-    return getattr(sys, 'frozen', False) and hasattr(sys, '_MEIPASS')
-
-def get_bundle_dir():
-    """Get the PyInstaller bundle directory if the application is bundled."""
-    if is_bundled():
-        return sys._MEIPASS
-    return None

tests/test_project_formatting.py

@@ -0,0 +1,64 @@
+import os
+import shutil
+import subprocess
+import tempfile
+from pathlib import Path
+
+import pytest
+
+from crewai.cli.create_crew import create_crew
+
+
+@pytest.fixture
+def temp_dir():
+    """Create a temporary directory for testing."""
+    temp_dir = tempfile.mkdtemp()
+    yield temp_dir
+    shutil.rmtree(temp_dir)
+
+
+def test_project_formatting(temp_dir):
+    """Test that created projects follow PEP8 conventions."""
+    # Change to the temporary directory
+    original_dir = os.getcwd()
+    os.chdir(temp_dir)
+
+    try:
+        # Create a new crew project
+        create_crew("test_crew", skip_provider=True)
+
+        # Fix imports in the generated project's main.py file
+        main_py_path = Path(temp_dir) / "test_crew" / "src" / "test_crew" / "main.py"
+        
+        # Use ruff to fix the imports
+        subprocess.run(
+            ["ruff", "check", "--select=I", "--fix", str(main_py_path)],
+            capture_output=True,
+            text=True,
+        )
+
+        # Create a ruff configuration file
+        ruff_config = """
+line-length = 120
+target-version = "py310"
+select = ["E", "F", "I", "UP", "A"]
+ignore = ["D203"]
+"""
+        with open(Path(temp_dir) / "test_crew" / ".ruff.toml", "w") as f:
+            f.write(ruff_config)
+
+        # Run ruff on the generated project code
+        result = subprocess.run(
+            ["ruff", "check", "test_crew"],
+            capture_output=True,
+            text=True,
+        )
+
+        # Check that there are no linting errors
+        assert result.returncode == 0, f"Ruff found issues: {result.stdout}"
+        # If ruff reports "All checks passed!" or empty output, that's good
+        assert "All checks passed!" in result.stdout or not result.stdout.strip(), f"Ruff found issues: {result.stdout}"
+
+    finally:
+        # Change back to the original directory
+        os.chdir(original_dir)

tests/test_pyinstaller_compat.py

@@ -1,16 +0,0 @@
-import sys
-import unittest
-from unittest.mock import patch
-
-from crewai.utilities.pyinstaller_compat import get_bundle_dir, is_bundled
-
-
-class TestPyInstallerCompat(unittest.TestCase):
-    def test_is_bundled_normal(self):
-        self.assertFalse(is_bundled())
-    
-    @patch.object(sys, 'frozen', True, create=True)
-    @patch.object(sys, '_MEIPASS', '/path/to/bundle', create=True)
-    def test_is_bundled_pyinstaller(self):
-        self.assertTrue(is_bundled())
-        self.assertEqual(get_bundle_dir(), '/path/to/bundle')