Compare commits

...

4 Commits

Author SHA1 Message Date
Devin AI
83eccadff2 Fix import sorting with ruff
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-04-04 14:22:53 +00:00
Devin AI
ca4d0f5143 Address PR feedback: Improve code structure and test quality
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-04-04 14:21:41 +00:00
Devin AI
564cd76cb9 Fix import sorting in install_crew_test.py
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-04-04 14:18:44 +00:00
Devin AI
ffe68a3e66 Fix issue #2524: Check if pyproject.toml exists before running uv sync
Co-Authored-By: Joe Moura <joao@crewai.com>
2025-04-04 14:17:14 +00:00
2 changed files with 141 additions and 1 deletions

View File

@@ -1,12 +1,34 @@
import subprocess
from pathlib import Path
from typing import List
import click
def install_crew(proxy_options: list[str]) -> None:
def _check_pyproject_exists() -> bool:
"""
Check if pyproject.toml exists in the current directory.
Returns:
bool: True if pyproject.toml exists, False otherwise.
"""
if not Path("pyproject.toml").exists():
click.echo("Error: No pyproject.toml found in current directory.", err=True)
click.echo("This command must be run from the root of a crew project.", err=True)
return False
return True
def install_crew(proxy_options: List[str]) -> None:
"""
Install the crew by running the UV command to lock and install.
Args:
proxy_options: List of proxy options to pass to UV.
"""
if not _check_pyproject_exists():
return
try:
command = ["uv", "sync"] + proxy_options
subprocess.run(command, check=True, capture_output=False, text=True)

View File

@@ -0,0 +1,118 @@
import subprocess
from pathlib import Path
from typing import List
from unittest import mock
import pytest
from click.testing import CliRunner
from crewai.cli.install_crew import _check_pyproject_exists, install_crew
TEST_CONSTANTS = {
"ERROR_NO_PYPROJECT": "Error: No pyproject.toml found in current directory.",
"ERROR_MUST_RUN_FROM_ROOT": "This command must be run from the root of a crew project.",
"ERROR_RUNNING_CREW": "An error occurred while running the crew",
"ERROR_UNEXPECTED": "An unexpected error occurred: Test exception",
}
@pytest.fixture
def mock_subprocess_run() -> mock.MagicMock:
"""Mock subprocess.run for testing."""
with mock.patch("subprocess.run") as mock_run:
yield mock_run
@pytest.fixture
def mock_path_exists() -> mock.MagicMock:
"""Mock Path.exists for testing."""
with mock.patch("pathlib.Path.exists") as mock_exists:
yield mock_exists
@pytest.mark.parametrize(
"proxy_options,expected_command",
[
([], ["uv", "sync"]),
(["--proxy", "http://proxy.com"], ["uv", "sync", "--proxy", "http://proxy.com"]),
],
)
def test_install_crew_pyproject_exists(
mock_subprocess_run: mock.MagicMock,
mock_path_exists: mock.MagicMock,
proxy_options: List[str],
expected_command: List[str],
) -> None:
"""Test install_crew when pyproject.toml exists."""
mock_path_exists.return_value = True
install_crew(proxy_options)
mock_subprocess_run.assert_called_once_with(
expected_command, check=True, capture_output=False, text=True
)
def test_install_crew_pyproject_not_exists(
mock_subprocess_run: mock.MagicMock,
mock_path_exists: mock.MagicMock,
capsys: pytest.CaptureFixture,
) -> None:
"""Test install_crew when pyproject.toml does not exist."""
mock_path_exists.return_value = False
proxy_options: List[str] = []
install_crew(proxy_options)
mock_subprocess_run.assert_not_called()
captured = capsys.readouterr()
assert TEST_CONSTANTS["ERROR_NO_PYPROJECT"] in captured.err
assert TEST_CONSTANTS["ERROR_MUST_RUN_FROM_ROOT"] in captured.err
def test_install_crew_subprocess_error(
mock_subprocess_run: mock.MagicMock,
mock_path_exists: mock.MagicMock,
capsys: pytest.CaptureFixture,
) -> None:
"""Test install_crew when subprocess raises CalledProcessError."""
mock_path_exists.return_value = True
mock_subprocess_run.side_effect = subprocess.CalledProcessError(
cmd=["uv", "sync"], returncode=1
)
proxy_options: List[str] = []
install_crew(proxy_options)
captured = capsys.readouterr()
assert TEST_CONSTANTS["ERROR_RUNNING_CREW"] in captured.err
def test_install_crew_general_exception(
mock_subprocess_run: mock.MagicMock,
mock_path_exists: mock.MagicMock,
capsys: pytest.CaptureFixture,
) -> None:
"""Test install_crew when a general exception occurs."""
mock_path_exists.return_value = True
mock_subprocess_run.side_effect = Exception("Test exception")
proxy_options: List[str] = []
install_crew(proxy_options)
captured = capsys.readouterr()
assert TEST_CONSTANTS["ERROR_UNEXPECTED"] in captured.err
def test_check_pyproject_exists(
mock_path_exists: mock.MagicMock, capsys: pytest.CaptureFixture
) -> None:
"""Test _check_pyproject_exists function."""
mock_path_exists.return_value = True
assert _check_pyproject_exists() is True
mock_path_exists.return_value = False
assert _check_pyproject_exists() is False
captured = capsys.readouterr()
assert TEST_CONSTANTS["ERROR_NO_PYPROJECT"] in captured.err
assert TEST_CONSTANTS["ERROR_MUST_RUN_FROM_ROOT"] in captured.err