Simplify tests #2

`REDIS_URL` being set was enough to trigger a Redis lock, which would
raise `ImportError` if the `redis` package wasn't available. Added
`_redis_available()` to guard on both the env var and the import.

lib/crewai/src/crewai/utilities/lock_store.py

@@ -1,7 +1,7 @@
 """Centralised lock factory.
 
-If ``REDIS_URL`` is set, locks are distributed via ``portalocker.RedisLock``. Otherwise, falls
-back to the standard ``portalocker.Lock``.
+If ``REDIS_URL`` is set and the ``redis`` package is installed, locks are distributed via
+``portalocker.RedisLock``. Otherwise, falls back to the standard ``portalocker.Lock``.
 """
 
 from __future__ import annotations
@@ -30,6 +30,18 @@ _REDIS_URL: str | None = os.environ.get("REDIS_URL")
 _DEFAULT_TIMEOUT: Final[int] = 120
 
 
+def _redis_available() -> bool:
+    """Return True if redis is installed and REDIS_URL is set."""
+    if not _REDIS_URL:
+        return False
+    try:
+        import redis  # noqa: F401
+
+        return True
+    except ImportError:
+        return False
+
+
 @lru_cache(maxsize=1)
 def _redis_connection() -> redis.Redis:
     """Return a cached Redis connection, creating one on first call."""
@@ -51,7 +63,7 @@ def lock(name: str, *, timeout: float = _DEFAULT_TIMEOUT) -> Iterator[None]:
     """
     channel = f"crewai:{md5(name.encode(), usedforsecurity=False).hexdigest()}"
 
-    if _REDIS_URL:
+    if _redis_available():
         with portalocker.RedisLock(
             channel=channel,
             connection=_redis_connection(),

lib/crewai/tests/utilities/test_lock_store.py

@@ -0,0 +1,70 @@
+"""Tests for lock_store.
+
+We verify our own logic: the _redis_available guard and which portalocker
+backend is selected. We trust portalocker to handle actual locking mechanics.
+"""
+
+from __future__ import annotations
+
+import sys
+from unittest import mock
+
+import pytest
+
+import crewai.utilities.lock_store as lock_store
+from crewai.utilities.lock_store import lock
+
+
+@pytest.fixture(autouse=True)
+def no_redis_url(monkeypatch):
+    monkeypatch.setattr(lock_store, "_REDIS_URL", None)
+
+
+# ---------------------------------------------------------------------------
+# _redis_available
+# ---------------------------------------------------------------------------
+
+
+def test_redis_not_available_without_url():
+    assert lock_store._redis_available() is False
+
+
+def test_redis_not_available_when_package_missing(monkeypatch):
+    monkeypatch.setattr(lock_store, "_REDIS_URL", "redis://localhost:6379")
+    monkeypatch.setitem(sys.modules, "redis", None)  # None → ImportError on import
+    assert lock_store._redis_available() is False
+
+
+def test_redis_available_with_url_and_package(monkeypatch):
+    monkeypatch.setattr(lock_store, "_REDIS_URL", "redis://localhost:6379")
+    monkeypatch.setitem(sys.modules, "redis", mock.MagicMock())
+    assert lock_store._redis_available() is True
+
+
+# ---------------------------------------------------------------------------
+# lock strategy selection
+# ---------------------------------------------------------------------------
+
+
+def test_uses_file_lock_when_redis_unavailable():
+    with mock.patch("portalocker.Lock") as mock_lock:
+        with lock("file_test"):
+            pass
+
+    mock_lock.assert_called_once()
+    assert "crewai:" in mock_lock.call_args.args[0]
+
+
+def test_uses_redis_lock_when_redis_available(monkeypatch):
+    fake_conn = mock.MagicMock()
+    monkeypatch.setattr(lock_store, "_redis_available", mock.Mock(return_value=True))
+    monkeypatch.setattr(lock_store, "_redis_connection", mock.Mock(return_value=fake_conn))
+
+    with mock.patch("portalocker.RedisLock") as mock_redis_lock:
+        with lock("redis_test"):
+            pass
+
+    mock_redis_lock.assert_called_once()
+    kwargs = mock_redis_lock.call_args.kwargs
+    assert kwargs["channel"].startswith("crewai:")
+    assert kwargs["connection"] is fake_conn

uv.lock

@@ -5556,11 +5556,11 @@ wheels = [
 
 [[package]]
 name = "pyasn1"
-version = "0.6.2"
+version = "0.6.3"
 source = { registry = "https://pypi.org/simple" }
-sdist = { url = "https://files.pythonhosted.org/packages/fe/b6/6e630dff89739fcd427e3f72b3d905ce0acb85a45d4ec3e2678718a3487f/pyasn1-0.6.2.tar.gz", hash = "sha256:9b59a2b25ba7e4f8197db7686c09fb33e658b98339fadb826e9512629017833b", size = 146586, upload-time = "2026-01-16T18:04:18.534Z" }
+sdist = { url = "https://files.pythonhosted.org/packages/5c/5f/6583902b6f79b399c9c40674ac384fd9cd77805f9e6205075f828ef11fb2/pyasn1-0.6.3.tar.gz", hash = "sha256:697a8ecd6d98891189184ca1fa05d1bb00e2f84b5977c481452050549c8a72cf", size = 148685, upload-time = "2026-03-17T01:06:53.382Z" }
 wheels = [
-    { url = "https://files.pythonhosted.org/packages/44/b5/a96872e5184f354da9c84ae119971a0a4c221fe9b27a4d94bd43f2596727/pyasn1-0.6.2-py3-none-any.whl", hash = "sha256:1eb26d860996a18e9b6ed05e7aae0e9fc21619fcee6af91cca9bad4fbea224bf", size = 83371, upload-time = "2026-01-16T18:04:17.174Z" },
+    { url = "https://files.pythonhosted.org/packages/5d/a0/7d793dce3fa811fe047d6ae2431c672364b462850c6235ae306c0efd025f/pyasn1-0.6.3-py3-none-any.whl", hash = "sha256:a80184d120f0864a52a073acc6fc642847d0be408e7c7252f31390c0f4eadcde", size = 83997, upload-time = "2026-03-17T01:06:52.036Z" },
 ]
 
 [[package]]