Address PR review feedback: Add type hints and parametrized tests

- Added type hints to all test functions and variables for better maintainability
- Added parametrized test to verify multiple watsonx models can be selected
- Imported pytest for parametrized testing functionality
- All tests continue to pass locally (6 passed)
- Addresses review suggestions from joaomdmoura

Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-06-10 10:27:17 +00:00
parent 18a6973198
commit d8231a04d0

View File

@@ -1,16 +1,18 @@
from typing import List
from unittest.mock import patch
import pytest
from crewai.cli.constants import MODELS
from crewai.cli.provider import select_model
def test_watsonx_models_include_llama4_maverick():
def test_watsonx_models_include_llama4_maverick() -> None:
"""Test that the watsonx models list includes the Llama 4 Maverick model."""
watsonx_models = MODELS.get("watson", [])
watsonx_models: List[str] = MODELS.get("watson", [])
assert "watsonx/meta-llama/llama-4-maverick-17b-128e-instruct-fp8" in watsonx_models
def test_select_model_watsonx_llama4_maverick():
def test_select_model_watsonx_llama4_maverick() -> None:
"""Test that the Llama 4 Maverick model can be selected for watsonx provider."""
provider = "watson"
provider_models = {}
@@ -28,9 +30,9 @@ def test_select_model_watsonx_llama4_maverick():
assert "watsonx/meta-llama/llama-4-maverick-17b-128e-instruct-fp8" in available_models
def test_watsonx_model_list_ordering():
def test_watsonx_model_list_ordering() -> None:
"""Test that watsonx models are properly ordered."""
watsonx_models = MODELS.get("watson", [])
watsonx_models: List[str] = MODELS.get("watson", [])
expected_models = [
"watsonx/meta-llama/llama-3-1-70b-instruct",
@@ -45,3 +47,19 @@ def test_watsonx_model_list_ordering():
]
assert watsonx_models == expected_models
@pytest.mark.parametrize("model_name", [
"watsonx/meta-llama/llama-4-maverick-17b-128e-instruct-fp8",
"watsonx/mistral/mistral-large",
"watsonx/ibm/granite-3-8b-instruct",
])
def test_watsonx_model_selection_parametrized(model_name: str) -> None:
"""Test that various watsonx models can be selected through CLI."""
provider = "watson"
provider_models = {}
with patch("crewai.cli.provider.select_choice") as mock_select_choice:
mock_select_choice.return_value = model_name
result = select_model(provider, provider_models)
assert result == model_name