andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-07-05 15:09:22 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix: enhance memory handling and logging in agent executor

Browse Source 
- Added checks for read-only memory settings in `ConversationalAgentExecutor` to prevent modifications when memory is not writable.
- Improved memory extraction logic to include metadata when remembering memories, enhancing context retention.
- Updated logging from debug to warning level for memory initialization and save failures, ensuring better visibility of issues.

These changes aim to improve the robustness and clarity of memory management within the CrewAI framework.
This commit is contained in:
Joao Moura
2026-05-13 04:51:28 -04:00
committed by alex-clawd
parent ff97ae3e8e
commit d80511898c
2 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/crewai/src/crewai/new_agent/executor.py
View File

@@ -1233,6 +1233,8 @@ class ConversationalAgentExecutor(BaseModel):
"""Save provenance entry to memory backend for long-term auditing."""
if not self.agent._memory_instance:
return
if self.agent.settings.memory_read_only:
return
try:
value = f"[provenance] {entry.action}: {entry.outcome or ''}"
metadata: dict[str, Any] = {
@@ -1253,6 +1255,8 @@ class ConversationalAgentExecutor(BaseModel):
agent = self.agent
if not agent.settings.memory_enabled:
return
if agent.settings.memory_read_only:
return
memory = getattr(agent, "_memory_instance", None)
if memory is None:
return
@@ -1273,7 +1277,11 @@ class ConversationalAgentExecutor(BaseModel):
pass
extracted = memory.extract_memories(raw)
if extracted:
memory.remember_many(extracted, agent_role=agent.role)
scope = self._get_provider_scope()
kwargs: dict[str, Any] = {"agent_role": agent.role}
if scope:
kwargs["metadata"] = scope
memory.remember_many(extracted, **kwargs)
try:
from crewai.new_agent.events import NewAgentMemorySaveEvent
@@ -1288,7 +1296,7 @@ class ConversationalAgentExecutor(BaseModel):
if dreaming:
dreaming.increment_memory_count()
except Exception as e:
logger.debug(f"Memory save failed: {e}")
logger.warning(f"Memory save failed: {e}")
async def ainvoke(self, user_message: Message) -> Message:
"""Process a single conversational turn (async)."""

35
lib/crewai/src/crewai/new_agent/new_agent.py
View File

@@ -232,28 +232,25 @@ class NewAgent(BaseModel):
self._memory_namespace = self.memory.namespace
self._memory_shared = self.memory.shared
self._init_memory_instance()
return
if isinstance(self.memory, MemorySlice):
elif isinstance(self.memory, MemorySlice):
self._memory_namespace = self.memory.scope or None
self._memory_filter = self.memory
self._init_memory_instance()
return
else:
try:
from crewai.memory.unified_memory import Memory
from crewai.memory.utils import sanitize_scope_name
try:
from crewai.memory.unified_memory import Memory
from crewai.memory.utils import sanitize_scope_name
if isinstance(self.memory, Memory):
self._memory_instance = self.memory
elif self.memory is True or self.memory is None:
agent_name = sanitize_scope_name(self.role or str(self.id))
self._memory_instance = Memory(root_scope=f"/agent/{agent_name}")
else:
self._memory_instance = self.memory
except Exception as e:
self._logger.debug(f"Memory initialization failed: {e}")
self._memory_instance = None
if isinstance(self.memory, Memory):
self._memory_instance = self.memory
elif self.memory is True or self.memory is None:
agent_name = sanitize_scope_name(self.role or str(self.id))
self._memory_instance = Memory(root_scope=f"/agent/{agent_name}")
else:
self._memory_instance = self.memory
except Exception as e:
self._logger.warning(f"Memory initialization failed: {e}")
self._memory_instance = None
if self._memory_instance and self.settings.memory_read_only:
self._memory_instance.read_only = True
@@ -276,7 +273,7 @@ class NewAgent(BaseModel):
agent_name = sanitize_scope_name(self.role or str(self.id))
self._memory_instance = Memory(root_scope=f"/agent/{agent_name}")
except Exception as e:
self._logger.debug(f"Memory initialization failed: {e}")
self._logger.warning(f"Memory initialization failed: {e}")
self._memory_instance = None
def _init_tools(self) -> None: