andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-05-02 07:42:40 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix: update test files to use 'limit' instead of 'latest_n' and fix metadata in MemorySaveCompletedEvent

Browse Source
This commit is contained in:
Greyson LaLonde
2025-09-05 09:22:21 -04:00
parent fbcd8bcd83
commit a414e7f2a7
2 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/crewai/memory/long_term/long_term_memory.py
View File

@@ -66,7 +66,7 @@ class LongTermMemory(Memory):
self, self,
event=MemorySaveCompletedEvent( event=MemorySaveCompletedEvent(
value=item.task, value=item.task,
metadata=item.metadata, metadata=metadata,
agent_role=item.agent, agent_role=item.agent,
save_time_ms=(time.time() - start_time) * 1000, save_time_ms=(time.time() - start_time) * 1000,
source_type="long_term_memory", source_type="long_term_memory",

22
tests/memory/test_long_term_memory.py
View File

@@ -1,15 +1,17 @@
import pytest
from unittest.mock import ANY
from collections import defaultdict from collections import defaultdict
from unittest.mock import ANY
import pytest
from crewai.events.event_bus import crewai_event_bus from crewai.events.event_bus import crewai_event_bus
from crewai.events.types.memory_events import (
MemoryQueryCompletedEvent,
MemoryQueryStartedEvent,
MemorySaveCompletedEvent,
MemorySaveStartedEvent,
)
from crewai.memory.long_term.long_term_memory import LongTermMemory from crewai.memory.long_term.long_term_memory import LongTermMemory
from crewai.memory.long_term.long_term_memory_item import LongTermMemoryItem from crewai.memory.long_term.long_term_memory_item import LongTermMemoryItem
from crewai.events.types.memory_events import (
MemorySaveStartedEvent,
MemorySaveCompletedEvent,
MemoryQueryStartedEvent,
MemoryQueryCompletedEvent,
)
@pytest.fixture @pytest.fixture
@@ -98,7 +100,7 @@ def test_long_term_memory_search_events(long_term_memory):
test_query = "test query" test_query = "test query"
long_term_memory.search(test_query, latest_n=5) long_term_memory.search(test_query, limit=5)
assert len(events["MemoryQueryStartedEvent"]) == 1 assert len(events["MemoryQueryStartedEvent"]) == 1
assert len(events["MemoryQueryCompletedEvent"]) == 1 assert len(events["MemoryQueryCompletedEvent"]) == 1
@@ -151,7 +153,7 @@ def test_save_and_search(long_term_memory):
metadata={"task": "test_task", "quality": 0.5}, metadata={"task": "test_task", "quality": 0.5},
) )
long_term_memory.save(memory) long_term_memory.save(memory)
find = long_term_memory.search("test_task", latest_n=5)[0] find = long_term_memory.search("test_task", limit=5)[0]
assert find["score"] == 0.5 assert find["score"] == 0.5
assert find["datetime"] == "test_datetime" assert find["datetime"] == "test_datetime"
assert find["metadata"]["agent"] == "test_agent" assert find["metadata"]["agent"] == "test_agent"