From a414e7f2a7cefd3270584b77e365b1787e760e25 Mon Sep 17 00:00:00 2001 From: Greyson LaLonde Date: Fri, 5 Sep 2025 09:22:21 -0400 Subject: [PATCH] fix: update test files to use 'limit' instead of 'latest_n' and fix metadata in MemorySaveCompletedEvent --- .../memory/long_term/long_term_memory.py | 2 +- tests/memory/test_long_term_memory.py | 22 ++++++++++--------- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/crewai/memory/long_term/long_term_memory.py b/src/crewai/memory/long_term/long_term_memory.py index d4b6f3bc8..5625531e8 100644 --- a/src/crewai/memory/long_term/long_term_memory.py +++ b/src/crewai/memory/long_term/long_term_memory.py @@ -66,7 +66,7 @@ class LongTermMemory(Memory): self, event=MemorySaveCompletedEvent( value=item.task, - metadata=item.metadata, + metadata=metadata, agent_role=item.agent, save_time_ms=(time.time() - start_time) * 1000, source_type="long_term_memory", diff --git a/tests/memory/test_long_term_memory.py b/tests/memory/test_long_term_memory.py index bf4c9285f..88fc4b791 100644 --- a/tests/memory/test_long_term_memory.py +++ b/tests/memory/test_long_term_memory.py @@ -1,15 +1,17 @@ -import pytest -from unittest.mock import ANY from collections import defaultdict +from unittest.mock import ANY + +import pytest + from crewai.events.event_bus import crewai_event_bus +from crewai.events.types.memory_events import ( + MemoryQueryCompletedEvent, + MemoryQueryStartedEvent, + MemorySaveCompletedEvent, + MemorySaveStartedEvent, +) from crewai.memory.long_term.long_term_memory import LongTermMemory from crewai.memory.long_term.long_term_memory_item import LongTermMemoryItem -from crewai.events.types.memory_events import ( - MemorySaveStartedEvent, - MemorySaveCompletedEvent, - MemoryQueryStartedEvent, - MemoryQueryCompletedEvent, -) @pytest.fixture @@ -98,7 +100,7 @@ def test_long_term_memory_search_events(long_term_memory): test_query = "test query" - long_term_memory.search(test_query, latest_n=5) + long_term_memory.search(test_query, limit=5) assert len(events["MemoryQueryStartedEvent"]) == 1 assert len(events["MemoryQueryCompletedEvent"]) == 1 @@ -151,7 +153,7 @@ def test_save_and_search(long_term_memory): metadata={"task": "test_task", "quality": 0.5}, ) long_term_memory.save(memory) - find = long_term_memory.search("test_task", latest_n=5)[0] + find = long_term_memory.search("test_task", limit=5)[0] assert find["score"] == 0.5 assert find["datetime"] == "test_datetime" assert find["metadata"]["agent"] == "test_agent"