chore: improve reset memory feedback

Previously, even when no memories were actually erased, we logged that they had been. From now on, the log will specify which memory has been reset.
This commit is contained in:
Lucas Gomide
2025-05-01 12:51:35 -03:00
parent 7832346de4
commit 7e20495632
3 changed files with 4 additions and 4 deletions

View File

@@ -31,7 +31,7 @@ def reset_memories_command(
raise ValueError("No crew found.") raise ValueError("No crew found.")
if all: if all:
crew.reset_memories(command_type="all") crew.reset_memories(command_type="all")
click.echo("All memories have been reset.") click.echo("Reset memories command has been completed.")
return return
if not any([long, short, entity, kickoff_outputs, knowledge]): if not any([long, short, entity, kickoff_outputs, knowledge]):

View File

@@ -1372,8 +1372,6 @@ class Crew(BaseModel):
else: else:
self._reset_specific_memory(command_type) self._reset_specific_memory(command_type)
self._logger.log("info", f"{command_type} memory has been reset")
except Exception as e: except Exception as e:
error_msg = f"Failed to reset {command_type} memory: {str(e)}" error_msg = f"Failed to reset {command_type} memory: {str(e)}"
self._logger.log("error", error_msg) self._logger.log("error", error_msg)
@@ -1394,6 +1392,7 @@ class Crew(BaseModel):
if system is not None: if system is not None:
try: try:
system.reset() system.reset()
self._logger.log("info", f"{name} memory has been reset")
except Exception as e: except Exception as e:
raise RuntimeError(f"Failed to reset {name} memory") from e raise RuntimeError(f"Failed to reset {name} memory") from e
@@ -1424,5 +1423,6 @@ class Crew(BaseModel):
try: try:
memory_system.reset() memory_system.reset()
self._logger.log("info", f"{name} memory has been reset")
except Exception as e: except Exception as e:
raise RuntimeError(f"Failed to reset {name} memory") from e raise RuntimeError(f"Failed to reset {name} memory") from e

View File

@@ -62,7 +62,7 @@ def test_reset_all_memories(mock_get_crew, runner):
result = runner.invoke(reset_memories, ["-a"]) result = runner.invoke(reset_memories, ["-a"])
mock_crew.reset_memories.assert_called_once_with(command_type="all") mock_crew.reset_memories.assert_called_once_with(command_type="all")
assert result.output == "All memories have been reset.\n" assert result.output == "Reset memories command has been completed.\n"
@mock.patch("crewai.cli.reset_memories_command.get_crew") @mock.patch("crewai.cli.reset_memories_command.get_crew")