From 7e204956325ff3e315dc8783a65d00927ee0aeb9 Mon Sep 17 00:00:00 2001
From: Lucas Gomide <lucaslg200@gmail.com>
Date: Thu, 1 May 2025 12:51:35 -0300
Subject: [PATCH] chore: improve reset memory feedback

Previously, even when no memories were actually erased, we logged that they had been. From now on, the log will specify which memory has been reset.
---
 src/crewai/cli/reset_memories_command.py | 2 +-
 src/crewai/crew.py                       | 4 ++--
 tests/cli/cli_test.py                    | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/crewai/cli/reset_memories_command.py b/src/crewai/cli/reset_memories_command.py
index 4870d6424..9c46c0819 100644
--- a/src/crewai/cli/reset_memories_command.py
+++ b/src/crewai/cli/reset_memories_command.py
@@ -31,7 +31,7 @@ def reset_memories_command(
             raise ValueError("No crew found.")
         if all:
             crew.reset_memories(command_type="all")
-            click.echo("All memories have been reset.")
+            click.echo("Reset memories command has been completed.")
             return
 
         if not any([long, short, entity, kickoff_outputs, knowledge]):
diff --git a/src/crewai/crew.py b/src/crewai/crew.py
index 4d1e61649..e8cb94ae9 100644
--- a/src/crewai/crew.py
+++ b/src/crewai/crew.py
@@ -1372,8 +1372,6 @@ class Crew(BaseModel):
             else:
                 self._reset_specific_memory(command_type)
 
-            self._logger.log("info", f"{command_type} memory has been reset")
-
         except Exception as e:
             error_msg = f"Failed to reset {command_type} memory: {str(e)}"
             self._logger.log("error", error_msg)
@@ -1394,6 +1392,7 @@ class Crew(BaseModel):
             if system is not None:
                 try:
                     system.reset()
+                    self._logger.log("info", f"{name} memory has been reset")
                 except Exception as e:
                     raise RuntimeError(f"Failed to reset {name} memory") from e
 
@@ -1424,5 +1423,6 @@ class Crew(BaseModel):
 
         try:
             memory_system.reset()
+            self._logger.log("info", f"{name} memory has been reset")
         except Exception as e:
             raise RuntimeError(f"Failed to reset {name} memory") from e
diff --git a/tests/cli/cli_test.py b/tests/cli/cli_test.py
index dc0c502b7..0c0b89e7d 100644
--- a/tests/cli/cli_test.py
+++ b/tests/cli/cli_test.py
@@ -62,7 +62,7 @@ def test_reset_all_memories(mock_get_crew, runner):
     result = runner.invoke(reset_memories, ["-a"])
 
     mock_crew.reset_memories.assert_called_once_with(command_type="all")
-    assert result.output == "All memories have been reset.\n"
+    assert result.output == "Reset memories command has been completed.\n"
 
 
 @mock.patch("crewai.cli.reset_memories_command.get_crew")