Fix telemetry singleton pattern to respect dynamic environment variables

- Modified Telemetry.__init__ to prevent re-initialization with _initialized flag
- Updated _safe_telemetry_operation to check _is_telemetry_disabled() dynamically
- Added comprehensive tests for environment variables set after singleton creation
- Fixed singleton contamination in existing tests by adding proper reset
- Resolves issue #2945 where CREWAI_DISABLE_TELEMETRY=true was ignored when set after import

Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-06-03 21:09:09 +00:00
parent 2bd6b72aae
commit 1cfa3f8b2d
3 changed files with 74 additions and 2 deletions

View File

@@ -76,10 +76,14 @@ class Telemetry:
return cls._instance
def __init__(self) -> None:
if hasattr(self, '_initialized'):
return
self.ready: bool = False
self.trace_set: bool = False
if self._is_telemetry_disabled():
self._initialized: bool = True
return
try:
@@ -105,6 +109,8 @@ class Telemetry:
):
raise # Re-raise the exception to not interfere with system signals
self.ready = False
finally:
self._initialized = True
def _is_telemetry_disabled(self) -> bool:
"""Check if telemetry should be disabled based on environment variables."""
@@ -124,7 +130,7 @@ class Telemetry:
self.trace_set = False
def _safe_telemetry_operation(self, operation):
if not self.ready:
if not self.ready or self._is_telemetry_disabled():
return
try:
operation()