andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-08-29 08:57:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

test(azure): use a plain stand-in for Responses API delegate mocks

Browse Source 
MagicMock instances are not reliably stored on Pydantic PrivateAttr via
BaseLLM.__setattr__, which left _responses_delegate as None and failed
last_response_id / reset_chain assertions on CI.

Co-authored-by: Rip&Tear <theCyberTech@users.noreply.github.com>
This commit is contained in:
Cursor Agent
2026-08-13 09:42:00 +00:00
parent c6dbaf1b57
commit 069ea51716
1 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
lib/crewai/tests/llms/azure/test_azure_responses.py
View File

@@ -10,6 +10,21 @@ from unittest.mock import AsyncMock, MagicMock, patch
import pytest
class _FakeOpenAICompletion:
"""Plain stand-in for OpenAICompletion.
MagicMock instances are not reliably stored on Pydantic PrivateAttr
through ``BaseLLM.__setattr__``, which can leave ``_responses_delegate``
as None and make property/method delegation look like a no-op.
"""
def __init__(self) -> None:
self.call = MagicMock(return_value="responses-result")
self.acall = AsyncMock(return_value="async-responses-result")
self.last_response_id = "resp_abc123"
self.last_reasoning_items = [{"type": "reasoning"}]
self.reset_chain = MagicMock()
self.reset_reasoning_chain = MagicMock()
@pytest.fixture
@@ -32,13 +47,7 @@ def mock_openai_completion():
Patches at the source module so that the dynamic import inside
_init_responses_delegate picks up the mock.
"""
instance = MagicMock()
instance.call = MagicMock(return_value="responses-result")
instance.acall = AsyncMock(return_value="async-responses-result")
instance.last_response_id = "resp_abc123"
instance.last_reasoning_items = [{"type": "reasoning"}]
instance.reset_chain = MagicMock()
instance.reset_reasoning_chain = MagicMock()
instance = _FakeOpenAICompletion()
mock_cls = MagicMock(return_value=instance)
with patch(
@@ -245,8 +254,9 @@ class TestAzureResponsesProperties:
"""Test properties and methods delegated to the responses delegate."""
def test_last_response_id(self, mock_openai_completion):
_mock_cls, _ = mock_openai_completion
_mock_cls, instance = mock_openai_completion
comp = _create_azure_responses()
assert comp._responses_delegate is instance
assert comp.last_response_id == "resp_abc123"
def test_last_response_id_none_for_completions(self):
@@ -260,19 +270,22 @@ class TestAzureResponsesProperties:
assert comp.last_response_id is None
def test_last_reasoning_items(self, mock_openai_completion):
_mock_cls, _ = mock_openai_completion
_mock_cls, instance = mock_openai_completion
comp = _create_azure_responses()
assert comp._responses_delegate is instance
assert comp.last_reasoning_items == [{"type": "reasoning"}]
def test_reset_chain(self, mock_openai_completion):
_mock_cls, instance = mock_openai_completion
comp = _create_azure_responses()
assert comp._responses_delegate is instance
comp.reset_chain()
instance.reset_chain.assert_called_once()
def test_reset_reasoning_chain(self, mock_openai_completion):
_mock_cls, instance = mock_openai_completion
comp = _create_azure_responses()
assert comp._responses_delegate is instance
comp.reset_reasoning_chain()
instance.reset_reasoning_chain.assert_called_once()