mirror of
https://github.com/crewAIInc/crewAI.git
synced 2025-12-16 04:18:35 +00:00
ab2274caf0
* fix: ensure persisted state overrides class defaults - Remove early return in Flow.__init__ to allow proper state initialization - Add test_flow_default_override.py to verify state override behavior - Fix issue where default values weren't being overridden by persisted state Fixes the issue where persisted state values weren't properly overriding class defaults when restarting a flow with a previously saved state ID. Co-Authored-By: Joe Moura <joao@crewai.com> * test: improve state restoration verification with has_set_count flag Co-Authored-By: Joe Moura <joao@crewai.com> * test: add has_set_count field to PoemState Co-Authored-By: Joe Moura <joao@crewai.com> * refactoring test * fix: ensure persisted state overrides class defaults - Remove early return in Flow.__init__ to allow proper state initialization - Add test_flow_default_override.py to verify state override behavior - Fix issue where default values weren't being overridden by persisted state Fixes the issue where persisted state values weren't properly overriding class defaults when restarting a flow with a previously saved state ID. Co-Authored-By: Joe Moura <joao@crewai.com> * test: improve state restoration verification with has_set_count flag Co-Authored-By: Joe Moura <joao@crewai.com> * test: add has_set_count field to PoemState Co-Authored-By: Joe Moura <joao@crewai.com> * refactoring test * Fixing flow state * fixing peristed stateful flows * linter * type fix --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Joe Moura <joao@crewai.com>
112 lines
3.7 KiB
Python
112 lines
3.7 KiB
Python
"""Test that persisted state properly overrides default values."""
|
|
|
|
from crewai.flow.flow import Flow, FlowState, listen, start
|
|
from crewai.flow.persistence import persist
|
|
|
|
|
|
class PoemState(FlowState):
|
|
"""Test state model with default values that should be overridden."""
|
|
sentence_count: int = 1000 # Default that should be overridden
|
|
has_set_count: bool = False # Track whether we've set the count
|
|
poem_type: str = ""
|
|
|
|
|
|
def test_default_value_override():
|
|
"""Test that persisted state values override class defaults."""
|
|
|
|
@persist()
|
|
class PoemFlow(Flow[PoemState]):
|
|
initial_state = PoemState
|
|
|
|
@start()
|
|
def set_sentence_count(self):
|
|
if self.state.has_set_count and self.state.sentence_count == 2:
|
|
self.state.sentence_count = 3
|
|
|
|
elif self.state.has_set_count and self.state.sentence_count == 1000:
|
|
self.state.sentence_count = 1000
|
|
|
|
elif self.state.has_set_count and self.state.sentence_count == 5:
|
|
self.state.sentence_count = 5
|
|
|
|
else:
|
|
self.state.sentence_count = 2
|
|
self.state.has_set_count = True
|
|
|
|
# First run - should set sentence_count to 2
|
|
flow1 = PoemFlow()
|
|
flow1.kickoff()
|
|
original_uuid = flow1.state.id
|
|
assert flow1.state.sentence_count == 2
|
|
|
|
# Second run - should load sentence_count=2 instead of default 1000
|
|
flow2 = PoemFlow()
|
|
flow2.kickoff(inputs={"id": original_uuid})
|
|
assert flow2.state.sentence_count == 3 # Should load 2, not default 1000
|
|
|
|
# Fourth run - explicit override should work
|
|
flow3 = PoemFlow()
|
|
flow3.kickoff(inputs={
|
|
"id": original_uuid,
|
|
"has_set_count": True,
|
|
"sentence_count": 5, # Override persisted value
|
|
})
|
|
assert flow3.state.sentence_count == 5 # Should use override value
|
|
|
|
# Third run - should not load sentence_count=2 instead of default 1000
|
|
flow4 = PoemFlow()
|
|
flow4.kickoff(inputs={"has_set_count": True})
|
|
assert flow4.state.sentence_count == 1000 # Should load 1000, not 2
|
|
|
|
|
|
def test_multi_step_default_override():
|
|
"""Test default value override with multiple start methods."""
|
|
|
|
@persist()
|
|
class MultiStepPoemFlow(Flow[PoemState]):
|
|
initial_state = PoemState
|
|
|
|
@start()
|
|
def set_sentence_count(self):
|
|
print("Setting sentence count")
|
|
if not self.state.has_set_count:
|
|
self.state.sentence_count = 3
|
|
self.state.has_set_count = True
|
|
|
|
@listen(set_sentence_count)
|
|
def set_poem_type(self):
|
|
print("Setting poem type")
|
|
if self.state.sentence_count == 3:
|
|
self.state.poem_type = "haiku"
|
|
elif self.state.sentence_count == 5:
|
|
self.state.poem_type = "limerick"
|
|
else:
|
|
self.state.poem_type = "free_verse"
|
|
|
|
@listen(set_poem_type)
|
|
def finished(self):
|
|
print("finished")
|
|
|
|
# First run - should set both sentence count and poem type
|
|
flow1 = MultiStepPoemFlow()
|
|
flow1.kickoff()
|
|
original_uuid = flow1.state.id
|
|
assert flow1.state.sentence_count == 3
|
|
assert flow1.state.poem_type == "haiku"
|
|
|
|
# Second run - should load persisted state and update poem type
|
|
flow2 = MultiStepPoemFlow()
|
|
flow2.kickoff(inputs={
|
|
"id": original_uuid,
|
|
"sentence_count": 5
|
|
})
|
|
assert flow2.state.sentence_count == 5
|
|
assert flow2.state.poem_type == "limerick"
|
|
|
|
# Third run - new flow without persisted state should use defaults
|
|
flow3 = MultiStepPoemFlow()
|
|
flow3.kickoff(inputs={
|
|
"id": original_uuid
|
|
})
|
|
assert flow3.state.sentence_count == 5
|
|
assert flow3.state.poem_type == "limerick" |