Files
crewAI/lib/crewai/tests/telemetry/test_session_trace_export.py
T
João MouraandClaude Opus 5.5 3da49f872b
Vulnerability Scan / Detect changes (push) Canceled after 0s
Vulnerability Scan / pip-audit (push) Canceled after 0s
CodeQL Advanced / Analyze (actions) (push) Canceled after 0s
CodeQL Advanced / Analyze (python) (push) Canceled after 0s
Check Documentation Broken Links / Check broken links (push) Canceled after 0s
feat(cli): crewai eval runs the crew itself, so a coding agent gets a verdict from one command (#8270)
* feat(cli): crewai eval runs the crew itself, so a coding agent gets a verdict from one command

Most `crewai eval` attempts stopped before an evaluation began because the
project had no traced run. Telemetry since Sept 25: 117 projects stopped as
"untraced", 97 of them with no terminal (coding agents), and 67 of those never
got further. With no terminal the command could only print steps, and without
a login those steps could not work: an unattended anonymous run never uploads
its trace.

- With no traced run, or when the project's files changed since the last one,
  `crewai eval` runs the crew and evaluates that run. No question, with or
  without a terminal: running the command is the request to have the run
  graded, and the grade is read off its trace. Tracing is on for that run only;
  nothing is written to the project's `.env`.
- crewAI's tracing approves the upload of that run through the existing
  handshake: a token in CREWAI_EVAL_AWAITING_RUN that counts only while its file
  exists in the user's crewAI data folder, so a `.env` cannot claim it. Shared
  as `crewai_core.eval_handshake`; the run app keeps its own copy because it
  also runs against a project's older crewai-core, and a test pins the two.
- The run app's Evaluate on an untraced run closes the app and runs the crew
  again, traced, through `crewai eval`'s own path, instead of a notice.
- Counts: `eval_ran_crew:{no_traced_run,project_changed,run_again}`,
  `eval_finished:{passed,failed,inconclusive,unknown}`, and
  `eval_stopped:untraced_after_run` replacing the catch-all `untraced`
  (`declined` is gone with the question). The CLI tests no longer send usage
  counts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): a project that turned tracing off is asked before crewai eval runs it

`CREWAI_TRACING_ENABLED=false` is the project's no, and nothing overrules it,
not even a run `crewai eval` started.

- `crewai eval` at a terminal asks to turn tracing on before running the crew.
  A yes writes it to the project's `.env`; a no runs nothing (exit 0,
  `eval_stopped:declined`). With no terminal it stops and says how to turn it
  on (`eval_stopped:tracing_off`), which a coding agent can do itself.
- The run app's Evaluate on an untraced run asks the same question in a modal
  (TurnTracingOnScreen) before running the crew again. Otherwise it still runs
  it again with no question.
- crewAI's tracing respects an explicit off again: `should_enable_tracing`
  checks it before a run `crewai eval` started, and `execution._tracing_disabled`
  is back to what main has.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(tracing): the telemetry opt-out no longer turns tracing off; an evaluated run says where its trace goes

- `OTEL_SDK_DISABLED` is the telemetry opt-out, a separate setting from
  tracing, which has its own (`CREWAI_TRACING_ENABLED`, `tracing=`).
  `execution._tracing_disabled` no longer reads it. The trace session's own
  TracerProvider records even when the OpenTelemetry SDK is switched off
  (`session._trace_provider`), because the SDK otherwise hands out tracers that
  record nothing. A provider a host passes in is left as it is. Tests that used
  `OTEL_SDK_DISABLED` as a way to stop a trace now cover the two real switches;
  new tests show a traced run, anonymous or logged in, recorded and uploaded
  with it set.
- A run app opened to run the crew for an evaluation (`crewai eval`, or
  Evaluate on a run that was not traced) shows one plain note on mount: "This
  run will be evaluated: its trace is sent to CrewAI AMP, which grades it."

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): say where the trace goes only when the yes is inferred from crewai eval

The note, in the run app ("This run will be evaluated: its trace is sent to
CrewAI AMP, which grades it.") and in `crewai eval`'s line, is for the case
where nobody turned tracing on: not `tracing=True` on the crew or flow, not
`CREWAI_TRACING_ENABLED=true`, not a consent a person gave once
(`crewai_core.user_data.is_tracing_enabled`), and not the yes they just gave to
turn it on. A project or a person who opted in is told nothing new.

The run `crewai eval` starts no longer sets `CREWAI_TRACING_ENABLED=true`:
the handshake alone turns tracing on for it, so the setting a run reads is the
project's own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): turn tracing on once with a note, pin the eval handshake, and keep the saved login to trusted AMPs

From the review on #8270, and João's call on the note:

- The first `crewai eval` that infers the yes turns tracing on for the
  project (`CREWAI_TRACING_ENABLED=true` in `.env` and for the run) and says
  so once, in the command and in the run app: "Tracing is now on for this
  project…". Afterwards the project traces and nothing more is said. A run
  whose crew or flow sets `tracing=False` is never told its trace is sent.
- The handshake's folder is found from the account's home in the account
  database, never `HOME` or `XDG_DATA_HOME`, so a project's `.env` cannot plant
  a token file that approves an upload. Both copies (crewai-core, the run app)
  are pinned to the same folder and file by a test.
- The token file carries the AMP origins `crewai eval` trusted before the
  project's `.env` was loaded. A run it started sends the saved login only
  there over HTTPS or loopback; an AMP the `.env` chose gets an anonymous
  grant.
- Evaluate on an untraced run carries that run's definition, inputs (prompted
  ones included) and trained-agents file into the re-run. The conversational
  flow consumes the request too, and a crew or flow that sets `tracing=False`
  says why it cannot be evaluated instead of paying for another run.
- "The project changed" also sees deleted files: each evaluation keeps the
  list of the project's files (`.crewai/eval_project_state.json`) and the next
  one compares against it. That list is taken after this command's own
  project-id write, so the write is no change.
- The OpenTelemetry override probes its provider and warns if an SDK version
  still records nothing, instead of failing silently.
- The stale `sdk` case of `test_disabled_execution_does_not_collect_or_request_grants`
  is gone; the handshake tests are typed (type-checker CI).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): keep the saved login off a project's AMP on every path crewai eval runs

From the second review round on #8270:

- Evaluate's re-run runs in a process that already loaded the project's
  `.env`, so it passes this machine's AMPs (`_machine_amp_origins`) as the
  trusted set instead of reading `CREWAI_PLUS_URL` there (`eval_crew(
  trusted_amp_origins=…)`).
- A project's `.env` can neither set nor replace `crewai eval`'s token:
  `run_crew.load_project_env` keeps the token the process was started with and
  drops one a `.env` sets. The JSON-crew, declarative-flow and eval paths all
  load `.env` through it.
- `crewai eval` turns tracing on only when every credential this machine holds
  (the saved login, or a PAT or integration token from before the `.env`) may
  go to the AMP the run would trace to. A project's crewai older than the
  handshake would otherwise send it to an AMP the `.env` names. A newer crewai
  still traces the run anonymously through the handshake.
- A conversational flow named by its definition is re-run by that definition.
- Code quality: no redundant assignment in `_awaiting_dir`, no unused names in
  the credential test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): crewai eval does not run a crew whose trace would carry the login to an untrusted AMP

When tracing is on for the run (the project's .env, or a consent given once)
and a credential of this machine would go to an AMP the command does not
trust, the crew is not run. A project's crewai older than the handshake would
send the login there, and the CLI cannot tell which crewai the project runs.
The command stops (`eval_stopped:untrusted_amp`) and says how to go on: log
in to that AMP, or remove CREWAI_PLUS_URL from the project's .env. A project
that turned tracing off is not asked to turn it on toward such an AMP. With
no credential on the machine, there is nothing to protect and the run goes on.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Ask at a terminal before tracing is first turned on

A person running `crewai eval` at a terminal, in a project that never
turned tracing on, is now asked on crewAI's trace consent screen before
the crew runs; a yes turns tracing on for the project, a no (or the
screen timing out) runs nothing and is counted as `declined`. The run
app's Evaluate on an untraced run asks on its own consent screen the same
way. With nobody at a terminal (a coding agent, a script) the yes is
still inferred from the command, tracing is turned on and said once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Keep main's Iterator import, which the rebase over #8187 dropped

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* A run-app test no longer leaves .crewai/last_eval.json in the repo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Two run-app tests from #7963 no longer leave .crewai/last_eval.json in the repo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Never run the crew toward an AMP the login must not reach; check before asking

`crewai eval` now refuses to run the crew whenever a credential of this
machine would go with the trace to an AMP it does not trust, whatever the
tracing setting: `tracing=True` in code is invisible to the CLI, and a
project's crewai older than the handshake sends the credential wherever
the run traces. The run app's Evaluate makes the same check before it
asks anything, so a yes can never write CREWAI_TRACING_ENABLED=true to
`.env` for a re-run that is then refused.

Which credentials are this machine's is read from the environment as it
was before any project `.env` was loaded (`run_crew.environment_before_project`),
so on Evaluate's re-run a CREWAI_USER_PAT the project's own `.env` brought
is the project's, as on any run of it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Run the crew only toward an AMP this machine trusts, login or not

Whether this machine holds a login right now no longer decides: with no
login yet, `crewai eval` still wrote CREWAI_TRACING_ENABLED=true toward a
CREWAI_PLUS_URL the project's `.env` chose, and the first run after
`crewai login` would have carried the login there. Toward an AMP this
command does not trust, the crew is now never run, nobody is asked and
nothing is written, in `crewai eval` and the run app's Evaluate alike.
That also drops the credential bookkeeping from b26ccaf44, which the
rule no longer needs.

The telemetry docs no longer say OTEL_SDK_DISABLED turns off everything:
it disables OpenTelemetry instrumentation and CrewAI's telemetry, not AMP
tracing, which has its own switches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Pin that a project's own token never blocks Evaluate's re-run

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-19 04:11:15 -03:00

989 lines
37 KiB
Python

"""Execution grants and consent use real OTLP requests to local collectors."""
import asyncio
from concurrent.futures import ThreadPoolExecutor
from contextvars import copy_context
from dataclasses import replace
from datetime import datetime, timedelta, timezone
from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
import json
from threading import Barrier, Lock, Thread
from types import SimpleNamespace
from unittest.mock import Mock, patch
from uuid import uuid4
from crewai.auth.token import AuthError
from crewai.telemetry.tracing import ephemeral
from crewai.telemetry.tracing.ephemeral import (
EphemeralSpanBuffer,
ephemeral_tracing,
trace_consent,
)
from crewai.telemetry.tracing.grants import (
GrantSpanExporter,
TraceGrantClient,
TraceGrantError,
tracing_credential,
)
from crewai.telemetry.tracing.session import TraceSession
from opentelemetry import trace
from opentelemetry.exporter.otlp.proto.common.trace_encoder import encode_spans
from opentelemetry.proto.collector.trace.v1.trace_service_pb2 import (
ExportTraceServiceRequest,
)
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import SimpleSpanProcessor, SpanExportResult
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter
import pytest
pytestmark = pytest.mark.block_network(allowed_hosts=[r"^127\.0\.0\.1$"])
@pytest.fixture(autouse=True)
def tracing_environment(monkeypatch):
# Keep viewer URLs on one line when asserting their literal output.
monkeypatch.setenv("COLUMNS", "240")
monkeypatch.setenv("OTEL_SDK_DISABLED", "false")
monkeypatch.setenv("CREWAI_DISABLE_TELEMETRY", "true")
for name in (
"CREWAI_USER_PAT",
"CREWAI_ENTERPRISE_ACTION_AUTH_TOKEN",
"CREWAI_EPHEMERAL_TRACE_MAX_SPANS",
"CREWAI_EPHEMERAL_TRACE_MAX_BYTES",
):
monkeypatch.delenv(name, raising=False)
monkeypatch.setattr("crewai.telemetry.tracing.grants.get_auth_token", lambda: None)
@pytest.fixture
def collector(monkeypatch):
state = SimpleNamespace(
grants=[], batches=[], grant_status=200, export_status=200, grant_override={}
)
lock = Lock()
class Collector(BaseHTTPRequestHandler):
def do_POST(self):
body = self.rfile.read(int(self.headers["Content-Length"]))
authorization = self.headers.get("Authorization")
if self.path.endswith("/grants"):
payload = json.loads(body)
with lock:
state.grants.append((authorization, dict(self.headers), payload))
number = len(state.grants)
status = (
401 if authorization == "Bearer invalid" else state.grant_status
)
response = {
"token": f"grant-{number}",
"collector_url": state.url + "/v1/traces",
"execution_uuid": payload["execution_uuid"],
"tier": "authenticated" if authorization else "ephemeral",
"expires_at": (
datetime.now(timezone.utc) + timedelta(minutes=15)
).isoformat(),
**state.grant_override,
}
if not payload.get("include_trace_url"):
response.pop("trace_url", None)
encoded = json.dumps(response).encode()
else:
state.batches.append(
(authorization, ExportTraceServiceRequest.FromString(body))
)
status, encoded = state.export_status, b""
self.send_response(status)
self.send_header("Content-Length", str(len(encoded)))
self.end_headers()
self.wfile.write(encoded)
def log_message(self, *_args):
pass
server = ThreadingHTTPServer(("127.0.0.1", 0), Collector)
state.url = f"http://127.0.0.1:{server.server_port}"
worker = Thread(
target=lambda: server.serve_forever(poll_interval=0.01), daemon=True
)
worker.start()
monkeypatch.setenv("CREWAI_PLUS_URL", state.url)
try:
yield state
finally:
server.shutdown()
server.server_close()
worker.join(timeout=5)
def spans(batch):
return [
span
for resource in batch.resource_spans
for scope in resource.scope_spans
for span in scope.spans
]
def record(session, name="execute flow"):
session.get_tracer().start_span(
name, attributes={"gen_ai.input.messages": "local private input"}
).end()
@pytest.fixture
def recorded_runs(monkeypatch, tmp_path):
"""Recording on, into tmp_path (the suite's CREWAI_TESTING turns it off)."""
from crewai.telemetry.tracing import last_run
monkeypatch.setattr(last_run, "project_dir", lambda: tmp_path)
monkeypatch.setattr(last_run, "recording_enabled", lambda: True)
return tmp_path
def _last_run(directory):
from crewai.telemetry.tracing import last_run
return last_run.read_last_run(directory)
@pytest.mark.parametrize(
("authenticated", "approved", "status", "suppression", "recorded"),
[
(True, True, 200, None, True),
(False, True, 200, None, True),
(False, False, 200, None, False),
(True, True, 401, None, False),
(False, True, 401, None, False),
(True, True, 200, "messages", True),
(False, True, 200, "messages", True),
(True, True, 200, "tui", True),
(False, True, 200, "tui", True),
],
)
def test_the_viewer_link_is_shown_the_id_is_not_and_a_successful_export_is_recorded(
collector,
recorded_runs,
monkeypatch,
capsys,
authenticated,
approved,
status,
suppression,
recorded,
):
from crewai.events.listeners.tracing.utils import (
set_suppress_tracing_messages,
set_tui_mode,
)
from crewai.execution import begin_execution, end_execution, get_execution_uuid
from crewai.telemetry.tracing.context import get_trace_session
url = collector.url + "/crewai_plus/otel_traces/run?access_code=secret&x=[value]"
collector.grant_override = {"trace_url": url}
collector.export_status = status
if authenticated:
monkeypatch.setenv("CREWAI_USER_PAT", "synthetic-pat")
seen = {}
def run():
if suppression == "messages":
set_suppress_tracing_messages(True)
elif suppression == "tui":
set_tui_mode(True)
with trace_consent(lambda: approved):
token = begin_execution(tracing=True)
try:
seen["uuid"] = get_execution_uuid()
session = get_trace_session()
record(session)
nested = begin_execution(tracing=True)
end_execution(nested)
finally:
end_execution(token)
copy_context().run(run)
output = capsys.readouterr().out
# The id is internal — `crewai eval` reads it from the record — so it is never
# printed, nor is the old "Traces exported" panel around it.
assert seen["uuid"] not in output
assert "Execution trace ID:" not in output and "Traces exported" not in output
# The viewer link IS shown, once, for whoever wants to look at the run: only for
# a run that was exported whole, and not where tracing messages are suppressed.
shown = recorded and suppression is None
assert ("View traces:" in output) == shown
assert ("Execution Traces" in output and "╭" in output) == shown
assert ("Ephemeral Execution Traces" in output) == (shown and not authenticated)
assert (url in output.replace("\n", "")) == shown
assert len(collector.batches) == int(authenticated or approved)
# A run whose spans reached Wharf is recorded for `crewai eval`, silently,
# in the TUI and under message suppression too; a failed export is not.
written = _last_run(recorded_runs)
if recorded:
assert written is not None
assert written["execution_id"] == seen["uuid"]
assert written["tier"] == ("authenticated" if authenticated else "ephemeral")
assert written["started_at"] and written["finished_at"] and written["recorded_at"]
assert written["amp_base_url"] == collector.url
# The link is recorded even where it is never printed: under a TUI the
# console line is silenced, and the run app's View Traces button has
# nowhere else to read it from.
assert written["trace_url"] == url
else:
assert written is None
@pytest.mark.parametrize("first_status", [200, 401])
def test_a_deferred_run_is_recorded_once_at_finalization_and_a_failed_export_never(
collector, recorded_runs, monkeypatch, capsys, first_status
):
from crewai.execution import begin_execution, end_execution
from crewai.telemetry.tracing.context import get_trace_session
monkeypatch.setenv("CREWAI_USER_PAT", "synthetic-pat")
collector.export_status = first_status
token = begin_execution(tracing=True)
try:
session = get_trace_session()
record(session)
session.flush()
finally:
lifetime = end_execution(token, defer=True)
assert _last_run(recorded_runs) is None # not finished yet
collector.export_status = 200
token = begin_execution(tracing=True, trace_session=lifetime)
try:
record(get_trace_session())
finally:
end_execution(token)
lifetime.finish()
assert capsys.readouterr().out == "" # this grant carries no viewer URL, so there is nothing to show
# A run one of whose exports failed is never recorded: the grader could not read it whole.
assert (_last_run(recorded_runs) is not None) == (first_status == 200)
@pytest.mark.parametrize("credential", [None, "pat"])
def test_a_refreshed_grant_still_records_the_run_once(
collector, recorded_runs, monkeypatch, capsys, credential
):
from crewai.telemetry.tracing import last_run
writes = []
real_record = last_run.record_last_run
monkeypatch.setattr(
last_run,
"record_last_run",
lambda **fields: (writes.append(fields["execution_id"]), real_record(**fields))[1],
)
collector.grant_override = {"trace_url": collector.url + "/crewai_plus/otel_traces/original"}
client = TraceGrantClient(credential)
grant = replace(
client.create(str(uuid4())),
expires_at=datetime.now(timezone.utc) + timedelta(seconds=1),
)
collector.grant_override = {}
exporter = GrantSpanExporter(client, grant)
session = TraceSession(grant.execution_uuid, [exporter])
try:
record(session)
finally:
session.shutdown()
exporter.record_export()
exporter.record_export()
assert writes == [grant.execution_uuid] # written once, however often the exporter is told the run ended
shown = capsys.readouterr().out
assert shown.count("View traces:") == 1 # and the link with it, once
assert grant.execution_uuid not in shown
written = _last_run(recorded_runs)
assert written is not None and written["execution_id"] == grant.execution_uuid
assert written["tier"] == ("authenticated" if credential else "ephemeral")
assert len(collector.grants) == 2
assert all(
payload["include_trace_url"] is True for _, _, payload in collector.grants
)
def test_the_recorded_window_is_the_first_start_and_last_end_across_batches(
collector, recorded_runs
):
"""Batches reach the exporter in any order; the record spans them all."""
from crewai.telemetry.tracing import last_run
memory = InMemorySpanExporter()
provider = TracerProvider()
provider.add_span_processor(SimpleSpanProcessor(memory))
tracer = provider.get_tracer("window")
second = 1_000_000_000
base = 1_700_000_000 * second
for name, start, end in (("late", 10, 12), ("early", 0, 5), ("middle", 3, 9)):
tracer.start_span(name, start_time=base + start * second).end(end_time=base + end * second)
provider.shutdown()
by_name = {span.name: span for span in memory.get_finished_spans()}
client = TraceGrantClient(None)
exporter = GrantSpanExporter(client, client.create(str(uuid4())))
try:
assert exporter.export([by_name["late"]]) == SpanExportResult.SUCCESS
assert exporter.export([by_name["early"], by_name["middle"]]) == SpanExportResult.SUCCESS
finally:
exporter.shutdown()
exporter.record_export()
written = _last_run(recorded_runs)
assert written is not None
assert written["started_at"] == last_run._iso(base)
assert written["finished_at"] == last_run._iso(base + 12 * second)
def test_a_truncated_ephemeral_trace_is_uploaded_but_not_recorded(
collector, recorded_runs, monkeypatch
):
"""The buffer dropped spans at its cap: the grader could not read the run whole."""
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_SPANS", "1")
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
with trace_consent(lambda: True), ephemeral_tracing(str(uuid4())) as session:
record(session, "first")
record(session, "second")
assert buffer._dropped == 1
assert len(collector.batches) == 1 # what survived was still shared
assert _last_run(recorded_runs) is None
@pytest.mark.parametrize("authenticated", [True, False])
def test_an_export_without_a_viewer_url_is_recorded_all_the_same(
collector, recorded_runs, monkeypatch, capsys, authenticated
):
from crewai.execution import begin_execution, end_execution, get_execution_uuid
from crewai.telemetry.tracing.context import get_trace_session
if authenticated:
monkeypatch.setenv("CREWAI_USER_PAT", "synthetic-pat")
with trace_consent(lambda: True):
token = begin_execution(tracing=True)
try:
execution_uuid = get_execution_uuid()
record(get_trace_session())
finally:
end_execution(token)
# AMP granted no viewer URL, so there is no link to show — and never the id.
assert capsys.readouterr().out == ""
written = _last_run(recorded_runs)
assert written is not None and written["execution_id"] == execution_uuid
assert len(collector.batches) == 1
def test_credential_precedence_and_missing_login(monkeypatch):
monkeypatch.setenv("CREWAI_USER_PAT", "pat")
monkeypatch.setenv("CREWAI_ENTERPRISE_ACTION_AUTH_TOKEN", "integration")
login = Mock(return_value="login")
monkeypatch.setattr("crewai.telemetry.tracing.grants.get_auth_token", login)
assert tracing_credential() == "pat"
monkeypatch.delenv("CREWAI_USER_PAT")
assert tracing_credential() == "integration"
login.assert_not_called()
monkeypatch.delenv("CREWAI_ENTERPRISE_ACTION_AUTH_TOKEN")
assert tracing_credential() == "login"
login.side_effect = AuthError("No saved login")
assert tracing_credential() is None
@pytest.mark.parametrize("credential", ["pat", "integration", "login"])
def test_authenticated_spans_go_directly_to_collector(collector, credential):
execution_uuid = str(uuid4())
client = TraceGrantClient(credential)
grant = client.create(execution_uuid)
session = TraceSession(execution_uuid, [GrantSpanExporter(client, grant)])
try:
with session.activate():
record(session)
finally:
session.shutdown()
assert len(collector.grants) == 1
auth, _, payload = collector.grants[0]
assert auth == f"Bearer {credential}"
assert payload == {"execution_uuid": execution_uuid, "include_trace_url": True}
assert len(collector.batches) == 1
bearer, batch = collector.batches[0]
assert bearer == "Bearer grant-1"
exported = spans(batch)
assert len(exported) == 1 and exported[0].name == "execute flow"
attributes = {a.key: a.value.string_value for a in exported[0].attributes}
assert attributes["crewai.execution_uuid"] == execution_uuid
assert attributes["gen_ai.input.messages"] == "local private input"
def test_invalid_credentials_do_not_request_anonymous_grants(collector):
with pytest.raises(TraceGrantError) as error:
TraceGrantClient("invalid").create(str(uuid4()))
assert error.value.status_code == 401
assert len(collector.grants) == 1 and not collector.batches
assert collector.grants[0][0] == "Bearer invalid"
@pytest.mark.parametrize("credential", [None, "pat"])
def test_grant_preserves_optional_viewer_url_without_exposing_it_in_repr(
collector, credential
):
client = TraceGrantClient(credential)
assert client.create(str(uuid4())).trace_url is None
url = collector.url + "/crewai_plus/ephemeral_trace_batches/run?access_code=private"
collector.grant_override = {"trace_url": url}
grant = client.create(str(uuid4()))
assert grant.trace_url == url
assert url not in repr(grant) and "private" not in repr(grant)
assert grant.token not in repr(grant)
@pytest.mark.parametrize(
"value",
[
None,
"",
42,
{},
"/relative",
"javascript:alert(1)",
"https://unrelated.example/trace",
"http://[invalid/trace",
"http://user:secret@127.0.0.1/trace",
"\n",
"\x1b[2J",
],
)
def test_unusable_optional_viewer_url_does_not_break_grant(collector, value):
collector.grant_override = {"trace_url": value}
assert TraceGrantClient("pat").create(str(uuid4())).trace_url is None
@pytest.mark.parametrize(
"override",
[
{"tier": "ephemeral"},
{"execution_uuid": str(uuid4())},
{"token": 42},
{"token": " "},
{"collector_url": "file:///tmp/traces"},
{"collector_url": "https://user:password@collector.example/v1/traces"},
{"expires_at": "2020-01-01T00:00:00+00:00"},
{"expires_at": "2999-01-01T00:00:00"},
],
)
def test_invalid_grant_is_rejected_without_trace_upload(collector, override):
collector.grant_override = override
with pytest.raises(TraceGrantError):
TraceGrantClient("credential").create(str(uuid4()))
assert not collector.batches
@pytest.mark.parametrize(
("url", "allowed"),
[
("https://collector.example/v1/traces", True),
("http://localhost:4318/v1/traces", True),
("http://dev.localhost:4318/v1/traces", True),
("http://127.0.0.1:4318/v1/traces", True),
("http://[::1]:4318/v1/traces", True),
("http://collector.example/v1/traces", False),
("http://localhost.example/v1/traces", False),
("http://192.168.1.1:4318/v1/traces", False),
],
)
def test_grant_requires_https_except_local_development(collector, url, allowed):
collector.grant_override = {"collector_url": url}
client = TraceGrantClient("credential")
if allowed:
assert client.create(str(uuid4())).collector_url == url
else:
with pytest.raises(TraceGrantError):
client.create(str(uuid4()))
assert not collector.batches
def test_anonymous_grant_omits_saved_organization_and_rejects_wrong_tier(collector):
client = TraceGrantClient(None)
assert "X-Crewai-Organization-Id" not in client._api.headers
client.create(str(uuid4()))
auth, headers, payload = collector.grants[0]
assert auth is None and "X-Crewai-Organization-Id" not in headers
assert set(payload) == {"execution_uuid", "include_trace_url"}
assert payload["include_trace_url"] is True
collector.grant_override = {"tier": "authenticated"}
with pytest.raises(TraceGrantError):
client.create(str(uuid4()))
def test_concurrent_sessions_keep_execution_grants_and_application_spans_separate(
collector, monkeypatch
):
application_exporter = InMemorySpanExporter()
application_provider = TracerProvider()
application_provider.add_span_processor(SimpleSpanProcessor(application_exporter))
monkeypatch.setattr(trace, "get_tracer_provider", lambda: application_provider)
barrier = Barrier(2)
def run(number):
execution_uuid = str(uuid4())
client = TraceGrantClient(f"pat-{number}")
grant = client.create(execution_uuid)
session = TraceSession(execution_uuid, [GrantSpanExporter(client, grant)])
try:
with session.activate():
barrier.wait(timeout=5)
record(session, f"execution {number}")
trace.get_tracer("application").start_span("unrelated").end()
finally:
session.shutdown()
return grant.token, execution_uuid, f"execution {number}"
try:
with ThreadPoolExecutor(max_workers=2) as pool:
executions = list(pool.map(run, range(2)))
assert len(collector.grants) == 2 and len(collector.batches) == 2
for grant, execution_uuid, name in executions:
batch = next(
batch for auth, batch in collector.batches if auth == f"Bearer {grant}"
)
exported = spans(batch)
assert [span.name for span in exported] == [name]
attributes = {a.key: a.value.string_value for a in exported[0].attributes}
assert attributes["crewai.execution_uuid"] == execution_uuid
assert len(application_exporter.get_finished_spans()) == 2
finally:
application_provider.shutdown()
def test_expired_grant_is_renewed_for_same_execution(collector):
execution_uuid = str(uuid4())
client = TraceGrantClient("pat")
grant = replace(
client.create(execution_uuid),
expires_at=datetime.now(timezone.utc) + timedelta(seconds=1),
)
session = TraceSession(execution_uuid, [GrantSpanExporter(client, grant)])
record(session)
session.shutdown()
assert [payload for _, _, payload in collector.grants] == [
{"execution_uuid": execution_uuid, "include_trace_url": True},
{"execution_uuid": execution_uuid, "include_trace_url": True},
]
assert collector.batches[0][0] == "Bearer grant-2"
@pytest.mark.parametrize("approved", [False, True])
def test_consent_waits_for_finished_spans_and_gates_every_request(
collector, monkeypatch, approved
):
finished = False
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
def consent():
assert finished
assert not collector.grants and not collector.batches
return approved
with trace_consent(consent), ephemeral_tracing(str(uuid4())) as session:
session.context.active_spans["pending"] = session.get_tracer().start_span(
"unfinished event"
)
record(session)
assert not collector.grants and not collector.batches
finished = True
assert buffer._closed and not buffer._spans and buffer._size == 0
assert len(collector.grants) == int(approved)
assert len(collector.batches) == int(approved)
if approved:
assert collector.grants[0][0] is None
assert collector.batches[0][0] == "Bearer grant-1"
assert {span.name for span in spans(collector.batches[0][1])} == {
"unfinished event",
"execute flow",
}
@pytest.mark.parametrize(
"failure", [RuntimeError, KeyboardInterrupt, asyncio.CancelledError]
)
def test_execution_failure_clears_buffer_without_consent_or_requests(
collector, monkeypatch, failure
):
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
consent = Mock(return_value=True)
def fail_execution():
with trace_consent(consent), ephemeral_tracing(str(uuid4())) as session:
record(session)
raise failure("execution failed")
with pytest.raises(failure, match="execution failed"):
fail_execution()
consent.assert_not_called()
assert buffer._closed and not buffer._spans
assert not collector.grants and not collector.batches
@pytest.mark.parametrize("failure", [TimeoutError, asyncio.CancelledError])
def test_consent_timeout_or_cancellation_discards_without_requests(
collector, monkeypatch, failure
):
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
consent = Mock(side_effect=failure("cancelled"))
try:
with trace_consent(consent), ephemeral_tracing(str(uuid4())) as session:
record(session)
except asyncio.CancelledError:
assert failure is asyncio.CancelledError
consent.assert_called_once_with()
assert buffer._closed and not buffer._spans
assert not collector.grants and not collector.batches
def test_tui_consent_callback_survives_context_exit_and_suppressed_terminal_prompt(
collector, monkeypatch
):
consent = Mock(return_value=True)
with trace_consent(consent):
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
with patch.object(ephemeral, "prompt_user_for_trace_viewing") as terminal_prompt:
with ephemeral_tracing(str(uuid4())) as session:
record(session)
consent.assert_called_once_with()
terminal_prompt.assert_not_called()
assert len(collector.grants) == 1 and len(collector.batches) == 1
def test_nested_consent_callbacks_restore_previous_context(collector):
outer, inner = Mock(return_value=False), Mock(return_value=False)
with trace_consent(outer):
with trace_consent(inner), ephemeral_tracing(str(uuid4())) as session:
record(session)
with ephemeral_tracing(str(uuid4())) as session:
record(session)
outer.assert_called_once_with()
inner.assert_called_once_with()
assert not collector.grants and not collector.batches
@pytest.mark.parametrize("approved", [False, True])
def test_terminal_consent_explicitly_requests_sharing(collector, approved):
with patch.object(
ephemeral, "prompt_user_for_trace_viewing", return_value=approved
) as prompt:
with ephemeral_tracing(str(uuid4())) as session:
record(session)
prompt.assert_called_once_with(sharing=True)
assert len(collector.grants) == int(approved)
@pytest.mark.parametrize("approved", [False, True])
def test_first_time_preference_contains_only_completion_and_consent(
collector, monkeypatch, approved
):
save = Mock()
monkeypatch.setattr(ephemeral, "update_user_data", save)
with (
trace_consent(lambda: approved),
ephemeral_tracing(str(uuid4()), first_time=True) as session,
):
record(session)
save.assert_not_called()
save.assert_called_once_with(
{"first_execution_done": True, "trace_consent": approved}
)
assert len(collector.grants) == int(approved)
@pytest.mark.parametrize("approved", [False, True])
def test_first_time_execution_uses_local_session_even_with_saved_credentials(
collector, monkeypatch, approved
):
from crewai.execution import begin_execution, end_execution, get_execution_uuid
from crewai.telemetry.tracing.context import get_trace_session
monkeypatch.delenv("CREWAI_TRACING_ENABLED", raising=False)
monkeypatch.setattr(
"crewai.events.listeners.tracing.utils.should_enable_tracing", lambda **_: False
)
monkeypatch.setattr(
"crewai.events.listeners.tracing.utils.should_auto_collect_first_time_traces",
lambda: True,
)
credential = Mock(return_value=("login", "saved-login"))
monkeypatch.setattr(
"crewai.telemetry.tracing.grants.resolve_tracing_credential", credential
)
save = Mock()
monkeypatch.setattr(ephemeral, "update_user_data", save)
finished = False
def consent():
assert finished and not collector.grants and not collector.batches
return approved
with trace_consent(consent):
token = begin_execution()
try:
session = get_trace_session()
assert session is not None
nested = begin_execution(tracing=True)
assert get_trace_session() is session
record(session)
end_execution(nested)
assert get_trace_session() is session and not session._closed
assert not collector.grants and not collector.batches
finished = True
finally:
end_execution(token)
credential.assert_not_called()
assert get_trace_session() is None and get_execution_uuid() is None
assert session._closed
save.assert_called_once_with(
{"first_execution_done": True, "trace_consent": approved}
)
assert len(collector.grants) == int(approved)
# `OTEL_SDK_DISABLED` is not among them: it is the telemetry opt-out
# (test_deferred_trace_transitions.py::test_the_telemetry_opt_out_does_not_turn_tracing_off).
@pytest.mark.parametrize("disabled_by", ["override", "environment"])
def test_disabled_execution_does_not_collect_or_request_grants(
collector, monkeypatch, disabled_by
):
from crewai.execution import begin_execution, end_execution
from crewai.telemetry.tracing.context import get_trace_session
monkeypatch.setattr(
"crewai.events.listeners.tracing.utils.should_auto_collect_first_time_traces",
lambda: True,
)
if disabled_by == "environment":
monkeypatch.setenv("CREWAI_TRACING_ENABLED", "false")
consent = Mock(return_value=True)
with trace_consent(consent):
token = begin_execution(tracing=False if disabled_by == "override" else None)
try:
assert get_trace_session() is None
finally:
end_execution(token)
consent.assert_not_called()
assert not collector.grants and not collector.batches
def test_incomplete_event_drain_discards_without_consent(collector, monkeypatch):
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
consent = Mock(return_value=True)
with trace_consent(consent), ephemeral_tracing(str(uuid4())) as session:
record(session)
monkeypatch.setattr(session, "finish_spans", Mock(return_value=False))
consent.assert_not_called()
assert buffer._closed and not buffer._spans
assert not collector.grants and not collector.batches
# Restore real shutdown for this synthetic drain failure.
monkeypatch.undo()
session.shutdown()
@pytest.mark.parametrize("phase", ["grant", "export"])
def test_failed_sharing_discards_without_logging_payloads(
collector, monkeypatch, caplog, phase
):
buffer = EphemeralSpanBuffer()
monkeypatch.setattr(ephemeral, "EphemeralSpanBuffer", lambda: buffer)
if phase == "grant":
collector.grant_status = 403
else:
collector.export_status = 403
with trace_consent(lambda: True), ephemeral_tracing(str(uuid4())) as session:
record(session)
assert buffer._closed and not buffer._spans
assert "local private input" not in caplog.text
assert "grant-1" not in caplog.text
assert len(collector.grants) == 1
assert len(collector.batches) == int(phase == "export")
def test_buffer_evicts_oldest_spans_and_obeys_encoded_bytes(monkeypatch):
exporter = InMemorySpanExporter()
provider = TracerProvider()
provider.add_span_processor(SimpleSpanProcessor(exporter))
for number in range(3):
provider.get_tracer("buffer").start_span(str(number)).end()
provider.shutdown()
finished = exporter.get_finished_spans()
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_SPANS", "2")
max_bytes = sum(encode_spans([span]).ByteSize() for span in finished[-2:])
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_BYTES", str(max_bytes))
buffer = EphemeralSpanBuffer()
assert buffer.export(finished) == SpanExportResult.SUCCESS
assert [span.name for span, _ in buffer._spans] == ["1", "2"]
assert buffer._size <= max_bytes and buffer._dropped == 1
buffer.shutdown()
assert buffer._size == 0 and not buffer._spans
def test_buffer_drops_single_span_larger_than_its_byte_limit(monkeypatch):
exporter = InMemorySpanExporter()
provider = TracerProvider()
provider.add_span_processor(SimpleSpanProcessor(exporter))
provider.get_tracer("buffer").start_span(
"large", attributes={"gen_ai.input.messages": "x" * 1000}
).end()
provider.shutdown()
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_BYTES", "100")
buffer = EphemeralSpanBuffer()
buffer.export(exporter.get_finished_spans())
assert not buffer._spans and buffer._size == 0 and buffer._dropped == 1
buffer.shutdown()
@pytest.mark.parametrize("invalid", ["0", "-1", "broken"])
def test_invalid_buffer_limits_use_safe_defaults(monkeypatch, invalid):
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_SPANS", invalid)
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_BYTES", invalid)
buffer = EphemeralSpanBuffer()
assert buffer._max_spans == 1000 and buffer._max_bytes == 8388608
buffer.shutdown()
@pytest.fixture
def sent_features(monkeypatch):
"""The `tracing:*` Feature Usage names emitted, in order."""
from crewai.telemetry.telemetry import Telemetry
features = []
monkeypatch.setattr(
Telemetry,
"feature_usage_span",
lambda self, feature: features.append(feature)
if feature.startswith("tracing:")
else None,
)
return features
@pytest.mark.parametrize(
("authenticated", "approved", "grant_status", "export_status", "expected"),
[
(True, True, 200, 200, ["tracing:authenticated_sent"]),
(False, True, 200, 200, ["tracing:ephemeral_sent"]),
(False, False, 200, 200, []),
(True, True, 200, 401, []),
(False, True, 200, 401, []),
(False, True, 500, 200, []),
],
)
def test_a_trace_that_reaches_amp_is_counted_once_by_tier(
collector,
sent_features,
monkeypatch,
authenticated,
approved,
grant_status,
export_status,
expected,
):
"""Declined consent, a refused grant, or a rejected export never counts."""
from crewai.execution import begin_execution, end_execution
from crewai.telemetry.tracing.context import get_trace_session
collector.grant_status = grant_status
collector.export_status = export_status
if authenticated:
monkeypatch.setenv("CREWAI_USER_PAT", "synthetic-pat")
def run():
with trace_consent(lambda: approved):
token = begin_execution(tracing=True)
try:
record(get_trace_session())
nested = begin_execution(tracing=True)
end_execution(nested)
finally:
end_execution(token)
copy_context().run(run)
assert sent_features == expected
def test_a_deferred_run_is_counted_once_when_it_finally_ends(
collector, sent_features, monkeypatch
):
from crewai.execution import begin_execution, end_execution
from crewai.telemetry.tracing.context import get_trace_session
monkeypatch.setenv("CREWAI_USER_PAT", "synthetic-pat")
token = begin_execution(tracing=True)
try:
session = get_trace_session()
record(session)
session.flush()
finally:
lifetime = end_execution(token, defer=True)
assert sent_features == [] # spans reached AMP, but the run is not over
token = begin_execution(tracing=True, trace_session=lifetime)
try:
record(get_trace_session(), "second turn")
finally:
end_execution(token)
assert sent_features == ["tracing:authenticated_sent"]
def test_recording_the_same_export_twice_counts_it_once(collector, sent_features):
client = TraceGrantClient(None)
grant = client.create(str(uuid4()))
exporter = GrantSpanExporter(client, grant)
session = TraceSession(grant.execution_uuid, [exporter])
try:
record(session)
finally:
session.shutdown()
exporter.record_export()
exporter.record_export()
assert sent_features == ["tracing:ephemeral_sent"]
def test_a_truncated_ephemeral_trace_is_not_counted(
collector, sent_features, monkeypatch
):
"""It is uploaded, but like the `crewai eval` record it is not a whole run."""
monkeypatch.setenv("CREWAI_EPHEMERAL_TRACE_MAX_SPANS", "1")
with trace_consent(lambda: True), ephemeral_tracing(str(uuid4())) as session:
record(session, "first")
record(session, "second")
assert len(collector.batches) == 1
assert sent_features == []
@pytest.mark.parametrize("authenticated", [True, False])
@pytest.mark.parametrize("use_async", [False, True])
def test_a_flow_kickoff_counts_its_trace(
collector, sent_features, monkeypatch, authenticated, use_async
):
from crewai.flow.flow import Flow, start
if authenticated:
monkeypatch.setenv("CREWAI_USER_PAT", "synthetic-pat")
class Greeting(Flow):
@start()
def greet(self):
return "hello"
def run():
with trace_consent(lambda: True):
flow = Greeting(tracing=True)
if use_async:
return asyncio.run(flow.kickoff_async())
return flow.kickoff()
assert copy_context().run(run) == "hello"
assert collector.batches
assert sent_features == [
"tracing:authenticated_sent" if authenticated else "tracing:ephemeral_sent"
]