mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-07-22 15:25:09 +00:00
f0704ebb22
* feat(skills)!: promote Skills Repository out of experimental The registry-backed Skills Repository (crewai skill create/publish/ install/list, @org/name refs, global cache) is now mainline: - CLI: `crewai skill ...` is a top-level group; the CREWAI_EXPERIMENTAL gate and the now-empty `crewai experimental` group are removed. - Runtime: registry.py, cache.py, and events.py move from crewai.experimental.skills into crewai.skills next to the loader; the require_experimental_skills() gate is gone. crewai.experimental.skills remains as a deprecated re-export shim. - Docs: concepts/skills now leads with the CLI workflow and documents the create -> publish -> install lifecycle. Linear: n/a (requested promotion) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(skills): org-scoped publish only + docs in all languages Skills are always scoped to the publishing organization, like tools: drop the --public/--private flags from `crewai skill publish` and always send is_public=False to the registry. CLI tests assert the flag is rejected and the API never receives a public publish. Translate the new CLI-first Quick Start and the create -> publish -> install lifecycle section into ar, pt-BR, and ko concepts/skills docs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(skills): address review comments on the promotion PR - Back-compat shim now aliases the old submodules in sys.modules so `crewai.experimental.skills.registry/cache/events` imports (and patch targets) resolve to the real crewai.skills modules, not just the package-root re-exports. - `crewai skill publish` actually enforces the git-state check that --force claims to skip: unsynced repos block publishing (mirroring tool publish); standalone skill dirs outside any git repo publish without a check. - Explicit UTF-8 encoding on SKILL.md and cache-metadata reads/writes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(skills): fail closed when git state cannot be validated on publish Follow deploy's pattern: construct git.Repository(fetch=False) and only treat "not a Git repository" as skippable — any other git error (fetch/auth/misconfiguration) now blocks publish with a --force escape hatch instead of silently bypassing the sync check. Also single-style imports in the shim test (CodeQL) with the dotted shim import covered via importlib. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(skills): fetch before sync check on publish; bump mcp past advisories Publish now refreshes remote-tracking refs (repository.fetch()) before is_synced(), so ahead/behind is judged against the actual remote rather than stale local refs; a failing fetch blocks publish with the --force escape hatch. Adds a fail-closed test for fetch errors. Raise mcp to >=1.28.1,<2 (locks 1.28.1): the ~=1.26.0 pin blocked GHSA-hvrp-rf83-w775 / GHSA-jpw9-pfvf-9f58 (fixed 1.27.2) and GHSA-vj7q-gjh5-988w (fixed 1.28.1), which were failing pip-audit on this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Vinicius Brasil <vini@hey.com>
64 lines
2.3 KiB
Python
64 lines
2.3 KiB
Python
"""Tests for the top-level `crewai skill` command group.
|
|
|
|
The Skills Repository graduated from the gated `crewai experimental skill`
|
|
group: the commands must be reachable at `crewai skill ...` without
|
|
CREWAI_EXPERIMENTAL set.
|
|
"""
|
|
|
|
from unittest import mock
|
|
|
|
from click.testing import CliRunner
|
|
from crewai_cli.cli import crewai
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def runner():
|
|
return CliRunner()
|
|
|
|
|
|
@pytest.fixture
|
|
def no_experimental_env(monkeypatch):
|
|
monkeypatch.delenv("CREWAI_EXPERIMENTAL", raising=False)
|
|
|
|
|
|
class TestSkillGroupIsTopLevel:
|
|
def test_skill_group_registered_at_top_level(self, runner, no_experimental_env):
|
|
result = runner.invoke(crewai, ["skill", "--help"])
|
|
assert result.exit_code == 0, result.output
|
|
for subcommand in ("create", "install", "publish", "list"):
|
|
assert subcommand in result.output
|
|
|
|
def test_skill_group_not_gated_by_experimental_env(
|
|
self, runner, no_experimental_env
|
|
):
|
|
with mock.patch("crewai_cli.skills.main.SkillCommand") as mock_cmd:
|
|
result = runner.invoke(crewai, ["skill", "create", "my-skill"])
|
|
assert result.exit_code == 0, result.output
|
|
mock_cmd.return_value.create.assert_called_once_with(
|
|
"my-skill", in_project=True
|
|
)
|
|
|
|
def test_skill_create_no_project_flag(self, runner, no_experimental_env):
|
|
with mock.patch("crewai_cli.skills.main.SkillCommand") as mock_cmd:
|
|
result = runner.invoke(crewai, ["skill", "create", "my-skill", "--no-project"])
|
|
assert result.exit_code == 0, result.output
|
|
mock_cmd.return_value.create.assert_called_once_with(
|
|
"my-skill", in_project=False
|
|
)
|
|
|
|
|
|
class TestSkillPublishIsOrgScopedOnly:
|
|
def test_publish_rejects_public_flag(self, runner, no_experimental_env):
|
|
result = runner.invoke(crewai, ["skill", "publish", "--public"])
|
|
assert result.exit_code != 0
|
|
assert "No such option" in result.output
|
|
|
|
def test_publish_passes_org_and_force_only(self, runner, no_experimental_env):
|
|
with mock.patch("crewai_cli.skills.main.SkillCommand") as mock_cmd:
|
|
result = runner.invoke(
|
|
crewai, ["skill", "publish", "--org", "acme", "--force"]
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
mock_cmd.return_value.publish.assert_called_once_with(org="acme", force=True)
|