mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-07-25 00:35:09 +00:00
69f63de100
json-repair < 0.60.1 has an unbounded-CPU DoS on circular JSON Schema $ref structures, and crewai feeds LLM output straight into repair_json, so the ~=0.25.2 pin kept every install inside the vulnerable range and flagged HIGH by dependency scanners with no resolvable path. Raise the requirement to >=0.60.1,<1.0.0 and adapt the agent parser to the new failure semantics: json-repair >= 0.60 returns "" (not '""') for unrepairable input and coerces non-JSON brace text into arrays, so _safe_repair_json now also keeps the original tool input unless the repair produced a JSON object. Adds a regression test asserting the published requirement excludes the vulnerable range and admits patched releases. Linear: OSS-91 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
48 lines
1.8 KiB
Python
48 lines
1.8 KiB
Python
"""Guardrails for security-sensitive dependency pins in crewai's pyproject.
|
|
|
|
These tests parse the published requirement specifiers so that a stale pin
|
|
cannot silently reintroduce a known-vulnerable dependency range.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
from packaging.requirements import Requirement
|
|
|
|
try:
|
|
import tomllib
|
|
except ModuleNotFoundError: # Python 3.10
|
|
import tomli as tomllib # type: ignore[no-redef]
|
|
|
|
PYPROJECT_PATH = Path(__file__).parents[2] / "pyproject.toml"
|
|
|
|
|
|
def _get_requirement(name: str) -> Requirement:
|
|
data = tomllib.loads(PYPROJECT_PATH.read_text())
|
|
for spec in data["project"]["dependencies"]:
|
|
requirement = Requirement(spec)
|
|
if requirement.name == name:
|
|
return requirement
|
|
raise AssertionError(f"{name} not found in [project.dependencies]")
|
|
|
|
|
|
class TestJsonRepairPin:
|
|
"""GHSA-xf7x-x43h-rpqh: json-repair < 0.60.1 has an unbounded-CPU DoS on
|
|
circular JSON Schema $ref structures. crewai feeds LLM output to
|
|
json_repair, so the vulnerable range is a real DoS surface (OSS-91)."""
|
|
|
|
def test_requirement_excludes_vulnerable_range(self) -> None:
|
|
requirement = _get_requirement("json-repair")
|
|
for vulnerable in ("0.25.2", "0.25.3", "0.59.0", "0.60.0"):
|
|
assert not requirement.specifier.contains(vulnerable), (
|
|
f"json-repair requirement '{requirement}' admits {vulnerable}, "
|
|
"which is vulnerable to GHSA-xf7x-x43h-rpqh (fixed in 0.60.1)"
|
|
)
|
|
|
|
def test_requirement_admits_patched_releases(self) -> None:
|
|
requirement = _get_requirement("json-repair")
|
|
for patched in ("0.60.1", "0.61.4"):
|
|
assert requirement.specifier.contains(patched), (
|
|
f"json-repair requirement '{requirement}' blocks patched "
|
|
f"version {patched}"
|
|
)
|