mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-07-27 09:45:16 +00:00
60f405fe54
`Telemetry.set_tracer()` installed crewAI's anonymous SDK
`TracerProvider` into OpenTelemetry's process-global slot, so the first
`Crew` constructed in a test or host application replaced the default
`ProxyTracerProvider` and exfiltrated every host span emitted via
`trace.get_tracer(...)` to crewAI's OTLP endpoint. Keep the provider
local to the `Telemetry` instance and route every anonymous span
through `self.provider.get_tracer("crewai.telemetry")` so the global
slot stays untouched. Mirrors the fix in `crewai_core.telemetry`,
drops the now-dead `set_tracer()` calls in `event_listener.py` and
`crewai_cli.command`, and adds regression coverage that asserts the
provider stays a `ProxyTracerProvider` after constructing a `Crew`.
115 lines
3.7 KiB
Python
115 lines
3.7 KiB
Python
"""Smoke tests for the crewai-core leaf modules."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
from crewai_core import (
|
|
constants,
|
|
lock_store,
|
|
paths,
|
|
printer,
|
|
user_data,
|
|
version,
|
|
)
|
|
from opentelemetry import trace
|
|
from opentelemetry.trace import ProxyTracerProvider
|
|
import pytest
|
|
|
|
|
|
def test_version_returns_string() -> None:
|
|
v = version.get_crewai_version()
|
|
assert isinstance(v, str) and v
|
|
|
|
|
|
def test_paths_creates_storage_dir(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
monkeypatch.setenv("CREWAI_STORAGE_DIR", str(tmp_path / "store"))
|
|
monkeypatch.setattr(
|
|
"crewai_core.paths.appdirs.user_data_dir",
|
|
lambda app, author: str(tmp_path / app),
|
|
)
|
|
out = paths.db_storage_path()
|
|
assert Path(out).exists()
|
|
|
|
|
|
def test_constants_exposes_env_keys() -> None:
|
|
assert constants.CREWAI_TRAINED_AGENTS_FILE_ENV == "CREWAI_TRAINED_AGENTS_FILE"
|
|
|
|
|
|
def test_printer_emits_when_not_suppressed(capsys: pytest.CaptureFixture[str]) -> None:
|
|
printer.PRINTER.print("hello", color="green")
|
|
out = capsys.readouterr().out
|
|
assert "hello" in out
|
|
|
|
|
|
def test_printer_respects_suppression(capsys: pytest.CaptureFixture[str]) -> None:
|
|
token = printer.set_suppress_console_output(True)
|
|
try:
|
|
printer.PRINTER.print("hidden")
|
|
finally:
|
|
printer._suppress_console_output.reset(token) # type: ignore[arg-type]
|
|
assert "hidden" not in capsys.readouterr().out
|
|
|
|
|
|
def test_lock_acquires_and_releases() -> None:
|
|
with lock_store.lock("crewai_core.tests.smoke", timeout=5):
|
|
pass
|
|
|
|
|
|
def test_user_data_round_trip(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setenv("CREWAI_STORAGE_DIR", "crewai_core_test_user_data")
|
|
monkeypatch.setattr(
|
|
"crewai_core.paths.appdirs.user_data_dir",
|
|
lambda app, author: str(tmp_path / app),
|
|
)
|
|
user_data.update_user_data({"trace_consent": True, "first_execution_done": True})
|
|
data = user_data._load_user_data()
|
|
assert data == {"trace_consent": True, "first_execution_done": True}
|
|
assert user_data.has_user_declined_tracing() is False
|
|
monkeypatch.setenv("CREWAI_TRACING_ENABLED", "true")
|
|
assert user_data.is_tracing_enabled() is True
|
|
monkeypatch.delenv("CREWAI_TRACING_ENABLED", raising=False)
|
|
assert (
|
|
user_data.is_tracing_enabled() is True
|
|
) # consent alone enables (matches runtime)
|
|
|
|
|
|
def test_user_data_decline_blocks(
|
|
tmp_path: Path, monkeypatch: pytest.MonkeyPatch
|
|
) -> None:
|
|
monkeypatch.setenv("CREWAI_STORAGE_DIR", "crewai_core_test_decline")
|
|
monkeypatch.setattr(
|
|
"crewai_core.paths.appdirs.user_data_dir",
|
|
lambda app, author: str(tmp_path / app),
|
|
)
|
|
user_data.update_user_data({"trace_consent": False, "first_execution_done": True})
|
|
assert user_data.has_user_declined_tracing() is True
|
|
monkeypatch.delenv("CREWAI_TRACING_ENABLED", raising=False)
|
|
assert user_data.is_tracing_enabled() is False
|
|
monkeypatch.setenv("CREWAI_TRACING_ENABLED", "true")
|
|
assert user_data.is_tracing_enabled() is True # env-var override (matches runtime)
|
|
|
|
|
|
def test_unused_var_warning_silenced() -> None:
|
|
# Touch os to keep the import (used by env-var fixtures above)
|
|
assert os.environ is not None
|
|
|
|
|
|
def test_core_telemetry_does_not_install_global_tracer_provider(
|
|
monkeypatch: pytest.MonkeyPatch,
|
|
) -> None:
|
|
from crewai_core.telemetry import Telemetry
|
|
|
|
Telemetry._instance = None
|
|
monkeypatch.delenv("OTEL_SDK_DISABLED", raising=False)
|
|
monkeypatch.delenv("CREWAI_DISABLE_TELEMETRY", raising=False)
|
|
monkeypatch.delenv("CREWAI_DISABLE_TRACKING", raising=False)
|
|
|
|
telemetry = Telemetry()
|
|
|
|
assert telemetry.ready is True
|
|
assert isinstance(trace.get_tracer_provider(), ProxyTracerProvider)
|