mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-09-20 10:03:37 +00:00
32a9d2ae7b
* feat(tracing): collect human feedback and pause events in the trace The trace listener subscribed to method and conversation events but not to the review-gate events or the pause events, so a `@human_feedback` gate reached the trace only as method_execution_started/finished. A trace could not say that a run stopped for review, what the reviewer was shown, or what they answered. Subscribe to HumanFeedbackRequestedEvent, HumanFeedbackReceivedEvent, MethodExecutionPausedEvent and FlowPausedEvent through `_handle_action_event`, as the conversation events are, with the event's own type as the trace type. Each is a whole-event payload via the default serialization path; no change to `_build_event_data` or `complex_events`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * fix(tracing): register the gate and pause handlers through _on, keeping the execution-uuid gate The four new handlers, and the conversation handler this branch had switched by mistake, registered with event_bus.on and so ran while a kickoff owned an execution uuid — the case where the OTEL session records these events and the legacy collector must stay idle. Restored to self._on like every other handler; a test binds an execution uuid and asserts none of the five are collected into a legacy batch. Docstrings on the handlers (review bot coverage note). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> * test(tracing): under a tracing kickoff the session records the gate and pause events and the legacy batch stays empty Two real flows under an in-memory tracing session (the lifecycle tests' pattern): a @human_feedback gate answered at the console records human_feedback_requested and human_feedback_received as spans; an async provider that parks the flow records method_execution_paused and flow_paused. In both the legacy collector, gated by _on, collects none of the four. Review bot: the uuid-gated test alone would have passed with the session registrations missing. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Vidit Ostwal <110953813+Vidit-Ostwal@users.noreply.github.com>