mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-05-28 12:28:10 +00:00
Some checks failed
CodeQL Advanced / Analyze (actions) (push) Has been cancelled
CodeQL Advanced / Analyze (python) (push) Has been cancelled
Vulnerability Scan / pip-audit (push) Has been cancelled
Nightly Canary Release / Check for new commits (push) Has been cancelled
Nightly Canary Release / Build nightly packages (push) Has been cancelled
Nightly Canary Release / Publish nightly to PyPI (push) Has been cancelled
* feat: add Skills Repository — registry, cache, CLI, and SDK integration
Adds a Skills Repository feature allowing users to publish, install,
and use skills from the CrewAI registry with @org/skill-name refs.
## What's New
### SDK (lib/crewai/)
- SkillFrontmatter: added optional 'version' field (backward compatible)
- SkillCacheManager: manages ~/.crewai/skills/{org}/{name}/ with
.crewai_meta.json tracking, path-traversal-safe tar extraction
- SkillRegistry: parse @org/skill-name refs, local-first resolution
(./skills/ > cache > download), interactive prompt on first use,
CI-mode guard (CREWAI_NONINTERACTIVE/CI env vars)
- Agent.skills and Crew.skills widened to accept str refs (@org/name)
- set_skills() resolves registry refs with org-prefixed dedup keys
- New events: SkillDownloadStartedEvent, SkillDownloadCompletedEvent
### CLI (lib/cli/)
- crewai skill create <name> — context-aware (project vs standalone)
- crewai skill install @org/name — downloads to ./skills/ or cache
- crewai skill publish — ZIP + upload to org registry
- crewai skill list — show installed skills
### PlusAPI (lib/crewai-core/)
- Added SKILLS_RESOURCE, get_skill(), publish_skill(), list_skills()
### Scaffolding
- crew and flow templates now include skills/ directory
### Tests
- 91 SDK skill tests + 15 CLI skill tests, all passing
* fix: address all CI failures and CodeRabbit review comments
Lint:
- Remove unused imports (click, pytest, json)
- Replace try-except-pass with logging (S110)
- Fix unprotected zipfile.extractall (S202)
Security:
- Path traversal: startswith → is_relative_to for tar extraction
- Add path traversal protection to ZIP extraction via _safe_extract_zip
- Both cache.py and CLI main.py hardened
Type checker:
- Fix import path: crewai.events.event_bus (not crewai_event_bus)
- Remove unused type: ignore comments
- Fix type mismatches in set_skills() variable types
Code quality:
- Fix f-string interpolation in SkillNotCachedError
- Use ValidationError instead of Exception in test
* style: ruff format + autofix remaining lint errors
* refactor: reuse SDK parser and SkillCacheManager in CLI
- _parse_frontmatter() now delegates to crewai.skills.parser.parse_frontmatter
when available, with a minimal fallback for CLI-only installs
- install() global cache path now reuses SkillCacheManager.store() instead
of duplicating metadata writing logic
* refactor: add _print_current_organization to SkillCommand (matches ToolCommand pattern)
* fix: write .crewai_meta.json in fallback install path
CodeRabbit caught that the ImportError fallback in install() didn't write
cache metadata, making skills invisible to 'crewai skill list'.
* fix: tighten @org/name ref validation to prevent path traversal
Reject refs with multiple slashes (@org/a/b), dot segments (@../skill),
or leading dots in org/name. Applied to both CLI install() and SDK
parse_registry_ref() so the contract is enforced consistently.
* fix: update test assertions to match tightened error messages
* fix: align OSS client with AMP API contract
- download_skill(): fetch download_url (presigned URL) instead of
expecting inline base64. Falls back to 'file' field for compat.
- Read 'latest_version' field, fall back to 'version'
- Same fixes applied to CLI install() command
* fix: publish as tar.gz (matches AMP content_type validation) + add zip fallback to SDK cache
CLI publish:
- _build_skill_zip → _build_skill_tarball (tar.gz format)
- Content type: application/x-gzip (matches SkillVersion validation)
SDK cache:
- store() now tries tar.gz first, falls back to zip extraction
- Added _safe_extract_zip for path-traversal-safe zip handling
- Both formats work for download/install regardless of server format
---------
Co-authored-by: João Moura <joaomdmoura@gmail.com>
86 lines
2.8 KiB
Python
86 lines
2.8 KiB
Python
from functools import cached_property
|
|
import subprocess
|
|
|
|
|
|
class Repository:
|
|
def __init__(self, path: str = ".") -> None:
|
|
self.path = path
|
|
|
|
if not self.is_git_installed():
|
|
raise ValueError("Git is not installed or not found in your PATH.")
|
|
|
|
if not self.is_git_repo:
|
|
raise ValueError(f"{self.path} is not a Git repository.")
|
|
|
|
self.fetch()
|
|
|
|
@staticmethod
|
|
def is_git_installed() -> bool:
|
|
"""Check if Git is installed and available in the system."""
|
|
try:
|
|
subprocess.run(
|
|
["git", "--version"], # noqa: S607
|
|
capture_output=True,
|
|
check=True,
|
|
text=True,
|
|
)
|
|
return True
|
|
except (subprocess.CalledProcessError, FileNotFoundError):
|
|
return False
|
|
|
|
def fetch(self) -> None:
|
|
"""Fetch latest updates from the remote."""
|
|
subprocess.run(["git", "fetch"], cwd=self.path, check=True) # noqa: S607
|
|
|
|
def status(self) -> str:
|
|
"""Get the git status in porcelain format."""
|
|
return subprocess.check_output(
|
|
["git", "status", "--branch", "--porcelain"], # noqa: S607
|
|
cwd=self.path,
|
|
encoding="utf-8",
|
|
).strip()
|
|
|
|
@cached_property
|
|
def is_git_repo(self) -> bool:
|
|
"""Check if the current directory is a git repository."""
|
|
try:
|
|
subprocess.check_output(
|
|
["git", "rev-parse", "--is-inside-work-tree"], # noqa: S607
|
|
cwd=self.path,
|
|
encoding="utf-8",
|
|
)
|
|
return True
|
|
except subprocess.CalledProcessError:
|
|
return False
|
|
|
|
def has_uncommitted_changes(self) -> bool:
|
|
"""Check if the repository has uncommitted changes."""
|
|
return len(self.status().splitlines()) > 1
|
|
|
|
def is_ahead_or_behind(self) -> bool:
|
|
"""Check if the repository is ahead or behind the remote."""
|
|
for line in self.status().splitlines():
|
|
if line.startswith("##") and ("ahead" in line or "behind" in line):
|
|
return True
|
|
return False
|
|
|
|
def is_synced(self) -> bool:
|
|
"""Return True if the Git repository is fully synced with the remote, False otherwise."""
|
|
if self.has_uncommitted_changes() or self.is_ahead_or_behind():
|
|
return False
|
|
return True
|
|
|
|
def origin_url(self) -> str | None:
|
|
"""Get the Git repository's remote URL."""
|
|
try:
|
|
result = subprocess.run(
|
|
["git", "remote", "get-url", "origin"], # noqa: S607
|
|
cwd=self.path,
|
|
capture_output=True,
|
|
text=True,
|
|
check=True,
|
|
)
|
|
return result.stdout.strip()
|
|
except subprocess.CalledProcessError:
|
|
return None
|