From fd89c3b89630c000d3f170e87318820dc650e86c Mon Sep 17 00:00:00 2001
From: Lorenze Jay <lorenzejaytech@gmail.com>
Date: Mon, 27 Jan 2025 15:48:57 -0800
Subject: [PATCH] cleanup

---
 src/crewai/agents/agent_builder/base_agent.py  |  6 ------
 src/crewai/knowledge/knowledge.py              |  4 ----
 src/crewai/utilities/embedding_configurator.py |  4 ----
 tests/agent_test.py                            | 11 ++---------
 4 files changed, 2 insertions(+), 23 deletions(-)

diff --git a/src/crewai/agents/agent_builder/base_agent.py b/src/crewai/agents/agent_builder/base_agent.py
index b01d40a19..19f2facff 100644
--- a/src/crewai/agents/agent_builder/base_agent.py
+++ b/src/crewai/agents/agent_builder/base_agent.py
@@ -276,12 +276,8 @@ class BaseAgent(ABC, BaseModel):
 
         # Copy llm
         existing_llm = shallow_copy(self.llm)
-        print("self.knowledge", self.knowledge)
         copied_knowledge = shallow_copy(self.knowledge)
         copied_knowledge_storage = shallow_copy(self.knowledge_storage)
-        print("existing_llm", existing_llm)
-        print("copied_knowledge_storage", copied_knowledge_storage)
-        print("copied_knowledge", copied_knowledge)
         # Properly copy knowledge sources if they exist
         existing_knowledge_sources = None
         if self.knowledge_sources:
@@ -302,9 +298,7 @@ class BaseAgent(ABC, BaseModel):
                 existing_knowledge_sources.append(copied_source)
 
         copied_data = self.model_dump(exclude=exclude)
-        print("copied_data", copied_data)
         copied_data = {k: v for k, v in copied_data.items() if v is not None}
-        print("copied_data", copied_data)
         copied_agent = type(self)(
             **copied_data,
             llm=existing_llm,
diff --git a/src/crewai/knowledge/knowledge.py b/src/crewai/knowledge/knowledge.py
index daa24df89..d1d4ede6c 100644
--- a/src/crewai/knowledge/knowledge.py
+++ b/src/crewai/knowledge/knowledge.py
@@ -41,8 +41,6 @@ class Knowledge(BaseModel):
             )
         self.sources = sources
         self.storage.initialize_knowledge_storage()
-        print("self.storage", self.storage)
-
         self._add_sources()
 
     def query(self, query: List[str], limit: int = 3) -> List[Dict[str, Any]]:
@@ -64,10 +62,8 @@ class Knowledge(BaseModel):
 
     def _add_sources(self):
         try:
-            print("adding sources", self.storage)
             for source in self.sources:
                 source.storage = self.storage
                 source.add()
         except Exception as e:
-            print("Error adding sources", e)
             raise e
diff --git a/src/crewai/utilities/embedding_configurator.py b/src/crewai/utilities/embedding_configurator.py
index 1f94403d5..875dab977 100644
--- a/src/crewai/utilities/embedding_configurator.py
+++ b/src/crewai/utilities/embedding_configurator.py
@@ -43,10 +43,6 @@ class EmbeddingConfigurator:
             raise Exception(
                 f"Unsupported embedding provider: {provider}, supported providers: {list(self.embedding_functions.keys())}"
             )
-        print(
-            "self.embedding_functions[provider](config, model_name)",
-            self.embedding_functions[provider](config, model_name),
-        )
         return self.embedding_functions[provider](config, model_name)
 
     @staticmethod
diff --git a/tests/agent_test.py b/tests/agent_test.py
index 991a5633c..fa519e7ac 100644
--- a/tests/agent_test.py
+++ b/tests/agent_test.py
@@ -1608,29 +1608,22 @@ def test_agent_with_knowledge_sources_works_with_copy():
     content = "Brandon's favorite color is red and he likes Mexican food."
     string_source = StringKnowledgeSource(content=content)
 
-    # Create a real instance to use as spec
-
     with patch(
         "crewai.knowledge.source.base_knowledge_source.BaseKnowledgeSource",
         autospec=True,
     ) as MockKnowledgeSource:
-        # Set up the mock instance using the real class as spec
         mock_knowledge_source_instance = MockKnowledgeSource.return_value
         mock_knowledge_source_instance.__class__ = BaseKnowledgeSource
         mock_knowledge_source_instance.sources = [string_source]
-        # mock_knowledge_source_instance.query.return_value = [{"content": content}]
 
         agent = Agent(
             role="Information Agent",
             goal="Provide information based on knowledge sources",
             backstory="You have access to specific knowledge sources.",
             llm=LLM(model="gpt-4o-mini"),
-            knowledge_sources=[
-                string_source
-            ],  # Use the real string source instead of mock
+            knowledge_sources=[string_source],
         )
 
-        # Mock the knowledge attribute to avoid validation issues during copy
         with patch(
             "crewai.knowledge.storage.knowledge_storage.KnowledgeStorage"
         ) as MockKnowledgeStorage:
@@ -1639,10 +1632,10 @@ def test_agent_with_knowledge_sources_works_with_copy():
 
             agent_copy = agent.copy()
 
-            # Basic assertions
             assert agent_copy.role == agent.role
             assert agent_copy.goal == agent.goal
             assert agent_copy.backstory == agent.backstory
+            assert agent_copy.knowledge_sources is not None
             assert len(agent_copy.knowledge_sources) == 1
             assert isinstance(agent_copy.knowledge_sources[0], StringKnowledgeSource)
             assert agent_copy.knowledge_sources[0].content == content