From fced8ba47fa7f27473d48b7e00706f62632dbc12 Mon Sep 17 00:00:00 2001 From: Lucas Gomide Date: Mon, 12 May 2025 11:46:55 -0300 Subject: [PATCH] sytle: fix linter issues --- src/crewai/task.py | 1 - src/crewai/telemetry/telemetry.py | 24 ++++++++++++------------ src/crewai/utilities/formatter.py | 4 +--- tests/crew_test.py | 6 +----- 4 files changed, 14 insertions(+), 21 deletions(-) diff --git a/src/crewai/task.py b/src/crewai/task.py index 5204ba92e..754fab491 100644 --- a/src/crewai/task.py +++ b/src/crewai/task.py @@ -2,7 +2,6 @@ import datetime import inspect import json import logging -import re import threading import uuid from concurrent.futures import Future diff --git a/src/crewai/telemetry/telemetry.py b/src/crewai/telemetry/telemetry.py index ffd88a330..e22d757cd 100644 --- a/src/crewai/telemetry/telemetry.py +++ b/src/crewai/telemetry/telemetry.py @@ -10,6 +10,18 @@ from contextlib import contextmanager from importlib.metadata import version from typing import TYPE_CHECKING, Any, Optional +from opentelemetry import trace +from opentelemetry.exporter.otlp.proto.http.trace_exporter import ( + OTLPSpanExporter, +) +from opentelemetry.sdk.resources import SERVICE_NAME, Resource +from opentelemetry.sdk.trace import TracerProvider +from opentelemetry.sdk.trace.export import ( + BatchSpanProcessor, + SpanExportResult, +) +from opentelemetry.trace import Span, Status, StatusCode + from crewai.telemetry.constants import ( CREWAI_TELEMETRY_BASE_URL, CREWAI_TELEMETRY_SERVICE_NAME, @@ -25,18 +37,6 @@ def suppress_warnings(): yield -from opentelemetry import trace # noqa: E402 -from opentelemetry.exporter.otlp.proto.http.trace_exporter import ( - OTLPSpanExporter, # noqa: E402 -) -from opentelemetry.sdk.resources import SERVICE_NAME, Resource # noqa: E402 -from opentelemetry.sdk.trace import TracerProvider # noqa: E402 -from opentelemetry.sdk.trace.export import ( # noqa: E402 - BatchSpanProcessor, - SpanExportResult, -) -from opentelemetry.trace import Span, Status, StatusCode # noqa: E402 - if TYPE_CHECKING: from crewai.crew import Crew from crewai.task import Task diff --git a/src/crewai/utilities/formatter.py b/src/crewai/utilities/formatter.py index 9c2da70c6..fd2611472 100644 --- a/src/crewai/utilities/formatter.py +++ b/src/crewai/utilities/formatter.py @@ -1,7 +1,5 @@ -import re -from typing import TYPE_CHECKING, List, Type +from typing import TYPE_CHECKING, List -from crewai.utilities.constants import NOT_SPECIFIED if TYPE_CHECKING: from crewai.task import Task diff --git a/tests/crew_test.py b/tests/crew_test.py index 4ca1fe878..7c242c825 100644 --- a/tests/crew_test.py +++ b/tests/crew_test.py @@ -2,8 +2,6 @@ import hashlib import json -import os -import tempfile from concurrent.futures import Future from unittest import mock from unittest.mock import ANY, MagicMock, patch @@ -13,11 +11,9 @@ import pytest from crewai.agent import Agent from crewai.agents import CacheHandler -from crewai.agents.cache import CacheHandler -from crewai.agents.crew_agent_executor import CrewAgentExecutor from crewai.crew import Crew from crewai.crews.crew_output import CrewOutput -from crewai.flow import Flow, listen, start +from crewai.flow import Flow, start from crewai.knowledge.source.string_knowledge_source import StringKnowledgeSource from crewai.llm import LLM from crewai.memory.contextual.contextual_memory import ContextualMemory