From fae1cfdc896879a56e0ce3b1c9acc53b3dce5a8d Mon Sep 17 00:00:00 2001 From: Vinicius Brasil Date: Thu, 20 Mar 2025 10:27:29 -0300 Subject: [PATCH] Fix failing test --- .../utilities/events/crewai_event_bus.py | 5 +---- .../utilities/events/test_crewai_event_bus.py | 22 +++++++------------ 2 files changed, 9 insertions(+), 18 deletions(-) diff --git a/src/crewai/utilities/events/crewai_event_bus.py b/src/crewai/utilities/events/crewai_event_bus.py index 0c4a7381f..47325dc5d 100644 --- a/src/crewai/utilities/events/crewai_event_bus.py +++ b/src/crewai/utilities/events/crewai_event_bus.py @@ -9,6 +9,7 @@ from crewai.utilities.events.event_types import EventTypes EventT = TypeVar("EventT", bound=CrewEvent) + class CrewAIEventsBus: """ A singleton event bus that uses blinker signals for event handling. @@ -74,10 +75,6 @@ class CrewAIEventsBus: self._signal.send(source, event=event) - def clear_handlers(self) -> None: - """Clear all registered event handlers - useful for testing""" - self._handlers.clear() - def register_handler( self, event_type: Type[EventTypes], handler: Callable[[Any, EventTypes], None] ) -> None: diff --git a/tests/utilities/events/test_crewai_event_bus.py b/tests/utilities/events/test_crewai_event_bus.py index ab685b6f5..0dd8c8b34 100644 --- a/tests/utilities/events/test_crewai_event_bus.py +++ b/tests/utilities/events/test_crewai_event_bus.py @@ -1,40 +1,34 @@ from unittest.mock import Mock -import pytest - from crewai.utilities.events.base_events import CrewEvent -from crewai.utilities.events.crewai_event_bus import CrewAIEventsBus +from crewai.utilities.events.crewai_event_bus import crewai_event_bus class TestEvent(CrewEvent): pass -@pytest.fixture -def event_bus(): - bus = CrewAIEventsBus() - bus.clear_handlers() - return bus -def test_specific_event_handler(event_bus): +def test_specific_event_handler(): mock_handler = Mock() - @event_bus.on(TestEvent) + @crewai_event_bus.on(TestEvent) def handler(source, event): mock_handler(source, event) event = TestEvent(type="test_event") - event_bus.emit("source_object", event) + crewai_event_bus.emit("source_object", event) mock_handler.assert_called_once_with("source_object", event) -def test_wildcard_event_handler(event_bus): + +def test_wildcard_event_handler(): mock_handler = Mock() - @event_bus.on(CrewEvent) + @crewai_event_bus.on(CrewEvent) def handler(source, event): mock_handler(source, event) event = TestEvent(type="test_event") - event_bus.emit("source_object", event) + crewai_event_bus.emit("source_object", event) mock_handler.assert_called_once_with("source_object", event)