From f4807ee8583991d2f71e94f0042522e08667c63f Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 1 Jul 2025 22:13:10 +0000 Subject: [PATCH] Fix URL validation to only accept HTTP/HTTPS schemes for Ollama embeddings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Update _validate_url() to restrict schemes to 'http' and 'https' only - Fixes CI test failures for ftp://invalid-scheme test cases - Maintains security by preventing non-web protocols Co-Authored-By: João --- src/crewai/utilities/embedding_configurator.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/crewai/utilities/embedding_configurator.py b/src/crewai/utilities/embedding_configurator.py index ef7da0861..a744b0488 100644 --- a/src/crewai/utilities/embedding_configurator.py +++ b/src/crewai/utilities/embedding_configurator.py @@ -93,7 +93,7 @@ class EmbeddingConfigurator: @staticmethod def _validate_url(url): - """Validate that a URL is properly formatted.""" + """Validate that a URL is properly formatted and uses HTTP/HTTPS scheme.""" if not url: return False @@ -101,7 +101,10 @@ class EmbeddingConfigurator: try: result = urlparse(url) - return all([result.scheme, result.netloc]) + return all([ + result.scheme in ('http', 'https'), + result.netloc + ]) except ValueError: return False