From f1b0dcb0524f99f0a6618d8b2bc1e634f8dac3d6 Mon Sep 17 00:00:00 2001
From: lucasgomide <lucaslg200@gmail.com>
Date: Tue, 1 Apr 2025 14:26:32 -0300
Subject: [PATCH] feat: support set the current crew in memory

This can be useful when a memory is initialized before the crew, but the crew might still be a very relevant attribute
---
 src/crewai/crew.py                            |  5 ++--
 src/crewai/memory/external/external_memory.py | 30 +++++++++++--------
 src/crewai/memory/memory.py                   |  7 ++++-
 3 files changed, 27 insertions(+), 15 deletions(-)

diff --git a/src/crewai/crew.py b/src/crewai/crew.py
index fd825c335..5ef426e1b 100644
--- a/src/crewai/crew.py
+++ b/src/crewai/crew.py
@@ -296,9 +296,10 @@ class Crew(BaseModel):
                 else EntityMemory(crew=self, embedder_config=self.embedder)
             )
             self._external_memory = (
-                self.external_memory
+                # External memory doesn’t support a default value since it was designed to be managed entirely externally
+                self.external_memory.set_crew(self)
                 if self.external_memory
-                else ExternalMemory(crew=self, embedder_config=self.embedder)
+                else None
             )
             if (
                 self.memory_config
diff --git a/src/crewai/memory/external/external_memory.py b/src/crewai/memory/external/external_memory.py
index c0f430769..35a2d9d71 100644
--- a/src/crewai/memory/external/external_memory.py
+++ b/src/crewai/memory/external/external_memory.py
@@ -1,4 +1,4 @@
-from typing import Any, Dict, Optional
+from typing import Any, Dict, Optional, Self
 
 from crewai.memory.external.external_memory_item import ExternalMemoryItem
 from crewai.memory.memory import Memory
@@ -10,10 +10,10 @@ class ExternalMemory(Memory):
         storage = (
             storage
             if storage
-            else self._create_storage(crew=crew, embedder_config=embedder_config)
+            else self.create_storage(crew=crew, embedder_config=embedder_config)
         )
 
-        super().__init__(storage=storage)
+        super().__init__(storage=storage, embedder_config=embedder_config, crew=crew)
 
     @staticmethod
     def _configure_mem0(crew, config) -> "Mem0Storage":
@@ -21,26 +21,26 @@ class ExternalMemory(Memory):
 
         return Mem0Storage(type="external", crew=crew, config=config)
 
-    @property
-    def external_supported_storages(self):
+    @staticmethod
+    def external_supported_storages():
         return {
-            "mem0": self._configure_mem0,
+            "mem0": ExternalMemory._configure_mem0,
         }
 
-    def _create_storage(self, crew, embedder_config):
+    @staticmethod
+    def create_storage(crew, embedder_config):
         if not embedder_config:
-            return Storage()
+            raise ValueError("embedder_config is required")
 
         if embedder_config and "provider" not in embedder_config:
             raise ValueError("embedder_config must include a 'provider' key")
 
         provider = embedder_config["provider"]
-        if provider not in self.external_supported_storages:
+        supported_storages = ExternalMemory.external_supported_storages()
+        if provider not in supported_storages:
             raise ValueError(f"Provider {provider} not supported")
 
-        return self.external_supported_storages[provider](
-            crew, embedder_config.get("config", {})
-        )
+        return supported_storages[provider](crew, embedder_config.get("config", {}))
 
     def save(
         self,
@@ -54,3 +54,9 @@ class ExternalMemory(Memory):
 
     def reset(self) -> None:
         self.storage.reset()
+
+    def set_crew(self, crew: Any) -> Self:
+        super().set_crew(crew)
+        self.storage = self.create_storage(crew, self.embedder_config)
+
+        return self
diff --git a/src/crewai/memory/memory.py b/src/crewai/memory/memory.py
index 9a362a512..ba8c10a29 100644
--- a/src/crewai/memory/memory.py
+++ b/src/crewai/memory/memory.py
@@ -1,4 +1,4 @@
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, List, Optional, Self
 
 from pydantic import BaseModel
 
@@ -9,6 +9,7 @@ class Memory(BaseModel):
     """
 
     embedder_config: Optional[Dict[str, Any]] = None
+    crew: Optional[Any] = None
 
     storage: Any
 
@@ -36,3 +37,7 @@ class Memory(BaseModel):
         return self.storage.search(
             query=query, limit=limit, score_threshold=score_threshold
         )
+
+    def set_crew(self, crew: Any) -> Self:
+        self.crew = crew
+        return self