refactor: Improve feedback handling code quality

- Add type hints and docstrings
- Enhance error handling in feedback processing
- Standardize message formatting

Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
Devin AI
2025-02-12 20:00:23 +00:00
parent d842529b13
commit e65a6b523a

View File

@@ -555,6 +555,9 @@ class CrewAgentExecutor(CrewAgentExecutorMixin):
Returns: Returns:
AgentFinish: The final answer after processing all feedback iterations AgentFinish: The final answer after processing all feedback iterations
Raises:
FeedbackProcessingError: If feedback processing fails
""" """
try: try:
feedback = initial_feedback feedback = initial_feedback
@@ -576,11 +579,12 @@ class CrewAgentExecutor(CrewAgentExecutorMixin):
return answer return answer
except Exception as e: except Exception as e:
error_msg = f"Failed to process feedback: {str(e)}"
self._printer.print( self._printer.print(
content=f"Error processing feedback: {str(e)}", content=error_msg,
color="red" color="red"
) )
raise raise FeedbackProcessingError(error_msg, original_error=e)
def _get_llm_feedback_response(self, feedback: str) -> Optional[str]: def _get_llm_feedback_response(self, feedback: str) -> Optional[str]:
"""Get LLM classification of whether feedback requires changes.""" """Get LLM classification of whether feedback requires changes."""