From e6100debac0fd88dd54975519485419fdd136bff Mon Sep 17 00:00:00 2001
From: Nicolas Lorin <androw95220@gmail.com>
Date: Thu, 6 Feb 2025 21:19:22 +0100
Subject: [PATCH] agent: improve knowledge naming (#2041)

---
 src/crewai/agent.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/crewai/agent.py b/src/crewai/agent.py
index dec0effd7..a222995c6 100644
--- a/src/crewai/agent.py
+++ b/src/crewai/agent.py
@@ -1,3 +1,4 @@
+import re
 import shutil
 import subprocess
 from typing import Any, Dict, List, Literal, Optional, Union
@@ -153,7 +154,8 @@ class Agent(BaseAgent):
     def _set_knowledge(self):
         try:
             if self.knowledge_sources:
-                knowledge_agent_name = f"{self.role.replace(' ', '_')}"
+                full_pattern = re.compile(r'[^a-zA-Z0-9\-_\r\n]|(\.\.)')
+                knowledge_agent_name = f"{re.sub(full_pattern, '_', self.role)}"
                 if isinstance(self.knowledge_sources, list) and all(
                     isinstance(k, BaseKnowledgeSource) for k in self.knowledge_sources
                 ):