andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-09 08:08:32 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: centralize forced-answer state management

Browse Source 
- Move have_forced_answer state management entirely to _should_force_answer method
- Remove duplicate state setting in _invoke_loop to prevent race conditions
- Maintain consistent state tracking for max iteration handling
- Add clarifying comments about state management responsibility

This change ensures that the forced-answer state is managed in a single
location, preventing potential inconsistencies in state tracking.

Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
Devin AI
2024-12-29 15:27:16 +00:00
parent ea413ae03b
commit df272ed4bd
2 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/crewai/agents/agent_builder/base_agent_executor_mixin.py
View File

@@ -25,8 +25,12 @@ class CrewAgentExecutorMixin:
_printer: Printer = Printer() _printer: Printer = Printer()
def _should_force_answer(self) -> bool: def _should_force_answer(self) -> bool:
"""Determine if a forced answer is required based on iteration count.""" """Determine if a forced answer is required based on iteration count.
return self.iterations >= self.max_iter Also tracks when a forced answer has been triggered."""
if self.iterations >= self.max_iter:
self.have_forced_answer = True
return True
return False
def _create_short_term_memory(self, output) -> None: def _create_short_term_memory(self, output) -> None:
"""Create and save a short-term memory item if conditions are met.""" """Create and save a short-term memory item if conditions are met."""

9
src/crewai/agents/crew_agent_executor.py
View File

@@ -170,6 +170,7 @@ class CrewAgentExecutor(CrewAgentExecutorMixin):
self.step_callback(formatted_answer) self.step_callback(formatted_answer)
if self._should_force_answer(): if self._should_force_answer():
# have_forced_answer is now set in _should_force_answer
if self.have_forced_answer: if self.have_forced_answer:
return AgentFinish( return AgentFinish(
thought="", thought="",
@@ -178,11 +179,9 @@ class CrewAgentExecutor(CrewAgentExecutorMixin):
).format(formatted_answer.text), ).format(formatted_answer.text),
text=formatted_answer.text, text=formatted_answer.text,
) )
else: formatted_answer.text += (
formatted_answer.text += ( f'\n{self._i18n.errors("force_final_answer")}'
f'\n{self._i18n.errors("force_final_answer")}' )
)
self.have_forced_answer = True
self.messages.append( self.messages.append(
self._format_msg(formatted_answer.text, role="assistant") self._format_msg(formatted_answer.text, role="assistant")
) )