andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-09 08:08:32 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Address PR review: Add constants, IPv4 validation, error handling, and expanded tests

Browse Source 
Co-Authored-By: Joe Moura <joao@crewai.com>
This commit is contained in:
Devin AI
2025-03-12 17:05:01 +00:00
committed by Lucas Gomide
parent 12a815e5db
commit df25703cc2
4 changed files with 81 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
tests/utilities/test_string_utils.py
View File

@@ -3,7 +3,12 @@ from typing import Any, Dict, List, Union
import pytest
from crewai.utilities.string_utils import interpolate_only, sanitize_collection_name
from crewai.utilities import is_ipv4_pattern, sanitize_collection_name
from crewai.utilities.string_utils import (
MAX_LENGTH,
MIN_LENGTH,
interpolate_only,
)
class TestInterpolateOnly:
@@ -193,7 +198,7 @@ class TestStringUtils(unittest.TestCase):
"""Test sanitizing a very long collection name."""
long_name = "This is an extremely long role name that will definitely exceed the ChromaDB collection name limit of 63 characters and cause an error when used as a collection name"
sanitized = sanitize_collection_name(long_name)
self.assertLessEqual(len(sanitized), 63)
self.assertLessEqual(len(sanitized), MAX_LENGTH)
self.assertTrue(sanitized[0].isalnum())
self.assertTrue(sanitized[-1].isalnum())
self.assertTrue(all(c.isalnum() or c in ["_", "-"] for c in sanitized))
@@ -210,7 +215,7 @@ class TestStringUtils(unittest.TestCase):
"""Test sanitizing a very short name."""
short_name = "A"
sanitized = sanitize_collection_name(short_name)
self.assertGreaterEqual(len(sanitized), 3)
self.assertGreaterEqual(len(sanitized), MIN_LENGTH)
self.assertTrue(sanitized[0].isalnum())
self.assertTrue(sanitized[-1].isalnum())
@@ -226,6 +231,37 @@ class TestStringUtils(unittest.TestCase):
sanitized = sanitize_collection_name(None)
self.assertEqual(sanitized, "default_collection")
def test_sanitize_collection_name_ipv4_pattern(self):
"""Test sanitizing an IPv4 address."""
ipv4 = "192.168.1.1"
sanitized = sanitize_collection_name(ipv4)
self.assertTrue(sanitized.startswith("ip_"))
self.assertTrue(sanitized[0].isalnum())
self.assertTrue(sanitized[-1].isalnum())
self.assertTrue(all(c.isalnum() or c in ["_", "-"] for c in sanitized))
def test_is_ipv4_pattern(self):
"""Test IPv4 pattern detection."""
self.assertTrue(is_ipv4_pattern("192.168.1.1"))
self.assertFalse(is_ipv4_pattern("not.an.ip.address"))
def test_sanitize_collection_name_properties(self):
"""Test that sanitized collection names always meet ChromaDB requirements."""
test_cases = [
"A" * 100, # Very long name
"_start_with_underscore",
"end_with_underscore_",
"contains@special#characters",
"192.168.1.1", # IPv4 address
"a" * 2, # Too short
]
for test_case in test_cases:
sanitized = sanitize_collection_name(test_case)
self.assertGreaterEqual(len(sanitized), MIN_LENGTH)
self.assertLessEqual(len(sanitized), MAX_LENGTH)
self.assertTrue(sanitized[0].isalnum())
self.assertTrue(sanitized[-1].isalnum())
if __name__ == "__main__":
unittest.main()