From de742c827d0fc5749193a40536f0e5e30b72810c Mon Sep 17 00:00:00 2001 From: Lorenze Jay Date: Tue, 19 Nov 2024 11:27:01 -0800 Subject: [PATCH] improvements --- src/crewai/knowledge/knowledge.py | 2 +- src/crewai/knowledge/source/base_knowledge_source.py | 3 +-- .../knowledge/source/text_file_knowledge_source.py | 9 +++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/crewai/knowledge/knowledge.py b/src/crewai/knowledge/knowledge.py index 5707bc8ad..81a4cb4a3 100644 --- a/src/crewai/knowledge/knowledge.py +++ b/src/crewai/knowledge/knowledge.py @@ -30,7 +30,7 @@ class Knowledge(BaseModel): Logger(verbose=True).log( "warning", f"Failed to init knowledge: {e}", - color="red", + color="yellow", ) def query( diff --git a/src/crewai/knowledge/source/base_knowledge_source.py b/src/crewai/knowledge/source/base_knowledge_source.py index a566bad5c..a2a79cf79 100644 --- a/src/crewai/knowledge/source/base_knowledge_source.py +++ b/src/crewai/knowledge/source/base_knowledge_source.py @@ -1,11 +1,10 @@ from abc import ABC, abstractmethod -from typing import List +from typing import List, Dict, Any import numpy as np from pydantic import BaseModel, ConfigDict, Field from crewai.knowledge.storage.knowledge_storage import KnowledgeStorage -from typing import Dict, Any class BaseKnowledgeSource(BaseModel, ABC): diff --git a/src/crewai/knowledge/source/text_file_knowledge_source.py b/src/crewai/knowledge/source/text_file_knowledge_source.py index 32c6c6534..3165493ad 100644 --- a/src/crewai/knowledge/source/text_file_knowledge_source.py +++ b/src/crewai/knowledge/source/text_file_knowledge_source.py @@ -1,4 +1,5 @@ -from typing import List +from typing import Dict, List +from pathlib import Path from crewai.knowledge.source.base_file_knowledge_source import BaseFileKnowledgeSource @@ -6,11 +7,11 @@ from crewai.knowledge.source.base_file_knowledge_source import BaseFileKnowledge class TextFileKnowledgeSource(BaseFileKnowledgeSource): """A knowledge source that stores and queries text file content using embeddings.""" - def load_content(self) -> str: + def load_content(self) -> Dict[Path, str]: """Load and preprocess text file content.""" - super().load_content() # Validate the file path + super().load_content() with self.file_path.open("r", encoding="utf-8") as f: - return f.read() + return f.read() # type: ignore def add(self) -> None: """