From d5427fb019f1a12961d007b761d703a58c2ca0fe Mon Sep 17 00:00:00 2001 From: Shahar Yair Date: Fri, 11 Oct 2024 01:15:34 +0300 Subject: [PATCH] Fix/logger - fix #1412 (#1413) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * improved logger * log file looks better * better lines written to log file --------- Co-authored-by: João Moura --- src/crewai/crew.py | 4 ++-- src/crewai/utilities/file_handler.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/crewai/crew.py b/src/crewai/crew.py index 422f64248..7d936a8ad 100644 --- a/src/crewai/crew.py +++ b/src/crewai/crew.py @@ -771,7 +771,7 @@ class Crew(BaseModel): def _log_task_start(self, task: Task, role: str = "None"): if self.output_log_file: - self._file_handler.log(agent=role, task=task.description, status="started") + self._file_handler.log(task_name=task.name, task=task.description, agent=role, status="started") def _update_manager_tools(self, task: Task): if self.manager_agent: @@ -793,7 +793,7 @@ class Crew(BaseModel): def _process_task_result(self, task: Task, output: TaskOutput) -> None: role = task.agent.role if task.agent is not None else "None" if self.output_log_file: - self._file_handler.log(agent=role, task=output, status="completed") + self._file_handler.log(task_name=task.name, task=task.description, agent=role, status="completed", output=output.raw) def _create_crew_output(self, task_outputs: List[TaskOutput]) -> CrewOutput: if len(task_outputs) != 1: diff --git a/src/crewai/utilities/file_handler.py b/src/crewai/utilities/file_handler.py index 1125cae4e..091bd930a 100644 --- a/src/crewai/utilities/file_handler.py +++ b/src/crewai/utilities/file_handler.py @@ -16,7 +16,7 @@ class FileHandler: def log(self, **kwargs): now = datetime.now().strftime("%Y-%m-%d %H:%M:%S") - message = f"{now}: ".join([f"{key}={value}" for key, value in kwargs.items()]) + message = f"{now}: " + ", ".join([f"{key}=\"{value}\"" for key, value in kwargs.items()]) + "\n" with open(self._path, "a", encoding="utf-8") as file: file.write(message + "\n")