andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-10 00:28:31 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: Resolve test failures in HTTP MCP support tests

Browse Source 
1. Fragment filtering test: Added proper assertion for MCPToolWrapper call
   and verified the mock tool is returned in the result list.

2. Logger patching tests: Changed from patching instance method to patching
   class method to avoid Pydantic's __delattr__ restriction. This prevents
   AttributeError when the patch context manager tries to restore the
   original attribute.

Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-11-10 15:22:50 +00:00
parent 6063677c01
commit d25bea781d
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
lib/crewai/tests/mcp/test_http_mcp_support.py
View File

@@ -149,13 +149,17 @@ class TestHTTPMCPFragmentFiltering:
with patch.object(agent, '_get_mcp_tool_schemas', return_value=mock_schemas): with patch.object(agent, '_get_mcp_tool_schemas', return_value=mock_schemas):
with patch('crewai.tools.mcp_tool_wrapper.MCPToolWrapper') as mock_wrapper_class: with patch('crewai.tools.mcp_tool_wrapper.MCPToolWrapper') as mock_wrapper_class:
mock_wrapper_class.return_value = MagicMock() mock_tool = MagicMock()
mock_wrapper_class.return_value = mock_tool
result = agent._get_external_mcp_tools("http://localhost:7365/mcp#specific_tool") result = agent._get_external_mcp_tools("http://localhost:7365/mcp#specific_tool")
assert len(result) == 1 mock_wrapper_class.assert_called_once()
call_args = mock_wrapper_class.call_args call_args = mock_wrapper_class.call_args
assert call_args.kwargs['tool_name'] == 'specific_tool' assert call_args.kwargs['tool_name'] == 'specific_tool'
assert len(result) == 1
assert result[0] == mock_tool
class TestHTTPMCPWarningLog: class TestHTTPMCPWarningLog:
@@ -171,13 +175,14 @@ class TestHTTPMCPWarningLog:
) )
log_calls = [] log_calls = []
original_log = agent._logger.log logger_class = type(agent._logger)
original_log = logger_class.log
def mock_log(level, message): def mock_log(self, level, message):
log_calls.append((level, message)) log_calls.append((level, message))
return original_log(level, message) return original_log(self, level, message)
with patch.object(agent._logger, 'log', side_effect=mock_log): with patch.object(logger_class, 'log', new=mock_log):
with patch.object(agent, '_get_mcp_tool_schemas', return_value={}): with patch.object(agent, '_get_mcp_tool_schemas', return_value={}):
agent._get_external_mcp_tools("http://localhost:7365/mcp") agent._get_external_mcp_tools("http://localhost:7365/mcp")
@@ -196,13 +201,14 @@ class TestHTTPMCPWarningLog:
) )
log_calls = [] log_calls = []
original_log = agent._logger.log logger_class = type(agent._logger)
original_log = logger_class.log
def mock_log(level, message): def mock_log(self, level, message):
log_calls.append((level, message)) log_calls.append((level, message))
return original_log(level, message) return original_log(self, level, message)
with patch.object(agent._logger, 'log', side_effect=mock_log): with patch.object(logger_class, 'log', new=mock_log):
with patch.object(agent, '_get_mcp_tool_schemas', return_value={}): with patch.object(agent, '_get_mcp_tool_schemas', return_value={}):
agent._get_external_mcp_tools("https://api.example.com/mcp") agent._get_external_mcp_tools("https://api.example.com/mcp")