fix: fix track of new test cases

This commit is contained in:
Lucas Gomide
2025-07-10 20:26:40 -03:00
parent ccea8870d7
commit cf91084f21

View File

@@ -108,9 +108,9 @@ class ExperimentResults:
baseline_lookup = {} baseline_lookup = {}
for result in baseline_results: for result in baseline_results:
test_id = result.get("test_id") test_identifier = result.get("identifier")
if test_id: if test_identifier:
baseline_lookup[test_id] = result baseline_lookup[test_identifier] = result
improved = [] improved = []
regressed = [] regressed = []
@@ -118,27 +118,27 @@ class ExperimentResults:
new_tests = [] new_tests = []
for result in self.results: for result in self.results:
test_id = result.identifier test_identifier = result.identifier
if not test_id or test_id not in baseline_lookup: if not test_identifier or test_identifier not in baseline_lookup:
new_tests.append(test_id) new_tests.append(test_identifier)
continue continue
baseline_result = baseline_lookup[test_id] baseline_result = baseline_lookup[test_identifier]
baseline_passed = baseline_result.get("passed", False) baseline_passed = baseline_result.get("passed", False)
if result.passed and not baseline_passed: if result.passed and not baseline_passed:
improved.append((test_id, result.score, baseline_result.get("score", 0))) improved.append((test_identifier, result.score, baseline_result.get("score", 0)))
elif not result.passed and baseline_passed: elif not result.passed and baseline_passed:
regressed.append((test_id, result.score, baseline_result.get("score", 0))) regressed.append((test_identifier, result.score, baseline_result.get("score", 0)))
else: else:
unchanged.append(test_id) unchanged.append(test_identifier)
missing_tests = [] missing_tests = []
current_test_ids = {result.identifier for result in self.results} current_test_identifiers = {result.identifier for result in self.results}
for result in baseline_results: for result in baseline_results:
test_id = result.get("identifier") test_identifier = result.get("identifier")
if test_id and test_id not in current_test_ids: if test_identifier and test_identifier not in current_test_identifiers:
missing_tests.append(test_id) missing_tests.append(test_identifier)
return { return {
"improved": improved, "improved": improved,
@@ -170,7 +170,7 @@ class ExperimentResults:
improved = comparison.get("improved", []) improved = comparison.get("improved", [])
if improved: if improved:
details = ", ".join([f"{test_id}" for test_id, _, _ in improved[:3]]) details = ", ".join([f"{test_identifier}" for test_identifier, _, _ in improved[:3]])
if len(improved) > 3: if len(improved) > 3:
details += f" and {len(improved) - 3} more" details += f" and {len(improved) - 3} more"
table.add_row("✅ Improved", str(len(improved)), details) table.add_row("✅ Improved", str(len(improved)), details)
@@ -179,7 +179,7 @@ class ExperimentResults:
regressed = comparison.get("regressed", []) regressed = comparison.get("regressed", [])
if regressed: if regressed:
details = ", ".join([f"{test_id}" for test_id, _, _ in regressed[:3]]) details = ", ".join([f"{test_identifier}" for test_identifier, _, _ in regressed[:3]])
if len(regressed) > 3: if len(regressed) > 3:
details += f" and {len(regressed) - 3} more" details += f" and {len(regressed) - 3} more"
table.add_row("❌ Regressed", str(len(regressed)), details, style="red") table.add_row("❌ Regressed", str(len(regressed)), details, style="red")