From b53c08812df6db28ed29c25438f2905cecbcea1f Mon Sep 17 00:00:00 2001 From: Greyson LaLonde Date: Wed, 25 Mar 2026 06:40:25 +0800 Subject: [PATCH] fix: use None check instead of isinstance for memory in human feedback learn --- lib/crewai/src/crewai/flow/human_feedback.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/crewai/src/crewai/flow/human_feedback.py b/lib/crewai/src/crewai/flow/human_feedback.py index 7add43f7a..9bace438e 100644 --- a/lib/crewai/src/crewai/flow/human_feedback.py +++ b/lib/crewai/src/crewai/flow/human_feedback.py @@ -374,10 +374,8 @@ def human_feedback( ) -> Any: """Recall past HITL lessons and use LLM to pre-review the output.""" try: - from crewai.memory.unified_memory import Memory - mem = flow_instance.memory - if not isinstance(mem, Memory): + if mem is None: return method_output query = f"human feedback lessons for {func.__name__}: {method_output!s}" matches = mem.recall(query, source=learn_source) @@ -412,10 +410,8 @@ def human_feedback( ) -> None: """Extract generalizable lessons from output + feedback, store in memory.""" try: - from crewai.memory.unified_memory import Memory - mem = flow_instance.memory - if not isinstance(mem, Memory): + if mem is None: return llm_inst = _resolve_llm_instance() prompt = _get_hitl_prompt("hitl_distill_user").format( @@ -448,7 +444,7 @@ def human_feedback( ] if lessons: - mem.remember_many(lessons, source=learn_source) + mem.remember_many(lessons, source=learn_source) # type: ignore[union-attr] except Exception: # noqa: S110 pass # non-critical: don't fail the flow because lesson storage failed