andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-09 08:08:32 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix: resolve lint issue in Watson embedding name test

Browse Source 
- Change type comparison from == to 'is' to satisfy Ruff E721 rule
- All lint checks now pass locally

Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-09-26 10:56:48 +00:00
parent 9578b60734
commit b3e1f28c2b
1 changed files with 19 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
tests/rag/embeddings/test_watson_embedding_name.py
View File

@@ -1,9 +1,11 @@
"""Tests for Watson embedding function name method.""" """Tests for Watson embedding function name method."""
import pytest
from unittest.mock import patch, MagicMock
from crewai.rag.embeddings.providers.ibm.embedding_callable import WatsonEmbeddingFunction import pytest
from crewai.rag.embeddings.providers.ibm.embedding_callable import (
WatsonEmbeddingFunction,
)
class TestWatsonEmbeddingName: class TestWatsonEmbeddingName:
@@ -12,7 +14,7 @@ class TestWatsonEmbeddingName:
def test_watson_embedding_function_has_name_method(self): def test_watson_embedding_function_has_name_method(self):
"""Test that WatsonEmbeddingFunction has a name method.""" """Test that WatsonEmbeddingFunction has a name method."""
assert hasattr(WatsonEmbeddingFunction, 'name') assert hasattr(WatsonEmbeddingFunction, 'name')
assert callable(getattr(WatsonEmbeddingFunction, 'name')) assert callable(WatsonEmbeddingFunction.name)
def test_watson_embedding_function_name_returns_watson(self): def test_watson_embedding_function_name_returns_watson(self):
"""Test that the name method returns 'watson'.""" """Test that the name method returns 'watson'."""
@@ -31,9 +33,9 @@ class TestWatsonEmbeddingName:
"api_key": "test-key", "api_key": "test-key",
"url": "https://test.com" "url": "https://test.com"
} }
watson_func = WatsonEmbeddingFunction(**config) watson_func = WatsonEmbeddingFunction(**config)
try: try:
name = watson_func.name() name = watson_func.name()
assert name == "watson" assert name == "watson"
@@ -43,33 +45,33 @@ class TestWatsonEmbeddingName:
def test_watson_embedding_function_name_method_signature(self): def test_watson_embedding_function_name_method_signature(self):
"""Test that the name method has the correct signature.""" """Test that the name method has the correct signature."""
import inspect import inspect
name_method = getattr(WatsonEmbeddingFunction, 'name') name_method = WatsonEmbeddingFunction.name
assert isinstance(inspect.getattr_static(WatsonEmbeddingFunction, 'name'), staticmethod) assert isinstance(inspect.getattr_static(WatsonEmbeddingFunction, 'name'), staticmethod)
sig = inspect.signature(name_method) sig = inspect.signature(name_method)
if sig.return_annotation != inspect.Signature.empty: if sig.return_annotation != inspect.Signature.empty:
assert sig.return_annotation == str assert sig.return_annotation is str
def test_watson_embedding_function_reproduces_original_issue(self): def test_watson_embedding_function_reproduces_original_issue(self):
"""Test that reproduces the original issue scenario from #3597.""" """Test that reproduces the original issue scenario from #3597."""
config = { config = {
"model_id": "ibm/slate-125m-english-rtrvr", "model_id": "ibm/slate-125m-english-rtrvr",
"api_key": "test-key", "api_key": "test-key",
"url": "https://us-south.ml.cloud.ibm.com", "url": "https://us-south.ml.cloud.ibm.com",
"project_id": "test-project" "project_id": "test-project"
} }
watson_func = WatsonEmbeddingFunction(**config) watson_func = WatsonEmbeddingFunction(**config)
name = watson_func.name() name = watson_func.name()
assert name == "watson" assert name == "watson"
assert isinstance(name, str) assert isinstance(name, str)
class_name = WatsonEmbeddingFunction.name() class_name = WatsonEmbeddingFunction.name()
assert class_name == "watson" assert class_name == "watson"
assert class_name == name assert class_name == name