mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-01-10 00:28:31 +00:00
fix: resolve lint issue in Watson embedding name test
- Change type comparison from == to 'is' to satisfy Ruff E721 rule - All lint checks now pass locally Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
@@ -1,9 +1,11 @@
|
|||||||
"""Tests for Watson embedding function name method."""
|
"""Tests for Watson embedding function name method."""
|
||||||
|
|
||||||
import pytest
|
|
||||||
from unittest.mock import patch, MagicMock
|
|
||||||
|
|
||||||
from crewai.rag.embeddings.providers.ibm.embedding_callable import WatsonEmbeddingFunction
|
import pytest
|
||||||
|
|
||||||
|
from crewai.rag.embeddings.providers.ibm.embedding_callable import (
|
||||||
|
WatsonEmbeddingFunction,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
class TestWatsonEmbeddingName:
|
class TestWatsonEmbeddingName:
|
||||||
@@ -12,7 +14,7 @@ class TestWatsonEmbeddingName:
|
|||||||
def test_watson_embedding_function_has_name_method(self):
|
def test_watson_embedding_function_has_name_method(self):
|
||||||
"""Test that WatsonEmbeddingFunction has a name method."""
|
"""Test that WatsonEmbeddingFunction has a name method."""
|
||||||
assert hasattr(WatsonEmbeddingFunction, 'name')
|
assert hasattr(WatsonEmbeddingFunction, 'name')
|
||||||
assert callable(getattr(WatsonEmbeddingFunction, 'name'))
|
assert callable(WatsonEmbeddingFunction.name)
|
||||||
|
|
||||||
def test_watson_embedding_function_name_returns_watson(self):
|
def test_watson_embedding_function_name_returns_watson(self):
|
||||||
"""Test that the name method returns 'watson'."""
|
"""Test that the name method returns 'watson'."""
|
||||||
@@ -44,13 +46,13 @@ class TestWatsonEmbeddingName:
|
|||||||
"""Test that the name method has the correct signature."""
|
"""Test that the name method has the correct signature."""
|
||||||
import inspect
|
import inspect
|
||||||
|
|
||||||
name_method = getattr(WatsonEmbeddingFunction, 'name')
|
name_method = WatsonEmbeddingFunction.name
|
||||||
|
|
||||||
assert isinstance(inspect.getattr_static(WatsonEmbeddingFunction, 'name'), staticmethod)
|
assert isinstance(inspect.getattr_static(WatsonEmbeddingFunction, 'name'), staticmethod)
|
||||||
|
|
||||||
sig = inspect.signature(name_method)
|
sig = inspect.signature(name_method)
|
||||||
if sig.return_annotation != inspect.Signature.empty:
|
if sig.return_annotation != inspect.Signature.empty:
|
||||||
assert sig.return_annotation == str
|
assert sig.return_annotation is str
|
||||||
|
|
||||||
def test_watson_embedding_function_reproduces_original_issue(self):
|
def test_watson_embedding_function_reproduces_original_issue(self):
|
||||||
"""Test that reproduces the original issue scenario from #3597."""
|
"""Test that reproduces the original issue scenario from #3597."""
|
||||||
|
|||||||
Reference in New Issue
Block a user