From aaccbe5d628b0b0f0995f994a88c50cb48871bdf Mon Sep 17 00:00:00 2001 From: Joao Moura Date: Mon, 13 Jul 2026 21:06:54 -0700 Subject: [PATCH] fix(typing): drop unused type-ignores now that json-repair ships stubs json-repair >= 0.60 is py.typed, so the import-untyped ignores fail CI with unused-ignore. Also read pyproject with explicit UTF-8 in the pin test (review feedback). Co-Authored-By: Claude Fable 5 --- lib/crewai/src/crewai/agents/parser.py | 2 +- lib/crewai/src/crewai/tools/tool_usage.py | 2 +- lib/crewai/tests/security/test_dependency_pins.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/crewai/src/crewai/agents/parser.py b/lib/crewai/src/crewai/agents/parser.py index 61c792271..0ee1cff42 100644 --- a/lib/crewai/src/crewai/agents/parser.py +++ b/lib/crewai/src/crewai/agents/parser.py @@ -8,7 +8,7 @@ AgentAction or AgentFinish objects. from dataclasses import dataclass import json -from json_repair import repair_json # type: ignore[import-untyped] +from json_repair import repair_json from pydantic import BaseModel from crewai.agents.constants import ( diff --git a/lib/crewai/src/crewai/tools/tool_usage.py b/lib/crewai/src/crewai/tools/tool_usage.py index 4a973add9..764f82bd9 100644 --- a/lib/crewai/src/crewai/tools/tool_usage.py +++ b/lib/crewai/src/crewai/tools/tool_usage.py @@ -11,7 +11,7 @@ from typing import TYPE_CHECKING, Any, Literal from crewai_core.printer import PRINTER import json5 -from json_repair import repair_json # type: ignore[import-untyped] +from json_repair import repair_json from crewai.events.event_bus import crewai_event_bus from crewai.events.types.tool_usage_events import ( diff --git a/lib/crewai/tests/security/test_dependency_pins.py b/lib/crewai/tests/security/test_dependency_pins.py index 7157c6a05..ed0fb6d70 100644 --- a/lib/crewai/tests/security/test_dependency_pins.py +++ b/lib/crewai/tests/security/test_dependency_pins.py @@ -17,7 +17,7 @@ PYPROJECT_PATH = Path(__file__).parents[2] / "pyproject.toml" def _get_requirement(name: str) -> Requirement: - data = tomllib.loads(PYPROJECT_PATH.read_text()) + data = tomllib.loads(PYPROJECT_PATH.read_text(encoding="utf-8")) for spec in data["project"]["dependencies"]: requirement = Requirement(spec) if requirement.name == name: