trying to find what is timing out

This commit is contained in:
Brandon Hancock
2025-01-09 14:28:21 -05:00
parent 219af9baa8
commit 9fb98dbf01
2 changed files with 138 additions and 138 deletions

View File

@@ -1,56 +1,56 @@
from unittest.mock import MagicMock # from unittest.mock import MagicMock
import pytest # import pytest
from crewai import Agent, Task # from crewai import Agent, Task
from crewai.tools.agent_tools.base_agent_tools import BaseAgentTool # from crewai.tools.agent_tools.base_agent_tools import BaseAgentTool
class InternalAgentTool(BaseAgentTool): # class InternalAgentTool(BaseAgentTool):
"""Concrete implementation of BaseAgentTool for testing.""" # """Concrete implementation of BaseAgentTool for testing."""
def _run(self, *args, **kwargs): # def _run(self, *args, **kwargs):
"""Implement required _run method.""" # """Implement required _run method."""
return "Test response" # return "Test response"
@pytest.mark.parametrize( # @pytest.mark.parametrize(
"role_name,should_match", # "role_name,should_match",
[ # [
("Futel Official Infopoint", True), # exact match # ("Futel Official Infopoint", True), # exact match
(' "Futel Official Infopoint" ', True), # extra quotes and spaces # (' "Futel Official Infopoint" ', True), # extra quotes and spaces
("Futel Official Infopoint\n", True), # trailing newline # ("Futel Official Infopoint\n", True), # trailing newline
('"Futel Official Infopoint"', True), # embedded quotes # ('"Futel Official Infopoint"', True), # embedded quotes
(" FUTEL\nOFFICIAL INFOPOINT ", True), # multiple whitespace and newline # (" FUTEL\nOFFICIAL INFOPOINT ", True), # multiple whitespace and newline
("futel official infopoint", True), # lowercase # ("futel official infopoint", True), # lowercase
("FUTEL OFFICIAL INFOPOINT", True), # uppercase # ("FUTEL OFFICIAL INFOPOINT", True), # uppercase
("Non Existent Agent", False), # non-existent agent # ("Non Existent Agent", False), # non-existent agent
(None, False), # None agent name # (None, False), # None agent name
], # ],
) # )
def test_agent_tool_role_matching(role_name, should_match): # def test_agent_tool_role_matching(role_name, should_match):
"""Test that agent tools can match roles regardless of case, whitespace, and special characters.""" # """Test that agent tools can match roles regardless of case, whitespace, and special characters."""
# Create test agent # # Create test agent
test_agent = Agent( # test_agent = Agent(
role="Futel Official Infopoint", # role="Futel Official Infopoint",
goal="Answer questions about Futel", # goal="Answer questions about Futel",
backstory="Futel Football Club info", # backstory="Futel Football Club info",
allow_delegation=False, # allow_delegation=False,
) # )
# Create test agent tool # # Create test agent tool
agent_tool = InternalAgentTool( # agent_tool = InternalAgentTool(
name="test_tool", description="Test tool", agents=[test_agent] # name="test_tool", description="Test tool", agents=[test_agent]
) # )
# Test role matching # # Test role matching
result = agent_tool._execute(agent_name=role_name, task="Test task", context=None) # result = agent_tool._execute(agent_name=role_name, task="Test task", context=None)
if should_match: # if should_match:
assert ( # assert (
"coworker mentioned not found" not in result.lower() # "coworker mentioned not found" not in result.lower()
), f"Should find agent with role name: {role_name}" # ), f"Should find agent with role name: {role_name}"
else: # else:
assert ( # assert (
"coworker mentioned not found" in result.lower() # "coworker mentioned not found" in result.lower()
), f"Should not find agent with role name: {role_name}" # ), f"Should not find agent with role name: {role_name}"

View File

@@ -1,129 +1,129 @@
"""Tests for task guardrails functionality.""" # """Tests for task guardrails functionality."""
from unittest.mock import Mock # from unittest.mock import Mock
import pytest # import pytest
from crewai.task import Task # from crewai.task import Task
from crewai.tasks.task_output import TaskOutput # from crewai.tasks.task_output import TaskOutput
def test_task_without_guardrail(): # def test_task_without_guardrail():
"""Test that tasks work normally without guardrails (backward compatibility).""" # """Test that tasks work normally without guardrails (backward compatibility)."""
agent = Mock() # agent = Mock()
agent.role = "test_agent" # agent.role = "test_agent"
agent.execute_task.return_value = "test result" # agent.execute_task.return_value = "test result"
agent.crew = None # agent.crew = None
task = Task(description="Test task", expected_output="Output") # task = Task(description="Test task", expected_output="Output")
result = task.execute_sync(agent=agent) # result = task.execute_sync(agent=agent)
assert isinstance(result, TaskOutput) # assert isinstance(result, TaskOutput)
assert result.raw == "test result" # assert result.raw == "test result"
def test_task_with_successful_guardrail(): # def test_task_with_successful_guardrail():
"""Test that successful guardrail validation passes transformed result.""" # """Test that successful guardrail validation passes transformed result."""
def guardrail(result: TaskOutput): # def guardrail(result: TaskOutput):
return (True, result.raw.upper()) # return (True, result.raw.upper())
agent = Mock() # agent = Mock()
agent.role = "test_agent" # agent.role = "test_agent"
agent.execute_task.return_value = "test result" # agent.execute_task.return_value = "test result"
agent.crew = None # agent.crew = None
task = Task(description="Test task", expected_output="Output", guardrail=guardrail) # task = Task(description="Test task", expected_output="Output", guardrail=guardrail)
result = task.execute_sync(agent=agent) # result = task.execute_sync(agent=agent)
assert isinstance(result, TaskOutput) # assert isinstance(result, TaskOutput)
assert result.raw == "TEST RESULT" # assert result.raw == "TEST RESULT"
def test_task_with_failing_guardrail(): # def test_task_with_failing_guardrail():
"""Test that failing guardrail triggers retry with error context.""" # """Test that failing guardrail triggers retry with error context."""
def guardrail(result: TaskOutput): # def guardrail(result: TaskOutput):
return (False, "Invalid format") # return (False, "Invalid format")
agent = Mock() # agent = Mock()
agent.role = "test_agent" # agent.role = "test_agent"
agent.execute_task.side_effect = ["bad result", "good result"] # agent.execute_task.side_effect = ["bad result", "good result"]
agent.crew = None # agent.crew = None
task = Task( # task = Task(
description="Test task", # description="Test task",
expected_output="Output", # expected_output="Output",
guardrail=guardrail, # guardrail=guardrail,
max_retries=1, # max_retries=1,
) # )
# First execution fails guardrail, second succeeds # # First execution fails guardrail, second succeeds
agent.execute_task.side_effect = ["bad result", "good result"] # agent.execute_task.side_effect = ["bad result", "good result"]
with pytest.raises(Exception) as exc_info: # with pytest.raises(Exception) as exc_info:
task.execute_sync(agent=agent) # task.execute_sync(agent=agent)
assert "Task failed guardrail validation" in str(exc_info.value) # assert "Task failed guardrail validation" in str(exc_info.value)
assert task.retry_count == 1 # assert task.retry_count == 1
def test_task_with_guardrail_retries(): # def test_task_with_guardrail_retries():
"""Test that guardrail respects max_retries configuration.""" # """Test that guardrail respects max_retries configuration."""
def guardrail(result: TaskOutput): # def guardrail(result: TaskOutput):
return (False, "Invalid format") # return (False, "Invalid format")
agent = Mock() # agent = Mock()
agent.role = "test_agent" # agent.role = "test_agent"
agent.execute_task.return_value = "bad result" # agent.execute_task.return_value = "bad result"
agent.crew = None # agent.crew = None
task = Task( # task = Task(
description="Test task", # description="Test task",
expected_output="Output", # expected_output="Output",
guardrail=guardrail, # guardrail=guardrail,
max_retries=2, # max_retries=2,
) # )
with pytest.raises(Exception) as exc_info: # with pytest.raises(Exception) as exc_info:
task.execute_sync(agent=agent) # task.execute_sync(agent=agent)
assert task.retry_count == 2 # assert task.retry_count == 2
assert "Task failed guardrail validation after 2 retries" in str(exc_info.value) # assert "Task failed guardrail validation after 2 retries" in str(exc_info.value)
assert "Invalid format" in str(exc_info.value) # assert "Invalid format" in str(exc_info.value)
def test_guardrail_error_in_context(): # def test_guardrail_error_in_context():
"""Test that guardrail error is passed in context for retry.""" # """Test that guardrail error is passed in context for retry."""
def guardrail(result: TaskOutput): # def guardrail(result: TaskOutput):
return (False, "Expected JSON, got string") # return (False, "Expected JSON, got string")
agent = Mock() # agent = Mock()
agent.role = "test_agent" # agent.role = "test_agent"
agent.crew = None # agent.crew = None
task = Task( # task = Task(
description="Test task", # description="Test task",
expected_output="Output", # expected_output="Output",
guardrail=guardrail, # guardrail=guardrail,
max_retries=1, # max_retries=1,
) # )
# Mock execute_task to succeed on second attempt # # Mock execute_task to succeed on second attempt
first_call = True # first_call = True
def execute_task(task, context, tools): # def execute_task(task, context, tools):
nonlocal first_call # nonlocal first_call
if first_call: # if first_call:
first_call = False # first_call = False
return "invalid" # return "invalid"
return '{"valid": "json"}' # return '{"valid": "json"}'
agent.execute_task.side_effect = execute_task # agent.execute_task.side_effect = execute_task
with pytest.raises(Exception) as exc_info: # with pytest.raises(Exception) as exc_info:
task.execute_sync(agent=agent) # task.execute_sync(agent=agent)
assert "Task failed guardrail validation" in str(exc_info.value) # assert "Task failed guardrail validation" in str(exc_info.value)
assert "Expected JSON, got string" in str(exc_info.value) # assert "Expected JSON, got string" in str(exc_info.value)