From 96b6d91084d8303fd54dadbac09baf9fb45373c5 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Sat, 15 Feb 2025 16:06:09 +0000 Subject: [PATCH] fix: Use uppercase MODEL env var for Azure provider - Update Azure provider config to use uppercase MODEL env var - Add test case to verify MODEL env var handling - Fixes #2139 Co-Authored-By: Joe Moura --- src/crewai/cli/constants.py | 4 ++-- tests/agent_test.py | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/crewai/cli/constants.py b/src/crewai/cli/constants.py index b97b4f208..081ca74c6 100644 --- a/src/crewai/cli/constants.py +++ b/src/crewai/cli/constants.py @@ -66,7 +66,7 @@ ENV_VARS = { "azure": [ { "prompt": "Enter your Azure deployment name (must start with 'azure/')", - "key_name": "model", + "key_name": "MODEL", }, { "prompt": "Enter your AZURE API key (press Enter to skip)", @@ -84,7 +84,7 @@ ENV_VARS = { "cerebras": [ { "prompt": "Enter your Cerebras model name (must start with 'cerebras/')", - "key_name": "model", + "key_name": "MODEL", }, { "prompt": "Enter your Cerebras API version (press Enter to skip)", diff --git a/tests/agent_test.py b/tests/agent_test.py index e67a7454a..bc1c87bce 100644 --- a/tests/agent_test.py +++ b/tests/agent_test.py @@ -21,6 +21,22 @@ from crewai.utilities import RPMController from crewai.utilities.events import Emitter +def test_agent_azure_model_env_var(): + # Store original environment variables + original_model = os.environ.get("MODEL") + + # Test with uppercase MODEL + os.environ["MODEL"] = "azure/test-model" + agent = Agent(role="test role", goal="test goal", backstory="test backstory") + assert agent.llm.model == "azure/test-model" + + # Clean up environment variables + if original_model: + os.environ["MODEL"] = original_model + else: + del os.environ["MODEL"] + + def test_agent_llm_creation_with_env_vars(): # Store original environment variables original_api_key = os.environ.get("OPENAI_API_KEY")