andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-10 08:38:30 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Fix CI failures: remove unused variable, update error handling test for structured logging, add test isolation

Browse Source 
Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
Devin AI
2025-06-11 02:38:50 +00:00
parent 83f4493ff0
commit 918971994a
1 changed files with 40 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/utilities/events/test_crewai_event_bus.py
View File

@@ -38,7 +38,8 @@ def test_wildcard_event_handler():
mock_handler.assert_called_once_with("source_object", event)
def test_event_bus_error_handling(capfd):
def test_event_bus_error_handling(caplog):
with crewai_event_bus.scoped_handlers():
@crewai_event_bus.on(BaseEvent)
def broken_handler(source, event):
raise ValueError("Simulated handler failure")
@@ -46,9 +47,8 @@ def test_event_bus_error_handling(capfd):
event = TestEvent(type="test_event")
crewai_event_bus.emit("source_object", event)
out, err = capfd.readouterr()
assert "Simulated handler failure" in out
assert "Handler 'broken_handler' failed" in out
assert any("Handler execution failed" in record.message for record in caplog.records)
assert any("Simulated handler failure" in str(record.exc_info) if record.exc_info else False for record in caplog.records)
def test_concurrent_event_emission_thread_safety():
@@ -165,6 +165,7 @@ def test_thread_safety_with_mixed_operations():
def test_handler_deregistration_thread_safety():
"""Test that concurrent handler deregistration is thread-safe"""
with crewai_event_bus.scoped_handlers():
handlers_to_remove = []
for i in range(10):
@@ -174,8 +175,6 @@ def test_handler_deregistration_thread_safety():
crewai_event_bus.register_handler(TestEvent, handler)
handlers_to_remove.append(handler)
initial_count = len(crewai_event_bus._handlers.get(TestEvent, []))
def deregister_handler(handler):
"""Deregister a handler from a specific thread"""
return crewai_event_bus.deregister_handler(TestEvent, handler)
@@ -197,6 +196,7 @@ def test_handler_deregistration_thread_safety():
def test_deregister_nonexistent_handler():
"""Test deregistering a handler that doesn't exist"""
with crewai_event_bus.scoped_handlers():
def dummy_handler(source, event):
pass