Brandon/eng 266 conversation crew v1 (#1843)

* worked on foundation for new conversational crews. Now going to work on chatting.

* core loop should be working and ready for testing.

* high level chat working

* its alive!!

* Added in Joaos feedback to steer crew chats back towards the purpose of the crew

* properly return tool call result

* accessing crew directly instead of through uv commands

* everything is working for conversation now

* Fix linting

* fix llm_utils.py and other type errors

* fix more type errors

* fixing type error

* More fixing of types

* fix failing tests

* Fix more failing tests

* adding tests. cleaing up pr.

* improve

* drop old functions

* improve type hintings

tests/utilities/test_llm_utils.py

@@ -0,0 +1,96 @@
+import os
+from unittest.mock import patch
+
+import pytest
+from litellm.exceptions import BadRequestError
+
+from crewai.llm import LLM
+from crewai.utilities.llm_utils import create_llm
+
+
+def test_create_llm_with_llm_instance():
+    existing_llm = LLM(model="gpt-4o")
+    llm = create_llm(llm_value=existing_llm)
+    assert llm is existing_llm
+
+
+def test_create_llm_with_valid_model_string():
+    llm = create_llm(llm_value="gpt-4o")
+    assert isinstance(llm, LLM)
+    assert llm.model == "gpt-4o"
+
+
+def test_create_llm_with_invalid_model_string():
+    with pytest.raises(BadRequestError, match="LLM Provider NOT provided"):
+        llm = create_llm(llm_value="invalid-model")
+        llm.call(messages=[{"role": "user", "content": "Hello, world!"}])
+
+
+def test_create_llm_with_unknown_object_missing_attributes():
+    class UnknownObject:
+        pass
+
+    unknown_obj = UnknownObject()
+    llm = create_llm(llm_value=unknown_obj)
+
+    # Attempt to call the LLM and expect it to raise an error due to missing attributes
+    with pytest.raises(BadRequestError, match="LLM Provider NOT provided"):
+        llm.call(messages=[{"role": "user", "content": "Hello, world!"}])
+
+
+def test_create_llm_with_none_uses_default_model():
+    with patch.dict(os.environ, {}, clear=True):
+        with patch("crewai.cli.constants.DEFAULT_LLM_MODEL", "gpt-4o"):
+            llm = create_llm(llm_value=None)
+            assert isinstance(llm, LLM)
+            assert llm.model == "gpt-4o-mini"
+
+
+def test_create_llm_with_unknown_object():
+    class UnknownObject:
+        model_name = "gpt-4o"
+        temperature = 0.7
+        max_tokens = 1500
+
+    unknown_obj = UnknownObject()
+    llm = create_llm(llm_value=unknown_obj)
+    assert isinstance(llm, LLM)
+    assert llm.model == "gpt-4o"
+    assert llm.temperature == 0.7
+    assert llm.max_tokens == 1500
+
+
+def test_create_llm_from_env_with_unaccepted_attributes():
+    with patch.dict(
+        os.environ,
+        {
+            "OPENAI_MODEL_NAME": "gpt-3.5-turbo",
+            "AWS_ACCESS_KEY_ID": "fake-access-key",
+            "AWS_SECRET_ACCESS_KEY": "fake-secret-key",
+            "AWS_REGION_NAME": "us-west-2",
+        },
+    ):
+        llm = create_llm(llm_value=None)
+        assert isinstance(llm, LLM)
+        assert llm.model == "gpt-3.5-turbo"
+        assert not hasattr(llm, "AWS_ACCESS_KEY_ID")
+        assert not hasattr(llm, "AWS_SECRET_ACCESS_KEY")
+        assert not hasattr(llm, "AWS_REGION_NAME")
+
+
+def test_create_llm_with_partial_attributes():
+    class PartialAttributes:
+        model_name = "gpt-4o"
+        # temperature is missing
+
+    obj = PartialAttributes()
+    llm = create_llm(llm_value=obj)
+    assert isinstance(llm, LLM)
+    assert llm.model == "gpt-4o"
+    assert llm.temperature is None  # Should handle missing attributes gracefully
+
+
+def test_create_llm_with_invalid_type():
+    with pytest.raises(BadRequestError, match="LLM Provider NOT provided"):
+        llm = create_llm(llm_value=42)
+        llm.call(messages=[{"role": "user", "content": "Hello, world!"}])