cleaner refactor

src/crewai/knowledge/source/base_file_knowledge_source.py

@@ -2,7 +2,7 @@ from abc import ABC, abstractmethod
 from pathlib import Path
 from typing import Union, List, Dict, Any
 
-from pydantic import Field, PrivateAttr
+from pydantic import Field
 
 from crewai.knowledge.source.base_knowledge_source import BaseKnowledgeSource
 from crewai.utilities.logger import Logger
@@ -19,11 +19,11 @@ class BaseFileKnowledgeSource(BaseKnowledgeSource, ABC):
     )
     content: Dict[Path, str] = Field(init=False, default_factory=dict)
     storage: KnowledgeStorage = Field(default_factory=KnowledgeStorage)
-    _safe_file_paths: List[Path] = PrivateAttr(default_factory=list)
+    safe_file_paths: List[Path] = Field(default_factory=list)
 
     def model_post_init(self, _):
         """Post-initialization method to load content."""
-        self._safe_file_paths = self._process_file_paths()
+        self.safe_file_paths = self._process_file_paths()
         self.validate_paths()
         self.content = self.load_content()
 
@@ -34,21 +34,7 @@ class BaseFileKnowledgeSource(BaseKnowledgeSource, ABC):
 
     def validate_paths(self):
         """Validate the paths."""
-        if isinstance(self.file_path, str):
+        for path in self.safe_file_paths:
-            self.file_path = self.convert_to_path(self.file_path)
-        elif isinstance(self.file_path, list):
-            processed_paths = []
-            for path in self.file_path:
-                processed_paths.append(self.convert_to_path(path))
-            self.file_path = processed_paths
-
-        paths = [self.file_path] if isinstance(self.file_path, Path) else self.file_path
-        if not isinstance(paths, list):
-            raise ValueError("file_path must be a Path or a list of Paths")
-
-        paths = [Path(path) if isinstance(path, str) else path for path in paths]
-
-        for path in paths:
             if not path.exists():
                 self._logger.log(
                     "error",

src/crewai/knowledge/source/csv_knowledge_source.py

@@ -10,18 +10,15 @@ class CSVKnowledgeSource(BaseFileKnowledgeSource):
 
     def load_content(self) -> Dict[Path, str]:
         """Load and preprocess CSV file content."""
-
+        content_dict = {}
-        file_path = (
+        for file_path in self.safe_file_paths:
-            self.file_path[0] if isinstance(self.file_path, list) else self.file_path
+            with open(file_path, "r", encoding="utf-8") as csvfile:
-        )
+                reader = csv.reader(csvfile)
-        file_path = Path(file_path) if isinstance(file_path, str) else file_path
+                content = ""
-
+                for row in reader:
-        with open(file_path, "r", encoding="utf-8") as csvfile:
+                    content += " ".join(row) + "\n"
-            reader = csv.reader(csvfile)
+                content_dict[file_path] = content
-            content = ""
+        return content_dict
-            for row in reader:
-                content += " ".join(row) + "\n"
-        return {file_path: content}
 
     def add(self) -> None:
         """

src/crewai/knowledge/source/excel_knowledge_source.py

@@ -10,14 +10,13 @@ class ExcelKnowledgeSource(BaseFileKnowledgeSource):
         """Load and preprocess Excel file content."""
         pd = self._import_dependencies()
 
-        if isinstance(self.file_path, list):
+        content_dict = {}
-            file_path = self.convert_to_path(self.file_path[0])
+        for file_path in self.safe_file_paths:
-        else:
+            file_path = self.convert_to_path(file_path)
-            file_path = self.convert_to_path(self.file_path)
+            df = pd.read_excel(file_path)
-
+            content = df.to_csv(index=False)
-        df = pd.read_excel(file_path)
+            content_dict[file_path] = content
-        content = df.to_csv(index=False)
+        return content_dict
-        return {file_path: content}
 
     def _import_dependencies(self):
         """Dynamically import dependencies."""

src/crewai/knowledge/source/json_knowledge_source.py

@@ -10,10 +10,8 @@ class JSONKnowledgeSource(BaseFileKnowledgeSource):
 
     def load_content(self) -> Dict[Path, str]:
         """Load and preprocess JSON file content."""
-        paths = [self.file_path] if isinstance(self.file_path, Path) else self.file_path
-
         content: Dict[Path, str] = {}
-        for path in paths:
+        for path in self.safe_file_paths:
             path = self.convert_to_path(path)
             with open(path, "r", encoding="utf-8") as json_file:
                 data = json.load(json_file)

src/crewai/knowledge/source/pdf_knowledge_source.py

@@ -11,10 +11,9 @@ class PDFKnowledgeSource(BaseFileKnowledgeSource):
         """Load and preprocess PDF file content."""
         pdfplumber = self._import_pdfplumber()
 
-        paths = [self.file_path] if isinstance(self.file_path, Path) else self.file_path
         content = {}
 
-        for path in paths:
+        for path in self.safe_file_paths:
             text = ""
             path = self.convert_to_path(path)
             with pdfplumber.open(path) as pdf:

src/crewai/knowledge/source/text_file_knowledge_source.py

@@ -9,10 +9,9 @@ class TextFileKnowledgeSource(BaseFileKnowledgeSource):
 
     def load_content(self) -> Dict[Path, str]:
         """Load and preprocess text file content."""
-        paths = [self.file_path] if isinstance(self.file_path, Path) else self.file_path
         content = {}
-        for path in paths:
+        for path in self.safe_file_paths:
-            path = Path(path)
+            path = self.convert_to_path(path)
             with open(path, "r", encoding="utf-8") as f:
                 content[path] = f.read()
         return content