andre/crewAI
1
0
Fork 0
mirror of https://github.com/crewAIInc/crewAI.git synced 2026-01-28 17:48:13 +00:00
Code Issues Actions 3 Packages Projects Releases Wiki Activity

feat: fix tests

Browse Source
This commit is contained in:
Eduardo Chiarotti
2024-08-08 21:01:02 -03:00
parent 45c16cfa6b
commit 87d4c5f092
2 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/crewai/cli/train_crew.py
View File

@@ -16,7 +16,7 @@ def train_crew(n_iterations: int, filename: str) -> None:
if n_iterations <= 0: if n_iterations <= 0:
raise ValueError("The number of iterations must be a positive integer.") raise ValueError("The number of iterations must be a positive integer.")
if filename.endswith(".pkl"): if not filename.endswith(".pkl"):
raise ValueError("The filename must not end with .pkl") raise ValueError("The filename must not end with .pkl")
result = subprocess.run(command, capture_output=False, text=True, check=True) result = subprocess.run(command, capture_output=False, text=True, check=True)

26
tests/cli/train_crew_test.py
View File

@@ -6,7 +6,6 @@ from crewai.cli.train_crew import train_crew
@mock.patch("crewai.cli.train_crew.subprocess.run") @mock.patch("crewai.cli.train_crew.subprocess.run")
def test_train_crew_positive_iterations(mock_subprocess_run): def test_train_crew_positive_iterations(mock_subprocess_run):
# Arrange
n_iterations = 5 n_iterations = 5
mock_subprocess_run.return_value = subprocess.CompletedProcess( mock_subprocess_run.return_value = subprocess.CompletedProcess(
args=["poetry", "run", "train", str(n_iterations)], args=["poetry", "run", "train", str(n_iterations)],
@@ -15,12 +14,10 @@ def test_train_crew_positive_iterations(mock_subprocess_run):
stderr="", stderr="",
) )
# Act train_crew(n_iterations, "trained_agents_data.pkl")
train_crew(n_iterations)
# Assert
mock_subprocess_run.assert_called_once_with( mock_subprocess_run.assert_called_once_with(
["poetry", "run", "train", str(n_iterations)], ["poetry", "run", "train", str(n_iterations), "trained_agents_data.pkl"],
capture_output=False, capture_output=False,
text=True, text=True,
check=True, check=True,
@@ -29,7 +26,7 @@ def test_train_crew_positive_iterations(mock_subprocess_run):
@mock.patch("crewai.cli.train_crew.click") @mock.patch("crewai.cli.train_crew.click")
def test_train_crew_zero_iterations(click): def test_train_crew_zero_iterations(click):
train_crew(0) train_crew(0, "trained_agents_data.pkl")
click.echo.assert_called_once_with( click.echo.assert_called_once_with(
"An unexpected error occurred: The number of iterations must be a positive integer.", "An unexpected error occurred: The number of iterations must be a positive integer.",
err=True, err=True,
@@ -38,7 +35,7 @@ def test_train_crew_zero_iterations(click):
@mock.patch("crewai.cli.train_crew.click") @mock.patch("crewai.cli.train_crew.click")
def test_train_crew_negative_iterations(click): def test_train_crew_negative_iterations(click):
train_crew(-2) train_crew(-2, "trained_agents_data.pkl")
click.echo.assert_called_once_with( click.echo.assert_called_once_with(
"An unexpected error occurred: The number of iterations must be a positive integer.", "An unexpected error occurred: The number of iterations must be a positive integer.",
err=True, err=True,
@@ -55,10 +52,13 @@ def test_train_crew_called_process_error(mock_subprocess_run, click):
output="Error", output="Error",
stderr="Some error occurred", stderr="Some error occurred",
) )
train_crew(n_iterations) train_crew(n_iterations, "trained_agents_data.pkl")
mock_subprocess_run.assert_called_once_with( mock_subprocess_run.assert_called_once_with(
["poetry", "run", "train", "5"], capture_output=False, text=True, check=True ["poetry", "run", "train", str(n_iterations), "trained_agents_data.pkl"],
capture_output=False,
text=True,
check=True,
) )
click.echo.assert_has_calls( click.echo.assert_has_calls(
[ [
@@ -74,13 +74,15 @@ def test_train_crew_called_process_error(mock_subprocess_run, click):
@mock.patch("crewai.cli.train_crew.click") @mock.patch("crewai.cli.train_crew.click")
@mock.patch("crewai.cli.train_crew.subprocess.run") @mock.patch("crewai.cli.train_crew.subprocess.run")
def test_train_crew_unexpected_exception(mock_subprocess_run, click): def test_train_crew_unexpected_exception(mock_subprocess_run, click):
# Arrange
n_iterations = 5 n_iterations = 5
mock_subprocess_run.side_effect = Exception("Unexpected error") mock_subprocess_run.side_effect = Exception("Unexpected error")
train_crew(n_iterations) train_crew(n_iterations, "trained_agents_data.pkl")
mock_subprocess_run.assert_called_once_with( mock_subprocess_run.assert_called_once_with(
["poetry", "run", "train", "5"], capture_output=False, text=True, check=True ["poetry", "run", "train", str(n_iterations), "trained_agents_data.pkl"],
capture_output=False,
text=True,
check=True,
) )
click.echo.assert_called_once_with( click.echo.assert_called_once_with(
"An unexpected error occurred: Unexpected error", err=True "An unexpected error occurred: Unexpected error", err=True