From 86844ff3df3aa8c0b21ed17e9987b87d0020cb18 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Sun, 9 Feb 2025 19:43:24 +0000 Subject: [PATCH] fix: Update _generate_embedding signature to match BaseRAGStorage Co-Authored-By: Joe Moura --- src/crewai/memory/storage/rag_storage.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/crewai/memory/storage/rag_storage.py b/src/crewai/memory/storage/rag_storage.py index 79c04852a..7008fc908 100644 --- a/src/crewai/memory/storage/rag_storage.py +++ b/src/crewai/memory/storage/rag_storage.py @@ -181,12 +181,15 @@ class RAGStorage(BaseRAGStorage): logging.error(f"Error during {self.type} search: {str(e)}") return [] - def _generate_embedding(self, text: str, metadata: Dict[str, Any]) -> None: + def _generate_embedding(self, text: str, metadata: Optional[Dict[str, Any]] = None) -> Any: """Generate and store embeddings for the given text. Args: text: The text to generate embeddings for - metadata: Additional metadata to store with the embeddings + metadata: Optional additional metadata to store with the embeddings + + Returns: + Any: The generated embedding or None if only storing """ if not hasattr(self, "app") or not hasattr(self, "collection"): self._initialize_app() @@ -197,6 +200,7 @@ class RAGStorage(BaseRAGStorage): metadatas=[metadata or {}], ids=[str(uuid.uuid4())], ) + return None except Exception as e: raise EmbeddingInitializationError(self.type, f"Failed to generate embedding: {str(e)}")