mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-01-24 15:48:23 +00:00
Address PR review feedback: enhance thread safety implementation
- Add logging import and structured error handling with logger - Update class docstring to document thread safety guarantees - Add thread-safe deregister_handler method with proper locking - Add comprehensive tests for handler deregistration thread safety - Add test for deregistering non-existent handlers - Improve error handling with structured logging and exc_info - Maintain backward compatibility while enhancing functionality Addresses review suggestions from PR #2992 while keeping the core thread safety fix intact and adding valuable enhancements. Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
@@ -160,3 +160,45 @@ def test_thread_safety_with_mixed_operations():
|
||||
future.result()
|
||||
|
||||
assert len(received_events) >= 0
|
||||
|
||||
|
||||
def test_handler_deregistration_thread_safety():
|
||||
"""Test that concurrent handler deregistration is thread-safe"""
|
||||
|
||||
handlers_to_remove = []
|
||||
|
||||
for i in range(10):
|
||||
def handler(source, event):
|
||||
pass
|
||||
handler.__name__ = f"handler_{i}"
|
||||
crewai_event_bus.register_handler(TestEvent, handler)
|
||||
handlers_to_remove.append(handler)
|
||||
|
||||
initial_count = len(crewai_event_bus._handlers.get(TestEvent, []))
|
||||
|
||||
def deregister_handler(handler):
|
||||
"""Deregister a handler from a specific thread"""
|
||||
return crewai_event_bus.deregister_handler(TestEvent, handler)
|
||||
|
||||
with ThreadPoolExecutor(max_workers=5) as executor:
|
||||
futures = []
|
||||
for handler in handlers_to_remove:
|
||||
future = executor.submit(deregister_handler, handler)
|
||||
futures.append(future)
|
||||
|
||||
results = [future.result() for future in futures]
|
||||
|
||||
assert all(results), "All handlers should be successfully deregistered"
|
||||
|
||||
remaining_count = len(crewai_event_bus._handlers.get(TestEvent, []))
|
||||
assert remaining_count == 0, f"Expected 0 handlers remaining, got {remaining_count}"
|
||||
|
||||
|
||||
def test_deregister_nonexistent_handler():
|
||||
"""Test deregistering a handler that doesn't exist"""
|
||||
|
||||
def dummy_handler(source, event):
|
||||
pass
|
||||
|
||||
result = crewai_event_bus.deregister_handler(TestEvent, dummy_handler)
|
||||
assert result is False, "Deregistering non-existent handler should return False"
|
||||
|
||||
Reference in New Issue
Block a user