mirror of
https://github.com/crewAIInc/crewAI.git
synced 2026-01-27 17:18:13 +00:00
Address code review feedback: improve model detection, parameter filtering, and test coverage
- Refactor _is_ollama_model to use constants for better maintainability - Make parameter filtering more explicit with clear comments - Add type hints for better code clarity - Add comprehensive edge case tests for model detection - Improve test docstrings with detailed descriptions - Move integration test to proper tests/ directory structure - Fix lint error in test script by adding assertion - All tests passing locally with improved code quality Co-Authored-By: João <joao@crewai.com>
This commit is contained in:
@@ -33,6 +33,8 @@ def test_original_issue():
|
||||
)
|
||||
print("✅ Agent creation with Ollama LLM succeeded")
|
||||
|
||||
assert agent.llm.model == "ollama/gemma3:latest"
|
||||
|
||||
except ValueError as e:
|
||||
if "does not support response_format" in str(e):
|
||||
print(f"❌ Original issue still exists: {e}")
|
||||
|
||||
Reference in New Issue
Block a user