From 6ebfe5fab0b5477b567c1f369f575e098865ecc1 Mon Sep 17 00:00:00 2001 From: Eduardo Chiarotti Date: Mon, 29 Jul 2024 22:55:35 -0300 Subject: [PATCH] feat: fix tests --- tests/cli/cli_test.py | 18 +++++++++--------- .../evaluators/test_crew_evaluator_handler.py | 5 +++++ 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/tests/cli/cli_test.py b/tests/cli/cli_test.py index 504975dc7..509b9193a 100644 --- a/tests/cli/cli_test.py +++ b/tests/cli/cli_test.py @@ -135,29 +135,29 @@ def test_version_command_with_tools(runner): ) -@mock.patch("crewai.cli.cli.test_crew") -def test_test_default_iterations(test_crew, runner): +@mock.patch("crewai.cli.cli.evaluate_crew") +def test_test_default_iterations(evaluate_crew, runner): result = runner.invoke(test) - test_crew.assert_called_once_with(3, "gpt-4o-mini") + evaluate_crew.assert_called_once_with(3, "gpt-4o-mini") assert result.exit_code == 0 assert "Testing the crew for 3 iterations with model gpt-4o-mini" in result.output -@mock.patch("crewai.cli.cli.test_crew") -def test_test_custom_iterations(test_crew, runner): +@mock.patch("crewai.cli.cli.evaluate_crew") +def test_test_custom_iterations(evaluate_crew, runner): result = runner.invoke(test, ["--n_iterations", "5", "--model", "gpt-4o"]) - test_crew.assert_called_once_with(5, "gpt-4o") + evaluate_crew.assert_called_once_with(5, "gpt-4o") assert result.exit_code == 0 assert "Testing the crew for 5 iterations with model gpt-4o" in result.output -@mock.patch("crewai.cli.cli.test_crew") -def test_test_invalid_string_iterations(test_crew, runner): +@mock.patch("crewai.cli.cli.evaluate_crew") +def test_test_invalid_string_iterations(evaluate_crew, runner): result = runner.invoke(test, ["--n_iterations", "invalid"]) - test_crew.assert_not_called() + evaluate_crew.assert_not_called() assert result.exit_code == 2 assert ( "Usage: test [OPTIONS]\nTry 'test --help' for help.\n\nError: Invalid value for '-n' / '--n_iterations': 'invalid' is not a valid integer.\n" diff --git a/tests/utilities/evaluators/test_crew_evaluator_handler.py b/tests/utilities/evaluators/test_crew_evaluator_handler.py index 39fa35c44..30fb7bf76 100644 --- a/tests/utilities/evaluators/test_crew_evaluator_handler.py +++ b/tests/utilities/evaluators/test_crew_evaluator_handler.py @@ -84,6 +84,10 @@ class TestCrewEvaluator: 1: [10, 9, 8], 2: [9, 8, 7], } + crew_planner.run_execution_times = { + 1: [24, 45, 66], + 2: [55, 33, 67], + } crew_planner.print_crew_evaluation_result() @@ -98,6 +102,7 @@ class TestCrewEvaluator: mock.call().add_row("Task 2", "9", "8", "8.5"), mock.call().add_row("Task 3", "8", "7", "7.5"), mock.call().add_row("Crew", "9.0", "8.0", "8.5"), + mock.call().add_row("Execution Time (s)", "135", "155", "145"), ] ) console.assert_has_calls([mock.call(), mock.call().print(table())])