diff --git a/docs/concepts/knowledge.mdx b/docs/concepts/knowledge.mdx index de3900bd7..7e826fd8c 100644 --- a/docs/concepts/knowledge.mdx +++ b/docs/concepts/knowledge.mdx @@ -174,7 +174,7 @@ class SpaceNewsKnowledgeSource(BaseKnowledgeSource): chunks = self._chunk_text(text) self.chunks.extend(chunks) - self.save_documents() + self._save_documents() # Create knowledge source recent_news = SpaceNewsKnowledgeSource( diff --git a/src/crewai/knowledge/source/base_file_knowledge_source.py b/src/crewai/knowledge/source/base_file_knowledge_source.py index 6e0250555..7f078b4a4 100644 --- a/src/crewai/knowledge/source/base_file_knowledge_source.py +++ b/src/crewai/knowledge/source/base_file_knowledge_source.py @@ -49,7 +49,7 @@ class BaseFileKnowledgeSource(BaseKnowledgeSource, ABC): color="red", ) - def save_documents(self): + def _save_documents(self): """Save the documents to the storage.""" self.storage.save(self.chunks) diff --git a/src/crewai/knowledge/source/base_knowledge_source.py b/src/crewai/knowledge/source/base_knowledge_source.py index 486db519c..07a9a0f25 100644 --- a/src/crewai/knowledge/source/base_knowledge_source.py +++ b/src/crewai/knowledge/source/base_knowledge_source.py @@ -41,7 +41,7 @@ class BaseKnowledgeSource(BaseModel, ABC): for i in range(0, len(text), self.chunk_size - self.chunk_overlap) ] - def save_documents(self): + def _save_documents(self): """ Save the documents to the storage. This method should be called after the chunks and embeddings are generated. diff --git a/src/crewai/knowledge/source/csv_knowledge_source.py b/src/crewai/knowledge/source/csv_knowledge_source.py index 41d13af30..3bb0714d9 100644 --- a/src/crewai/knowledge/source/csv_knowledge_source.py +++ b/src/crewai/knowledge/source/csv_knowledge_source.py @@ -30,7 +30,7 @@ class CSVKnowledgeSource(BaseFileKnowledgeSource): ) new_chunks = self._chunk_text(content_str) self.chunks.extend(new_chunks) - self.save_documents() + self._save_documents() def _chunk_text(self, text: str) -> List[str]: """Utility method to split text into chunks.""" diff --git a/src/crewai/knowledge/source/excel_knowledge_source.py b/src/crewai/knowledge/source/excel_knowledge_source.py index 5656974a8..d379c2763 100644 --- a/src/crewai/knowledge/source/excel_knowledge_source.py +++ b/src/crewai/knowledge/source/excel_knowledge_source.py @@ -45,7 +45,7 @@ class ExcelKnowledgeSource(BaseFileKnowledgeSource): new_chunks = self._chunk_text(content_str) self.chunks.extend(new_chunks) - self.save_documents() + self._save_documents() def _chunk_text(self, text: str) -> List[str]: """Utility method to split text into chunks.""" diff --git a/src/crewai/knowledge/source/json_knowledge_source.py b/src/crewai/knowledge/source/json_knowledge_source.py index e13695aa9..b02d438e6 100644 --- a/src/crewai/knowledge/source/json_knowledge_source.py +++ b/src/crewai/knowledge/source/json_knowledge_source.py @@ -42,7 +42,7 @@ class JSONKnowledgeSource(BaseFileKnowledgeSource): ) new_chunks = self._chunk_text(content_str) self.chunks.extend(new_chunks) - self.save_documents() + self._save_documents() def _chunk_text(self, text: str) -> List[str]: """Utility method to split text into chunks.""" diff --git a/src/crewai/knowledge/source/pdf_knowledge_source.py b/src/crewai/knowledge/source/pdf_knowledge_source.py index 661a35070..38cd67807 100644 --- a/src/crewai/knowledge/source/pdf_knowledge_source.py +++ b/src/crewai/knowledge/source/pdf_knowledge_source.py @@ -43,7 +43,7 @@ class PDFKnowledgeSource(BaseFileKnowledgeSource): for _, text in self.content.items(): new_chunks = self._chunk_text(text) self.chunks.extend(new_chunks) - self.save_documents() + self._save_documents() def _chunk_text(self, text: str) -> List[str]: """Utility method to split text into chunks.""" diff --git a/src/crewai/knowledge/source/string_knowledge_source.py b/src/crewai/knowledge/source/string_knowledge_source.py index a92706f71..1d40ac4b8 100644 --- a/src/crewai/knowledge/source/string_knowledge_source.py +++ b/src/crewai/knowledge/source/string_knowledge_source.py @@ -24,7 +24,7 @@ class StringKnowledgeSource(BaseKnowledgeSource): """Add string content to the knowledge source, chunk it, compute embeddings, and save them.""" new_chunks = self._chunk_text(self.content) self.chunks.extend(new_chunks) - self.save_documents() + self._save_documents() def _chunk_text(self, text: str) -> List[str]: """Utility method to split text into chunks.""" diff --git a/src/crewai/knowledge/source/text_file_knowledge_source.py b/src/crewai/knowledge/source/text_file_knowledge_source.py index 6aa6a6ffc..ddb1f2516 100644 --- a/src/crewai/knowledge/source/text_file_knowledge_source.py +++ b/src/crewai/knowledge/source/text_file_knowledge_source.py @@ -24,7 +24,7 @@ class TextFileKnowledgeSource(BaseFileKnowledgeSource): for _, text in self.content.items(): new_chunks = self._chunk_text(text) self.chunks.extend(new_chunks) - self.save_documents() + self._save_documents() def _chunk_text(self, text: str) -> List[str]: """Utility method to split text into chunks."""